* [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata() [not found] <00b101ceae16$ecb87c30$c6297490$%han@samsung.com> @ 2013-09-10 11:25 ` Jingoo Han 2013-09-10 21:56 ` Kalle Valo 2013-09-12 16:23 ` Kalle Valo 0 siblings, 2 replies; 4+ messages in thread From: Jingoo Han @ 2013-09-10 11:25 UTC (permalink / raw) To: 'John W. Linville' Cc: 'Kalle Valo', 'Jingoo Han', linux-wireless, ath10k The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/net/wireless/ath/ath10k/pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index e2f9ef5..5ef0422 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -2414,7 +2414,6 @@ err_region: err_device: pci_disable_device(pdev); err_ar: - pci_set_drvdata(pdev, NULL); ath10k_core_destroy(ar); err_ar_pci: /* call HIF PCI free here */ @@ -2442,7 +2441,6 @@ static void ath10k_pci_remove(struct pci_dev *pdev) ath10k_core_unregister(ar); - pci_set_drvdata(pdev, NULL); pci_iounmap(pdev, ar_pci->mem); pci_release_region(pdev, BAR_NUM); pci_clear_master(pdev); -- 1.7.10.4 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata() 2013-09-10 11:25 ` [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata() Jingoo Han @ 2013-09-10 21:56 ` Kalle Valo 2013-09-11 0:32 ` Jingoo Han 2013-09-12 16:23 ` Kalle Valo 1 sibling, 1 reply; 4+ messages in thread From: Kalle Valo @ 2013-09-10 21:56 UTC (permalink / raw) To: Jingoo Han; +Cc: linux-wireless, 'John W. Linville', ath10k Jingoo Han <jg1.han@samsung.com> writes: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> Thanks, look good. Do you want me to apply this to my ath.git tree or are you planning to send this via some other route? -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata() 2013-09-10 21:56 ` Kalle Valo @ 2013-09-11 0:32 ` Jingoo Han 0 siblings, 0 replies; 4+ messages in thread From: Jingoo Han @ 2013-09-11 0:32 UTC (permalink / raw) To: 'Kalle Valo' Cc: 'Jingoo Han', linux-wireless, 'John W. Linville', ath10k On Wednesday, September 11, 2013 6:57 AM, Kalle Valo wrote: > Jingoo Han <jg1.han@samsung.com> writes: > > > The driver core clears the driver data to NULL after device_release > > or on probe failure. Thus, it is not needed to manually clear the > > device driver data to NULL. > > > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > Thanks, look good. Do you want me to apply this to my ath.git tree or > are you planning to send this via some other route? > Hi Kalle Valo, It would be good that you apply this to your ath.git tree. Thank you. :-) Best regards, Jingoo Han _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata() 2013-09-10 11:25 ` [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata() Jingoo Han 2013-09-10 21:56 ` Kalle Valo @ 2013-09-12 16:23 ` Kalle Valo 1 sibling, 0 replies; 4+ messages in thread From: Kalle Valo @ 2013-09-12 16:23 UTC (permalink / raw) To: Jingoo Han; +Cc: linux-wireless, 'John W. Linville', ath10k Jingoo Han <jg1.han@samsung.com> writes: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> Thanks, applied. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-12 16:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
2013-09-10 11:25 ` [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-10 21:56 ` Kalle Valo
2013-09-11 0:32 ` Jingoo Han
2013-09-12 16:23 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox