From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
ath10k@lists.infradead.org
Subject: Re: [PATCH v2 7/8] ath10k: fix device initialization routine
Date: Thu, 17 Oct 2013 08:33:07 +0300 [thread overview]
Message-ID: <87zjq84g30.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=9cEwB7PY8VMGv1SmEPsH6WGmDEBgujmo9G=Cby82uyg@mail.gmail.com> (Michal Kazior's message of "Wed, 16 Oct 2013 09:01:52 -0700")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 16 October 2013 08:57, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>>> + /* disable pending irqs */
>>>> + ath10k_pci_core_write32(ar, PCIE_INTR_ENABLE_ADDRESS, 0);
>>>> + ath10k_pci_core_write32(ar, PCIE_INTR_CLR_ADDRESS, ~0);
>>>
>>> These use SOC_CORE_BASE_ADDRESS as the suffix, not the RTC_SOC_BASE_ADDRESS.
>>
>> But I am using SOC_CORE_BASE_ADDRESS, right?
>
> Ah, right. Sorry. My eyesight failed me :) Those function names seem a
> little confusing (_core_ for SOC_CORE and _soc_ for RTC_SOC)
Yeah, I agree. I didn't research what RTC_SOC stands for, I just assumed
it contains registers for controlling the whole SOC state. That's why I
used "_soc_" here. And CORE registers control just one part of SOC.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2013-10-17 5:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 13:45 [PATCH v2 0/8] ath10k: fixes 2013-10-15 Kalle Valo
2013-10-16 13:45 ` [PATCH v2 1/8] ath10k: prevent starting monitor without a vdev Kalle Valo
2013-10-16 13:45 ` [PATCH v2 2/8] ath10k: add sanity checks for monitor management Kalle Valo
2013-10-16 13:45 ` [PATCH v2 3/8] ath10k: fix endianess in prints Kalle Valo
2013-10-16 13:45 ` [PATCH v2 4/8] ath10k: fix NSS reporting in RX Kalle Valo
2013-10-16 13:46 ` [PATCH v2 5/8] ath10k: fix NULL deref upon early FW crash Kalle Valo
2013-10-16 13:46 ` [PATCH v2 6/8] ath10k: implement ath10k_pci_soc_read/write32() Kalle Valo
2013-10-16 15:38 ` Michal Kazior
2013-10-16 15:55 ` Kalle Valo
2013-10-16 13:46 ` [PATCH v2 7/8] ath10k: fix device initialization routine Kalle Valo
2013-10-16 15:44 ` Michal Kazior
2013-10-16 15:57 ` Kalle Valo
2013-10-16 16:01 ` Michal Kazior
2013-10-17 5:33 ` Kalle Valo [this message]
2013-10-16 13:46 ` [PATCH v2 8/8] ath10k: fix FW crashes on heavy TX on 10.1.389 AP FW Kalle Valo
2013-10-21 14:15 ` [PATCH v2 0/8] ath10k: fixes 2013-10-15 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjq84g30.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox