From: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
To: ath11k@lists.infradead.org
Subject: [PATCH] ath11k/qmi: Use memcpy_toio() function on I/O memory
Date: Wed, 8 May 2019 17:24:43 +0530 [thread overview]
Message-ID: <1557316483-18397-1-git-send-email-vthiagar@codeaurora.org> (raw)
The usage of memcpy() function on I/O memory is not recommended
when doing a bulk data copy. Instead use memcpy_toio() function
while copying bulk data to I/O memory. Using the right function
takes care of platform specific alignment requirement as well
in arm64. This fixes the below kernel crash due to unaligned
memory access in 64-bit arm during memory copy of board data to I/O
memory.
[ 15.672513] ath11k c000000.wifi1: Downloading BDF: IPQ8074/board-2.bin, size: 917972
[ 15.672635] Unhandled fault: alignment fault (0x96000061) at 0xffffff8007200004
[ 15.680449] Internal error: : 96000061 [#1] PREEMPT SMP
[ 15.946227] CPU: 0 PID: 890 Comm: kworker/u8:5 Tainted: P
[ 15.968272] task: ffffffc03cae9f80 ti: ffffffc03cae9f80 task.ti: ffffffc03cae9f80
[ 15.968552] PC is at __efistub_memcpy+0x48/0x180
[ 15.976011] LR is at ath11k_ce_get_attr_flags+0xc14/0x1594 [ath11k]
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/qmi.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index b862fa9..0bec067 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -1795,7 +1795,7 @@ static int ath11k_qmi_request_target_cap(struct ath11k_base *ab)
static int
ath11k_qmi_prepare_bdf_download(struct ath11k_base *ab, int type,
struct qmi_wlanfw_bdf_download_req_msg_v01 *req,
- void *bdf_addr)
+ void __iomem *bdf_addr)
{
struct device *dev = ab->dev;
char filename[ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE];
@@ -1813,7 +1813,7 @@ static int ath11k_qmi_request_target_cap(struct ath11k_base *ab)
}
fw_size = min_t(u32, ab->hw_params.fw.board_size, bd.len);
- memcpy(bdf_addr, bd.data, fw_size);
+ memcpy_toio(bdf_addr, bd.data, fw_size);
ath11k_core_free_bdf(ab, &bd);
break;
case ATH11K_QMI_FILE_TYPE_CALDATA:
@@ -1828,7 +1828,8 @@ static int ath11k_qmi_request_target_cap(struct ath11k_base *ab)
fw_size = min_t(u32, ab->hw_params.fw.board_size,
fw_entry->size);
- memcpy(bdf_addr + ATH11K_QMI_CALDATA_OFFSET, fw_entry->data, fw_size);
+ memcpy_toio(bdf_addr + ATH11K_QMI_CALDATA_OFFSET,
+ fw_entry->data, fw_size);
ath11k_info(ab, "qmi downloading BDF: %s, size: %zu\n",
filename, fw_entry->size);
--
1.9.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next reply other threads:[~2019-05-08 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 11:54 Vasanthakumar Thiagarajan [this message]
2019-05-13 14:03 ` [PATCH] ath11k/qmi: Use memcpy_toio() function on I/O memory Sven Eckelmann
2019-05-13 14:48 ` [PATCH] ath11k: qmi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557316483-18397-1-git-send-email-vthiagar@codeaurora.org \
--to=vthiagar@codeaurora.org \
--cc=ath11k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox