From: Kalle Valo <kvalo@codeaurora.org>
To: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
Cc: ath11k@lists.infradead.org
Subject: Re: [PATCH] ath11k: qmi: Use memcpy_toio() function on I/O memory
Date: Mon, 13 May 2019 14:48:11 +0000 (UTC) [thread overview]
Message-ID: <20190513144812.9441560AE0@smtp.codeaurora.org> (raw)
In-Reply-To: <1557316483-18397-1-git-send-email-vthiagar@codeaurora.org>
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> wrote:
> The usage of memcpy() function on I/O memory is not recommended
> when doing a bulk data copy. Instead use memcpy_toio() function
> while copying bulk data to I/O memory. Using the right function
> takes care of platform specific alignment requirement as well
> in arm64. This fixes the below kernel crash due to unaligned
> memory access in 64-bit arm during memory copy of board data to I/O
> memory.
>
> [ 15.672513] ath11k c000000.wifi1: Downloading BDF: IPQ8074/board-2.bin, size: 917972
> [ 15.672635] Unhandled fault: alignment fault (0x96000061) at 0xffffff8007200004
> [ 15.680449] Internal error: : 96000061 [#1] PREEMPT SMP
> [ 15.946227] CPU: 0 PID: 890 Comm: kworker/u8:5 Tainted: P
> [ 15.968272] task: ffffffc03cae9f80 ti: ffffffc03cae9f80 task.ti: ffffffc03cae9f80
> [ 15.968552] PC is at __efistub_memcpy+0x48/0x180
> [ 15.976011] LR is at ath11k_ce_get_attr_flags+0xc14/0x1594 [ath11k]
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
> Tested-by: Sven Eckelmann <sven@narfation.org>
Patch applied to ath.git, thanks.
83ac6fc1f56d ath11k: qmi: Use memcpy_toio() function on I/O memory
--
https://patchwork.kernel.org/patch/10935537/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2019-05-13 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 11:54 [PATCH] ath11k/qmi: Use memcpy_toio() function on I/O memory Vasanthakumar Thiagarajan
2019-05-13 14:03 ` Sven Eckelmann
2019-05-13 14:48 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513144812.9441560AE0@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=vthiagar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox