* [PATCH 1/5] ath11k: fix variable name warnings
@ 2019-06-25 4:13 Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 2/5] ath11k: avoid unnecessary 'out of memory' message Karthikeyan Periyasamy
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Karthikeyan Periyasamy @ 2019-06-25 4:13 UTC (permalink / raw)
To: ath11k; +Cc: Karthikeyan Periyasamy
drivers/net/wireless/ath/ath11k/wmi.h:2728: <BK_Minfree>
drivers/net/wireless/ath/ath11k/wmi.h:2729: <BE_Minfree>
drivers/net/wireless/ath/ath11k/wmi.h:2730: <VI_Minfree>
drivers/net/wireless/ath/ath11k/wmi.h:2731: <VO_Minfree>
drivers/net/wireless/ath/ath11k/wmi.h:2965: <bcn_txPower>
Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/wmi.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h
index 4e92bf0..779209a 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.h
+++ b/drivers/net/wireless/ath/ath11k/wmi.h
@@ -2725,10 +2725,10 @@ struct wmi_resource_config {
u32 num_ocb_schedules;
u32 flag1;
u32 smart_ant_cap;
- u32 BK_Minfree;
- u32 BE_Minfree;
- u32 VI_Minfree;
- u32 VO_Minfree;
+ u32 bk_minfree;
+ u32 be_minfree;
+ u32 vi_minfree;
+ u32 vo_minfree;
u32 alloc_frag_desc_for_data_pkt;
u32 num_ns_ext_tuples_cfg;
u32 bpf_instruction_size;
@@ -2962,7 +2962,7 @@ struct wmi_vdev_start_request_cmd {
u32 flags;
struct wmi_ssid ssid;
u32 bcn_tx_rate;
- u32 bcn_txPower;
+ u32 bcn_txpower;
u32 num_noa_descriptors;
u32 disable_hw_ack;
u32 preferred_tx_streams;
@@ -5122,10 +5122,10 @@ struct target_resource_config {
u32 max_frag_entries;
u32 max_peer_ext_stats;
u32 smart_ant_cap;
- u32 BK_Minfree;
- u32 BE_Minfree;
- u32 VI_Minfree;
- u32 VO_Minfree;
+ u32 bk_minfree;
+ u32 be_minfree;
+ u32 vi_minfree;
+ u32 vo_minfree;
u32 rx_batchmode;
u32 tt_support;
u32 atf_config;
--
1.9.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/5] ath11k: avoid unnecessary 'out of memory' message
2019-06-25 4:13 [PATCH 1/5] ath11k: fix variable name warnings Karthikeyan Periyasamy
@ 2019-06-25 4:13 ` Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 3/5] ath11k: fix space related warnings Karthikeyan Periyasamy
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Karthikeyan Periyasamy @ 2019-06-25 4:13 UTC (permalink / raw)
To: ath11k; +Cc: Karthikeyan Periyasamy
drivers/net/wireless/ath/ath11k/dp_rx.c:573: Possible unnecessary 'out of memory' message
drivers/net/wireless/ath/ath11k/wmi.c:4528: Possible unnecessary 'out of memory' message
Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 4 +---
drivers/net/wireless/ath/ath11k/wmi.c | 2 --
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index afe8399..17be3cc 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -569,10 +569,8 @@ static void ath11k_dp_rx_tid_del_func(struct ath11k_dp *dp, void *ctx,
}
elem = kzalloc(sizeof(*elem), GFP_ATOMIC);
- if (!elem) {
- ath11k_warn(ab, "failed to allocate memory for cache flush element\n");
+ if (!elem)
goto free_desc;
- }
elem->ts = jiffies;
memcpy(&elem->data, rx_tid, sizeof(*rx_tid));
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index f800c77..085ee32 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -4527,9 +4527,7 @@ static int ath11k_reg_chan_list_event(struct ath11k_base *ab, u8 *evt_buf, u32 l
struct ath11k *ar;
reg_info = kzalloc(sizeof(*reg_info), GFP_ATOMIC);
-
if (!reg_info) {
- ath11k_warn(ab, "Unable to allocate memory for processing chan_info event\n");
ret = -ENOMEM;
goto fallback;
}
--
1.9.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/5] ath11k: fix space related warnings
2019-06-25 4:13 [PATCH 1/5] ath11k: fix variable name warnings Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 2/5] ath11k: avoid unnecessary 'out of memory' message Karthikeyan Periyasamy
@ 2019-06-25 4:13 ` Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 4/5] ath11k: avoid min() warning Karthikeyan Periyasamy
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Karthikeyan Periyasamy @ 2019-06-25 4:13 UTC (permalink / raw)
To: ath11k; +Cc: Karthikeyan Periyasamy
drivers/net/wireless/ath/ath11k/dp.h:1482: Please don't use multiple blank lines
drivers/net/wireless/ath/ath11k/dp_rx.c:1072: code indent should use tabs where possible
drivers/net/wireless/ath/ath11k/dp_rx.c:1075: code indent should use tabs where possible
drivers/net/wireless/ath/ath11k/wmi.c:2321: "(foo*)" should be "(foo *)"
Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/dp.h | 1 -
drivers/net/wireless/ath/ath11k/dp_rx.c | 4 ++--
drivers/net/wireless/ath/ath11k/wmi.c | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp.h b/drivers/net/wireless/ath/ath11k/dp.h
index d533d7e..bda5ac2 100644
--- a/drivers/net/wireless/ath/ath11k/dp.h
+++ b/drivers/net/wireless/ath/ath11k/dp.h
@@ -1482,7 +1482,6 @@ struct ath11k_htt_extd_stats_msg {
u8 data[0];
} __packed;
-
struct htt_mac_addr {
u32 mac_addr_l32;
u32 mac_addr_h16;
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 17be3cc..0158f90 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -1069,10 +1069,10 @@ static u32 ath11k_bw_to_mac80211_bwflags(u8 bw)
mcs = HTT_USR_RATE_MCS(user_rate->rate_flags);
sgi = HTT_USR_RATE_GI(user_rate->rate_flags);
- /* Note: If host configured fixed rates and in some other special
+ /* Note: If host configured fixed rates and in some other special
* cases, the broadcast/management frames are sent in different rates.
* Firmware rate's control to be skipped for this?
- */
+ */
if (flags == WMI_RATE_PREAMBLE_VHT && mcs > 9) {
ath11k_warn(ab, "Invalid VHT mcs %hhd peer stats", mcs);
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index 085ee32..f56db77 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -2318,7 +2318,7 @@ int ath11k_wmi_pdev_peer_pktlog_filter(struct ath11k *ar, u8 *addr, u8 enable)
FIELD_PREP(WMI_TLV_LEN, 0);
ptr += TLV_HDR_SIZE;
- info = (struct wmi_pdev_pktlog_filter_info*)ptr;
+ info = (struct wmi_pdev_pktlog_filter_info *)ptr;
ether_addr_copy(info->peer_macaddr.addr, addr);
info->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_PDEV_PEER_PKTLOG_FILTER_INFO) |
--
1.9.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/5] ath11k: avoid min() warning
2019-06-25 4:13 [PATCH 1/5] ath11k: fix variable name warnings Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 2/5] ath11k: avoid unnecessary 'out of memory' message Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 3/5] ath11k: fix space related warnings Karthikeyan Periyasamy
@ 2019-06-25 4:13 ` Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 5/5] ath11k: fix brace warning Karthikeyan Periyasamy
2019-06-25 14:26 ` [PATCH 1/5] ath11k: fix variable name warnings Kalle Valo
4 siblings, 0 replies; 6+ messages in thread
From: Karthikeyan Periyasamy @ 2019-06-25 4:13 UTC (permalink / raw)
To: ath11k; +Cc: Karthikeyan Periyasamy
drivers/net/wireless/ath/ath11k/mac.c:4921: min() should probably be min_t(u32, ar->num_tx_chains, max(ath11k_mac_max_ht_nss(ht_mcs_mask),
Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/mac.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 7a6c927..1c437b2 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -4920,9 +4920,9 @@ static void ath11k_mac_disable_peer_fixed_rate(void *data,
nss = single_nss;
} else {
rate = WMI_FIXED_RATE_NONE;
- nss = min((u32)ar->num_tx_chains,
- max(ath11k_mac_max_ht_nss(ht_mcs_mask),
- ath11k_mac_max_vht_nss(vht_mcs_mask)));
+ nss = min_t(u32, ar->num_tx_chains,
+ max(ath11k_mac_max_ht_nss(ht_mcs_mask),
+ ath11k_mac_max_vht_nss(vht_mcs_mask)));
/* If multiple rates across different preambles are given
* we can reconfigure this info with all peers using PEER_ASSOC
--
1.9.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 5/5] ath11k: fix brace warning
2019-06-25 4:13 [PATCH 1/5] ath11k: fix variable name warnings Karthikeyan Periyasamy
` (2 preceding siblings ...)
2019-06-25 4:13 ` [PATCH 4/5] ath11k: avoid min() warning Karthikeyan Periyasamy
@ 2019-06-25 4:13 ` Karthikeyan Periyasamy
2019-06-25 14:26 ` [PATCH 1/5] ath11k: fix variable name warnings Kalle Valo
4 siblings, 0 replies; 6+ messages in thread
From: Karthikeyan Periyasamy @ 2019-06-25 4:13 UTC (permalink / raw)
To: ath11k; +Cc: Karthikeyan Periyasamy
drivers/net/wireless/ath/ath11k/dp_rx.c:1287: that open brace { should be on the previous line
Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 0158f90..7d49b3f 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -1284,8 +1284,7 @@ static void ath11k_htt_pktlog(struct ath11k_base *ab, struct sk_buff *skb)
len = FIELD_GET(HTT_T2H_PPDU_STATS_INFO_PAYLOAD_SIZE, data->hdr);
- if (len > ATH11K_HTT_PKTLOG_MAX_SIZE)
- {
+ if (len > ATH11K_HTT_PKTLOG_MAX_SIZE) {
ath11k_warn(ab, "htt pktlog buffer size %d, expected < %d\n",
len,
ATH11K_HTT_PKTLOG_MAX_SIZE);
--
1.9.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/5] ath11k: fix variable name warnings
2019-06-25 4:13 [PATCH 1/5] ath11k: fix variable name warnings Karthikeyan Periyasamy
` (3 preceding siblings ...)
2019-06-25 4:13 ` [PATCH 5/5] ath11k: fix brace warning Karthikeyan Periyasamy
@ 2019-06-25 14:26 ` Kalle Valo
4 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-06-25 14:26 UTC (permalink / raw)
To: Karthikeyan Periyasamy; +Cc: ath11k
Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote:
> drivers/net/wireless/ath/ath11k/wmi.h:2728: <BK_Minfree>
> drivers/net/wireless/ath/ath11k/wmi.h:2729: <BE_Minfree>
> drivers/net/wireless/ath/ath11k/wmi.h:2730: <VI_Minfree>
> drivers/net/wireless/ath/ath11k/wmi.h:2731: <VO_Minfree>
> drivers/net/wireless/ath/ath11k/wmi.h:2965: <bcn_txPower>
>
> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
5 patches applied to ath11k-bringup branch of ath.git, thanks.
1f200e02d5c1 ath11k: fix variable name warnings
323d5816437a ath11k: avoid unnecessary 'out of memory' message
f94a9da4292b ath11k: fix space related warnings
e8ab43824092 ath11k: avoid min() warning
4fed41ea71bf ath11k: fix brace warning
--
https://patchwork.kernel.org/patch/11014649/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-25 14:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-25 4:13 [PATCH 1/5] ath11k: fix variable name warnings Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 2/5] ath11k: avoid unnecessary 'out of memory' message Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 3/5] ath11k: fix space related warnings Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 4/5] ath11k: avoid min() warning Karthikeyan Periyasamy
2019-06-25 4:13 ` [PATCH 5/5] ath11k: fix brace warning Karthikeyan Periyasamy
2019-06-25 14:26 ` [PATCH 1/5] ath11k: fix variable name warnings Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox