[PATCH] ath11k: fix mutex definition without comment warning

[PATCH] ath11k: fix mutex definition without comment warning

[Karthikeyan Periyasamy]

drivers/net/wireless/ath/ath11k/core.h:446: struct mutex definition without comment
drivers/net/wireless/ath/ath11k/core.h:447: spinlock_t definition without comment
drivers/net/wireless/ath/ath11k/core.h:478: spinlock_t definition without comment

Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/core.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h
index 65c1a6d..e5b1747 100644
--- a/drivers/net/wireless/ath/ath11k/core.h
+++ b/drivers/net/wireless/ath/ath11k/core.h
@@ -443,8 +443,16 @@ struct ath11k {
 	u32 num_stations;
 	u32 max_num_stations;
 	bool monitor_present;
+	/* To synchronize concurrent synchronous mac80211 callback operations,
+	 * concurrent debugfs configuration and concurrent FW statistics events.
+	 */
 	struct mutex conf_mutex;
+	/* protects the radio specific data like debug stats, ppdu_stats_info stats,
+	 * vdev_stop_status info, scan data, ath11k_sta info, ath11k_vif info,
+	 * channel context data, survey info, test mode data.
+	 */
 	spinlock_t data_lock;
+
 	struct list_head arvifs;
 	/* should never be NULL; needed for regular htt rx */
 	struct ieee80211_channel *rx_channel;
@@ -475,6 +483,7 @@ struct ath11k {
 	u32 num_created_vdevs;
 
 	struct idr txmgmt_idr;
+	/* protects txmgmt_idr data */
 	spinlock_t txmgmt_idr_lock;
 
 	/* cycle count is reported twice for each visited channel during scan.
-- 
1.9.1


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

Re: [PATCH] ath11k: fix mutex definition without comment warning

[Kalle Valo]

Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote:

> drivers/net/wireless/ath/ath11k/core.h:446: struct mutex definition without comment
> drivers/net/wireless/ath/ath11k/core.h:447: spinlock_t definition without comment
> drivers/net/wireless/ath/ath11k/core.h:478: spinlock_t definition without comment
> 
> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath11k-bringup branch of ath.git, thanks.

5896237bc839 ath11k: fix mutex definition without comment warning

-- 
https://patchwork.kernel.org/patch/11015179/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k