[PATCH] ath11k: fix memory leak in testmode

[PATCH] ath11k: fix memory leak in testmode

[Karthikeyan Periyasamy]

when ath11k_wmi_cmd_send() fails, caller need to free up the skb.
In ath11k_tm_cmd_wmi(), skb free not happen when wmi command send
fails. so free up the skb in the error case.

Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/testmode.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath11k/testmode.c b/drivers/net/wireless/ath/ath11k/testmode.c
index 96ed2d2..9274b6c 100644
--- a/drivers/net/wireless/ath/ath11k/testmode.c
+++ b/drivers/net/wireless/ath/ath11k/testmode.c
@@ -160,6 +160,7 @@ static int ath11k_tm_cmd_wmi(struct ath11k *ar, struct nlattr *tb[])
 
 	ret = ath11k_wmi_cmd_send(wmi, skb, cmd_id);
 	if (ret) {
+		dev_kfree_skb(skb);
 		ath11k_warn(ar->ab, "failed to transmit wmi command (testmode): %d\n",
 			    ret);
 		goto out;
-- 
1.9.1


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

Re: [PATCH] ath11k: fix memory leak in testmode

[Kalle Valo]

Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote:

> when ath11k_wmi_cmd_send() fails, caller need to free up the skb.
> In ath11k_tm_cmd_wmi(), skb free not happen when wmi command send
> fails. so free up the skb in the error case.
> 
> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath11k-bringup branch of ath.git, thanks.

0c7d3c242f82 ath11k: fix memory leak in testmode

-- 
https://patchwork.kernel.org/patch/11046167/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k