* [PATCH] ath11k: Fix warnings that trigger during peer assoc when fixed rate is set
@ 2019-07-16 14:41 Sriram R
2019-07-18 11:19 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Sriram R @ 2019-07-16 14:41 UTC (permalink / raw)
To: ath11k; +Cc: Sriram R
When VHT fixed rate is set to MCS < 7, warnings are seen when a new sta
gets associated while peer_assoc command is sent to firmware. This is
seen since we expect tx_mcs_set sent to firmware as values corresponding
to range 0-7, 0-8 or 0-9. Since the intersection of STA's VHT MCS support
and current bitrate mask after fixed rate is set has MCS < 7 warning is
thrown currently.
Remove these warning for these cases as it's a valid scenario.
For these cases, 0-7 MCS can be sent during peer assoc to firmware as
this is followed by peer fixed rate setting.
Signed-off-by: Sriram R <srirrama@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/mac.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 3dc0615..b8217e9 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -1007,12 +1007,6 @@ ath11k_peer_assoc_h_vht_limit(u16 tx_mcs_set,
case 4: /* fall through */
case 5: /* fall through */
case 6: /* fall through */
- default:
- WARN_ON(1);
- /* fall through */
- case -1:
- mcs = IEEE80211_VHT_MCS_NOT_SUPPORTED;
- break;
case 7:
mcs = IEEE80211_VHT_MCS_SUPPORT_0_7;
break;
@@ -1022,6 +1016,12 @@ ath11k_peer_assoc_h_vht_limit(u16 tx_mcs_set,
case 9:
mcs = IEEE80211_VHT_MCS_SUPPORT_0_9;
break;
+ default:
+ WARN_ON(1);
+ /* fall through */
+ case -1:
+ mcs = IEEE80211_VHT_MCS_NOT_SUPPORTED;
+ break;
}
tx_mcs_set &= ~(0x3 << (nss * 2));
--
2.7.4
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-18 11:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-16 14:41 [PATCH] ath11k: Fix warnings that trigger during peer assoc when fixed rate is set Sriram R
2019-07-18 11:19 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox