ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH bringup] ath11k: fix tkip mic error reporting to cfg80211
@ 2019-10-11  7:02 Sathishkumar Muruganandam
  2019-10-15 12:49 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Sathishkumar Muruganandam @ 2019-10-11  7:02 UTC (permalink / raw)
  To: ath11k; +Cc: Sathishkumar Muruganandam

ieee80211_rx_status flag was not updated with MMIC_STRIPPED and DECRYPTED
bits during TKIP MIC error detection from RxDMA and hence this is not
getting reported to cfg80211_michael_mic_failure() for WPA countermeasures.

Signed-off-by: Sathishkumar Muruganandam <murugana@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index faea5b12a2d6..9491a479fab5 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -3021,7 +3021,8 @@ static void ath11k_dp_rx_h_tkip_mic_err(struct ath11k *ar, struct sk_buff *msdu,
 
 	ath11k_dp_rx_h_ppdu(ar, desc, status);
 
-	status->flag |= RX_FLAG_MMIC_ERROR;
+	status->flag |= (RX_FLAG_MMIC_STRIPPED | RX_FLAG_MMIC_ERROR |
+			 RX_FLAG_DECRYPTED);
 
 	ath11k_dp_rx_h_undecap(ar, msdu, desc,
 			       HAL_ENCRYPT_TYPE_TKIP_MIC, status, false);
-- 
2.7.4


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH bringup] ath11k: fix tkip mic error reporting to cfg80211
  2019-10-11  7:02 [PATCH bringup] ath11k: fix tkip mic error reporting to cfg80211 Sathishkumar Muruganandam
@ 2019-10-15 12:49 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-10-15 12:49 UTC (permalink / raw)
  To: Sathishkumar Muruganandam; +Cc: ath11k

Sathishkumar Muruganandam <murugana@codeaurora.org> wrote:

> ieee80211_rx_status flag was not updated with MMIC_STRIPPED and DECRYPTED
> bits during TKIP MIC error detection from RxDMA and hence this is not
> getting reported to cfg80211_michael_mic_failure() for WPA countermeasures.
> 
> Signed-off-by: Sathishkumar Muruganandam <murugana@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath11k-bringup branch of ath.git, thanks.

e44597a02dad ath11k: fix tkip mic error reporting to cfg80211

-- 
https://patchwork.kernel.org/patch/11184905/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-15 12:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-11  7:02 [PATCH bringup] ath11k: fix tkip mic error reporting to cfg80211 Sathishkumar Muruganandam
2019-10-15 12:49 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox