* [PATCH] ath11k: avoid burst time conversion logic
@ 2019-10-30 7:35 Karthikeyan Periyasamy
2019-11-07 9:06 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Karthikeyan Periyasamy @ 2019-10-30 7:35 UTC (permalink / raw)
To: ath11k; +Cc: Karthikeyan Periyasamy
WMI_VDEV_SET_WMM_PARAMS commmand expects the txoplimit param in the units of
32 microseconds. convert the txop unit from 32 microseconds to absolute
microseconds leads to the higher burst values which is incorrect. so no need
to convert the txop unit from 32 microseconds to absolute microseconds.
Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/mac.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 6f82fdb..412c258 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -3023,12 +3023,7 @@ static int ath11k_mac_op_conf_tx(struct ieee80211_hw *hw,
p->cwmin = params->cw_min;
p->cwmax = params->cw_max;
p->aifs = params->aifs;
-
- /* The channel time duration programmed in the HW is in absolute
- * microseconds, while mac80211 gives the txop in units of
- * 32 microseconds.
- */
- p->txop = params->txop * 32;
+ p->txop = params->txop;
ret = ath11k_wmi_send_wmm_update_cmd_tlv(ar, arvif->vdev_id,
&arvif->wmm_params);
--
1.9.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath11k: avoid burst time conversion logic
2019-10-30 7:35 [PATCH] ath11k: avoid burst time conversion logic Karthikeyan Periyasamy
@ 2019-11-07 9:06 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-11-07 9:06 UTC (permalink / raw)
To: Karthikeyan Periyasamy; +Cc: ath11k
Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote:
> WMI_VDEV_SET_WMM_PARAMS commmand expects the txoplimit param in the units of
> 32 microseconds. convert the txop unit from 32 microseconds to absolute
> microseconds leads to the higher burst values which is incorrect. so no need
> to convert the txop unit from 32 microseconds to absolute microseconds.
>
> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath11k-post-bringup branch of ath.git, thanks.
ecbd15739034 ath11k: avoid burst time conversion logic
--
https://patchwork.kernel.org/patch/11219119/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-07 9:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-30 7:35 [PATCH] ath11k: avoid burst time conversion logic Karthikeyan Periyasamy
2019-11-07 9:06 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox