From: Dan Carpenter <dan.carpenter@oracle.com>
To: akolli@codeaurora.org
Cc: ath11k@lists.infradead.org
Subject: [bug report] ath11k: Process full monitor mode rx support
Date: Tue, 11 Jan 2022 10:28:53 +0300 [thread overview]
Message-ID: <20220111072853.GL11243@kili> (raw)
Hello Anilkumar Kolli,
The patch 7e2ea2e94704: "ath11k: Process full monitor mode rx
support" from Dec 8, 2021, leads to the following Smatch static
checker warning:
drivers/net/wireless/ath/ath11k/dp_rx.c:5362 ath11k_dp_rx_full_mon_deliver_ppdu()
error: uninitialized symbol 'ret'.
drivers/net/wireless/ath/ath11k/dp_rx.c
5334 static int ath11k_dp_rx_full_mon_deliver_ppdu(struct ath11k *ar,
5335 int mac_id,
5336 struct ath11k_mon_data *pmon,
5337 struct napi_struct *napi)
5338 {
5339 struct ath11k_pdev_mon_stats *rx_mon_stats;
5340 struct dp_full_mon_mpdu *tmp;
5341 struct dp_full_mon_mpdu *mon_mpdu = pmon->mon_mpdu;
5342 struct sk_buff *head_msdu, *tail_msdu;
5343 struct ath11k_base *ab = ar->ab;
5344 struct ath11k_dp *dp = &ab->dp;
5345 int ret;
5346
5347 rx_mon_stats = &pmon->rx_mon_stats;
5348
5349 list_for_each_entry_safe(mon_mpdu, tmp, &dp->dp_full_mon_mpdu_list, list) {
5350 list_del(&mon_mpdu->list);
5351 head_msdu = mon_mpdu->head;
5352 tail_msdu = mon_mpdu->tail;
5353 if (head_msdu && tail_msdu) {
5354 ret = ath11k_dp_rx_mon_deliver(ar, mac_id, head_msdu,
5355 tail_msdu, napi);
Is it possible to never hit this assignment?
5356 rx_mon_stats->dest_mpdu_done++;
5357 ath11k_dbg(ar->ab, ATH11K_DBG_DATA, "full mon: deliver ppdu\n");
5358 }
5359 kfree(mon_mpdu);
5360 }
5361
--> 5362 return ret;
5363 }
regards,
dan carpenter
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
reply other threads:[~2022-01-11 7:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111072853.GL11243@kili \
--to=dan.carpenter@oracle.com \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox