[bug report] ath11k: Process full monitor mode rx support

[bug report] ath11k: Process full monitor mode rx support

[Dan Carpenter]

Hello Anilkumar Kolli,

The patch 7e2ea2e94704: "ath11k: Process full monitor mode rx
support" from Dec 8, 2021, leads to the following Smatch static
checker warning:

	drivers/net/wireless/ath/ath11k/dp_rx.c:5362 ath11k_dp_rx_full_mon_deliver_ppdu()
	error: uninitialized symbol 'ret'.

drivers/net/wireless/ath/ath11k/dp_rx.c
    5334 static int ath11k_dp_rx_full_mon_deliver_ppdu(struct ath11k *ar,
    5335                                               int mac_id,
    5336                                               struct ath11k_mon_data *pmon,
    5337                                               struct napi_struct *napi)
    5338 {
    5339         struct ath11k_pdev_mon_stats *rx_mon_stats;
    5340         struct dp_full_mon_mpdu *tmp;
    5341         struct dp_full_mon_mpdu *mon_mpdu = pmon->mon_mpdu;
    5342         struct sk_buff *head_msdu, *tail_msdu;
    5343         struct ath11k_base *ab = ar->ab;
    5344         struct ath11k_dp *dp = &ab->dp;
    5345         int ret;
    5346 
    5347         rx_mon_stats = &pmon->rx_mon_stats;
    5348 
    5349         list_for_each_entry_safe(mon_mpdu, tmp, &dp->dp_full_mon_mpdu_list, list) {
    5350                 list_del(&mon_mpdu->list);
    5351                 head_msdu = mon_mpdu->head;
    5352                 tail_msdu = mon_mpdu->tail;
    5353                 if (head_msdu && tail_msdu) {
    5354                         ret = ath11k_dp_rx_mon_deliver(ar, mac_id, head_msdu,
    5355                                                        tail_msdu, napi);

Is it possible to never hit this assignment?

    5356                         rx_mon_stats->dest_mpdu_done++;
    5357                         ath11k_dbg(ar->ab, ATH11K_DBG_DATA, "full mon: deliver ppdu\n");
    5358                 }
    5359                 kfree(mon_mpdu);
    5360         }
    5361 
--> 5362         return ret;
    5363 }

regards,
dan carpenter

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k