Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.

Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.

[Kalle Valo]

+ ath11k, wen

Dan Carpenter <dan.carpenter@oracle.com> writes:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   44a2f39e611ac0bc1f17c288a583d7f2e5684aa7
> commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k:
> purge rx pktlog when entering WoW
> config: i386-randconfig-m021-20220502
> (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn:
> inconsistent returns '&ar->conf_mutex'.
>
> vim +712 drivers/net/wireless/ath/ath11k/wow.c
>
> ba9177fcef21fa Carl Huang 2022-03-14 653 int
> ath11k_wow_op_resume(struct ieee80211_hw *hw)
> ba9177fcef21fa Carl Huang 2022-03-14  654  {
> ba9177fcef21fa Carl Huang 2022-03-14  655  	struct ath11k *ar = hw->priv;
> ba9177fcef21fa Carl Huang 2022-03-14  656  	int ret;
> ba9177fcef21fa Carl Huang 2022-03-14  657  
> ba9177fcef21fa Carl Huang 2022-03-14  658  	mutex_lock(&ar->conf_mutex);
> ba9177fcef21fa Carl Huang 2022-03-14  659  
> ba9177fcef21fa Carl Huang 2022-03-14  660  	ret = ath11k_hif_resume(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14  661  	if (ret) {
> ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed
> to resume hif: %d\n", ret);
> ba9177fcef21fa Carl Huang 2022-03-14  663  		goto exit;
> ba9177fcef21fa Carl Huang 2022-03-14  664  	}
> ba9177fcef21fa Carl Huang 2022-03-14  665  
> ba9177fcef21fa Carl Huang 2022-03-14  666  	ath11k_hif_ce_irq_enable(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14  667  	ath11k_hif_irq_enable(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14  668  
> 90bf5c8d0f7ecd Carl Huang 2022-03-14  669  	ret = ath11k_dp_rx_pktlog_start(ar->ab);
> 90bf5c8d0f7ecd Carl Huang 2022-03-14  670  	if (ret) {
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed
> to start rx pktlog from wow: %d\n", ret);
> 90bf5c8d0f7ecd Carl Huang 2022-03-14  672  		return ret;
>
> goto exit;

Carl or Wen, are you able to send a fix for this?

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.

[Dan Carpenter]

On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote:
> Hi Kalle,
> 
> Is the below the same fix that you have already applied to ath.git?
> 
> [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() -
> Patchwork (kernel.org) <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/
> >

That looks good.  It's sort of annoying for me to send a bug report a
month after the fix has been applied...  Sorry about that.

1) These are kbuild warnings.  The zero day bot generates the
warnings and I look them over and hit send.  I don't know why the kbuild
bot seems to get confused by -mm.  The subject says 408/8237 which is
pretty crazy.  Maybe I should just ignore the -mm patches?

2) The blamed patch came from a git tree but it had a Link tag to
lore.kernel.org so we could have used that as an In-Reply-to tag.
In an ideal world, all the bug reports for a patch would go to a
standard location.

Link: https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com

3) Another idea is that the kbuild bot could search lore for Fixes to
the original commit and include links to those threads?

regards,
dan carpenter


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.

[Kalle Valo]

Dan Carpenter <dan.carpenter@oracle.com> writes:

> On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote:
>> Hi Kalle,
>> 
>> Is the below the same fix that you have already applied to ath.git?
>> 
>> [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() -
>> Patchwork (kernel.org)
>> <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/
>> >
>
> That looks good.  It's sort of annoying for me to send a bug report a
> month after the fix has been applied...  Sorry about that.

My ath.git tree is not included in linux-wireless builds so there's also
a delay before linux-next sees the fix.

> 1) These are kbuild warnings.  The zero day bot generates the
> warnings and I look them over and hit send.  I don't know why the kbuild
> bot seems to get confused by -mm.  The subject says 408/8237 which is
> pretty crazy.  Maybe I should just ignore the -mm patches?

Yeah, I have been also wondering about using -mm for ath11k reports.
Does anyone know why that's happening?

> 2) The blamed patch came from a git tree but it had a Link tag to
> lore.kernel.org so we could have used that as an In-Reply-to tag.
> In an ideal world, all the bug reports for a patch would go to a
> standard location.
>
> Link:
> https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com

Yeah, that would be nice.

> 3) Another idea is that the kbuild bot could search lore for Fixes to
> the original commit and include links to those threads?

Yeah. Also searching for all references to the commit id from git log
would be nice.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

Re: [kbuild-all] Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.

[Chen, Rong A]

On 5/6/2022 4:46 PM, Kalle Valo wrote:
> Dan Carpenter <dan.carpenter@oracle.com> writes:
> 
>> On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote:
>>> Hi Kalle,
>>>
>>> Is the below the same fix that you have already applied to ath.git?
>>>
>>> [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() -
>>> Patchwork (kernel.org)
>>> <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/
>>>>
>>
>> That looks good.  It's sort of annoying for me to send a bug report a
>> month after the fix has been applied...  Sorry about that.
> 
> My ath.git tree is not included in linux-wireless builds so there's also
> a delay before linux-next sees the fix.

Hi,

Sorry for the overdue report , we'll take a look to prevent the same
problem arising again.

> 
>> 1) These are kbuild warnings.  The zero day bot generates the
>> warnings and I look them over and hit send.  I don't know why the kbuild
>> bot seems to get confused by -mm.  The subject says 408/8237 which is
>> pretty crazy.  Maybe I should just ignore the -mm patches?
> 
> Yeah, I have been also wondering about using -mm for ath11k reports.
> Does anyone know why that's happening?

We don't have a filter to ignore some warnings from specific branches,
we can create one to only report ath11k issues if found in ath.git,
please remind me if there are other rules.

> 
>> 2) The blamed patch came from a git tree but it had a Link tag to
>> lore.kernel.org so we could have used that as an In-Reply-to tag.
>> In an ideal world, all the bug reports for a patch would go to a
>> standard location.
>>
>> Link:
>> https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com
> 
> Yeah, that would be nice.

We have already linked the bug reports to the patch if the patch hasn't
been applied, I'm not sure is it possible to find the link of patch if
it's already applied in a branch.

> 
>> 3) Another idea is that the kbuild bot could search lore for Fixes to
>> the original commit and include links to those threads?
> 
> Yeah. Also searching for all references to the commit id from git log
> would be nice.
> 

Yes, It could avoid such false positive, we'll give it a try.

Best Regards,
Rong Chen

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

Re: [kbuild-all] Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.

[Dan Carpenter]

On Fri, May 06, 2022 at 05:58:22PM +0800, Chen, Rong A wrote:
> 
> 
> On 5/6/2022 4:46 PM, Kalle Valo wrote:
> > Dan Carpenter <dan.carpenter@oracle.com> writes:
> > 
> > > On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote:
> > > > Hi Kalle,
> > > > 
> > > > Is the below the same fix that you have already applied to ath.git?
> > > > 
> > > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() -
> > > > Patchwork (kernel.org)
> > > > <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/
> > > > > 
> > > 
> > > That looks good.  It's sort of annoying for me to send a bug report a
> > > month after the fix has been applied...  Sorry about that.
> > 
> > My ath.git tree is not included in linux-wireless builds so there's also
> > a delay before linux-next sees the fix.
> 
> Hi,
> 
> Sorry for the overdue report , we'll take a look to prevent the same
> problem arising again.
> 
> > 
> > > 1) These are kbuild warnings.  The zero day bot generates the
> > > warnings and I look them over and hit send.  I don't know why the kbuild
> > > bot seems to get confused by -mm.  The subject says 408/8237 which is
> > > pretty crazy.  Maybe I should just ignore the -mm patches?
> > 
> > Yeah, I have been also wondering about using -mm for ath11k reports.
> > Does anyone know why that's happening?
> 
> We don't have a filter to ignore some warnings from specific branches,
> we can create one to only report ath11k issues if found in ath.git,
> please remind me if there are other rules.
> 

The problem is really specific to the -mm tree.  They always have
look like they're a part of a 1000+ series of patches.  There was another
one today:

[kbuild] [linux-next:master 5904/9357] kernel/bpf/verifier.c:5331 process_kptr_func() warn: passing zero to 'PTR_ERR'

That warning is a false positive but a high quality false positive.
A lot of the "passing valid pointers" to PTR_ERR() bugs are caused
because Smatch thinks some arches have signed pointers.  I'm not sure
what's up with that...  :/  My bad.  Those are on me.

> > 
> > > 2) The blamed patch came from a git tree but it had a Link tag to
> > > lore.kernel.org so we could have used that as an In-Reply-to tag.
> > > In an ideal world, all the bug reports for a patch would go to a
> > > standard location.
> > > 
> > > Link:
> > > https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com
> > 
> > Yeah, that would be nice.
> 
> We have already linked the bug reports to the patch if the patch hasn't
> been applied, I'm not sure is it possible to find the link of patch if
> it's already applied in a branch.

You could git do:

	git show 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 | grep "Link: https://lore.kernel.org/r/"

Some of the links are to freedesktop which also has the msgid.

	Link: https://patchwork.freedesktop.org/patch/msgid/20220504090229.2506560-1-l.stach@pengutronix.de

We're really trying to discourage links to other websites because it's
not under our control and it will break.  And you wouldn't have the CC
list either...  But I still think it's useful.

regards,
dan carpenter


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.

[Kalle Valo]

Carl Huang <quic_cjhuang@quicinc.com> writes:

> Hi Kalle,
>
> Is the below the same fix that you have already applied to ath.git?
>
> [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - Patchwork (kernel.org)

BT please don't use HTML in emails, linux lists drop HTML email.

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k