* [PATCH AUTOSEL 6.4 03/10] Revert "wifi: ath11k: Enable threaded NAPI" [not found] <20230822113101.3549915-1-sashal@kernel.org> @ 2023-08-22 11:30 ` Sasha Levin 2023-08-22 16:02 ` Johan Hovold 0 siblings, 1 reply; 3+ messages in thread From: Sasha Levin @ 2023-08-22 11:30 UTC (permalink / raw) To: linux-kernel, stable Cc: Kalle Valo, Kalle Valo, Sasha Levin, quic_jjohnson, ath11k, linux-wireless From: Kalle Valo <quic_kvalo@quicinc.com> [ Upstream commit d265ebe41c911314bd273c218a37088835959fa1 ] This reverts commit 13aa2fb692d3717767303817f35b3e650109add3. This commit broke QCN9074 initialisation: [ 358.960477] ath11k_pci 0000:04:00.0: ce desc not available for wmi command 36866 [ 358.960481] ath11k_pci 0000:04:00.0: failed to send WMI_STA_POWERSAVE_PARAM_CMDID [ 358.960484] ath11k_pci 0000:04:00.0: could not set uapsd params -105 As there's no fix available let's just revert it to get QCN9074 working again. Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217536 Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20230720151444.2016637-1-kvalo@kernel.org Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/net/wireless/ath/ath11k/ahb.c | 1 - drivers/net/wireless/ath/ath11k/pcic.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c index 396548e57022f..88aeb36ab2e79 100644 --- a/drivers/net/wireless/ath/ath11k/ahb.c +++ b/drivers/net/wireless/ath/ath11k/ahb.c @@ -376,7 +376,6 @@ static void ath11k_ahb_ext_irq_enable(struct ath11k_base *ab) struct ath11k_ext_irq_grp *irq_grp = &ab->ext_irq_grp[i]; if (!irq_grp->napi_enabled) { - dev_set_threaded(&irq_grp->napi_ndev, true); napi_enable(&irq_grp->napi); irq_grp->napi_enabled = true; } diff --git a/drivers/net/wireless/ath/ath11k/pcic.c b/drivers/net/wireless/ath/ath11k/pcic.c index 30d66147223f4..a8bcffcf2e813 100644 --- a/drivers/net/wireless/ath/ath11k/pcic.c +++ b/drivers/net/wireless/ath/ath11k/pcic.c @@ -466,7 +466,6 @@ void ath11k_pcic_ext_irq_enable(struct ath11k_base *ab) struct ath11k_ext_irq_grp *irq_grp = &ab->ext_irq_grp[i]; if (!irq_grp->napi_enabled) { - dev_set_threaded(&irq_grp->napi_ndev, true); napi_enable(&irq_grp->napi); irq_grp->napi_enabled = true; } -- 2.40.1 -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH AUTOSEL 6.4 03/10] Revert "wifi: ath11k: Enable threaded NAPI" 2023-08-22 11:30 ` [PATCH AUTOSEL 6.4 03/10] Revert "wifi: ath11k: Enable threaded NAPI" Sasha Levin @ 2023-08-22 16:02 ` Johan Hovold 2023-08-23 18:03 ` Sasha Levin 0 siblings, 1 reply; 3+ messages in thread From: Johan Hovold @ 2023-08-22 16:02 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Kalle Valo, Kalle Valo, quic_jjohnson, ath11k, linux-wireless On Tue, Aug 22, 2023 at 07:30:53AM -0400, Sasha Levin wrote: > From: Kalle Valo <quic_kvalo@quicinc.com> > > [ Upstream commit d265ebe41c911314bd273c218a37088835959fa1 ] > > This reverts commit 13aa2fb692d3717767303817f35b3e650109add3. > > This commit broke QCN9074 initialisation: > > [ 358.960477] ath11k_pci 0000:04:00.0: ce desc not available for wmi command 36866 > [ 358.960481] ath11k_pci 0000:04:00.0: failed to send WMI_STA_POWERSAVE_PARAM_CMDID > [ 358.960484] ath11k_pci 0000:04:00.0: could not set uapsd params -105 > > As there's no fix available let's just revert it to get QCN9074 working again. > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217536 > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> > Signed-off-by: Kalle Valo <kvalo@kernel.org> > Link: https://lore.kernel.org/r/20230720151444.2016637-1-kvalo@kernel.org > Signed-off-by: Sasha Levin <sashal@kernel.org> This commit break machines like the Lenovo ThinkPad X13s so please do not backport until this has been resolved: https://lore.kernel.org/lkml/20230809073432.4193-1-johan+linaro@kernel.org Johan -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH AUTOSEL 6.4 03/10] Revert "wifi: ath11k: Enable threaded NAPI" 2023-08-22 16:02 ` Johan Hovold @ 2023-08-23 18:03 ` Sasha Levin 0 siblings, 0 replies; 3+ messages in thread From: Sasha Levin @ 2023-08-23 18:03 UTC (permalink / raw) To: Johan Hovold Cc: linux-kernel, stable, Kalle Valo, Kalle Valo, quic_jjohnson, ath11k, linux-wireless On Tue, Aug 22, 2023 at 06:02:32PM +0200, Johan Hovold wrote: >On Tue, Aug 22, 2023 at 07:30:53AM -0400, Sasha Levin wrote: >> From: Kalle Valo <quic_kvalo@quicinc.com> >> >> [ Upstream commit d265ebe41c911314bd273c218a37088835959fa1 ] >> >> This reverts commit 13aa2fb692d3717767303817f35b3e650109add3. >> >> This commit broke QCN9074 initialisation: >> >> [ 358.960477] ath11k_pci 0000:04:00.0: ce desc not available for wmi command 36866 >> [ 358.960481] ath11k_pci 0000:04:00.0: failed to send WMI_STA_POWERSAVE_PARAM_CMDID >> [ 358.960484] ath11k_pci 0000:04:00.0: could not set uapsd params -105 >> >> As there's no fix available let's just revert it to get QCN9074 working again. >> >> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217536 >> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> >> Signed-off-by: Kalle Valo <kvalo@kernel.org> >> Link: https://lore.kernel.org/r/20230720151444.2016637-1-kvalo@kernel.org >> Signed-off-by: Sasha Levin <sashal@kernel.org> > >This commit break machines like the Lenovo ThinkPad X13s so please do >not backport until this has been resolved: > > https://lore.kernel.org/lkml/20230809073432.4193-1-johan+linaro@kernel.org I'll drop it for now, thanks! -- Thanks, Sasha -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-23 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230822113101.3549915-1-sashal@kernel.org>
2023-08-22 11:30 ` [PATCH AUTOSEL 6.4 03/10] Revert "wifi: ath11k: Enable threaded NAPI" Sasha Levin
2023-08-22 16:02 ` Johan Hovold
2023-08-23 18:03 ` Sasha Levin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox