From: "Joseph S. Barrera III" <joebar@chromium.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: Rahul Bhattacharjee <quic_rbhattac@quicinc.com>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: ath11k: Fix qmi_msg_handler data structure initialization
Date: Fri, 28 Oct 2022 06:25:49 -0700 [thread overview]
Message-ID: <22be4248-9c5e-e6d3-5e49-e0d87ec52e4b@chromium.org> (raw)
In-Reply-To: <87pmecgrd2.fsf@kernel.org>
On 10/28/22 3:44 AM, Kalle Valo wrote:
> "Joseph S. Barrera III" <joebar@chromium.org> writes:
>> Do you want to add a comma after that last list element?
>
> I can add that in the pending branch.
I think that would be good.
> I would prefer to have a comment to make it more visible that an empty
> element is needed at the end, but I would add that outside of braces?
>
> /* end of list */
> {},
Ending a list with {}, is such a common idiom that adding a comment
is kind of just noise. And if you look at other such instances of
ending with an empty element, you'll find no comment, just the {},.
When making changes I prefer to stick to the existing coding style
as much as possible, so in this case I would definitely omit the
comment. But if you do feel like you need to add a comment, I would
keep it on the same line as the empty element, probably like
{}, // end of list
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-10-28 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 9:01 [PATCH] wifi: ath11k: Fix qmi_msg_handler data structure initialization Rahul Bhattacharjee
2022-10-26 19:46 ` Joseph S. Barrera III
2022-10-28 10:44 ` Kalle Valo
2022-10-28 10:49 ` Rahul Bhattacharjee
2022-10-28 13:25 ` Joseph S. Barrera III [this message]
2022-11-02 15:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22be4248-9c5e-e6d3-5e49-e0d87ec52e4b@chromium.org \
--to=joebar@chromium.org \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_rbhattac@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox