From: Kalle Valo <kvalo@kernel.org>
To: "Joseph S. Barrera III" <joebar@chromium.org>
Cc: Rahul Bhattacharjee <quic_rbhattac@quicinc.com>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: ath11k: Fix qmi_msg_handler data structure initialization
Date: Fri, 28 Oct 2022 13:44:09 +0300 [thread overview]
Message-ID: <87pmecgrd2.fsf@kernel.org> (raw)
In-Reply-To: <11e005c2-2363-d63f-9f3f-3ca811737231@chromium.org> (Joseph S. Barrera, III's message of "Wed, 26 Oct 2022 12:46:56 -0700")
"Joseph S. Barrera III" <joebar@chromium.org> writes:
> On 10/21/22 2:01 AM, Rahul Bhattacharjee wrote:
>
>> },
>> + {/* end of list */}
>> };
>
> Do you want to add a comma after that last list element?
I can add that in the pending branch.
>
> Actually, I normally see the last list element simply being
>
>> + {},
>
> ... with no comment necessary.
I would prefer to have a comment to make it more visible that an empty
element is needed at the end, but I would add that outside of braces?
/* end of list */
{},
Thoughts? I can change this in the pending branch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-10-28 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 9:01 [PATCH] wifi: ath11k: Fix qmi_msg_handler data structure initialization Rahul Bhattacharjee
2022-10-26 19:46 ` Joseph S. Barrera III
2022-10-28 10:44 ` Kalle Valo [this message]
2022-10-28 10:49 ` Rahul Bhattacharjee
2022-10-28 13:25 ` Joseph S. Barrera III
2022-11-02 15:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmecgrd2.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=joebar@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_rbhattac@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox