[PATCH] ath11k: fix compiler warnings for unused variables

[PATCH] ath11k: fix compiler warnings for unused variables

[John Crispin]

  CC [M]  drivers/net/wireless/ath/ath11k/core.o
drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_init':
drivers/net/wireless/ath/ath11k/core.c:609:10: warning: unused variable 'rproc_phandle' [-Wunused-variable]
phandle rproc_phandle;
^
drivers/net/wireless/ath/ath11k/core.c:608:16: warning: unused variable 'prproc' [-Wunused-variable]
struct rproc *prproc;
^
drivers/net/wireless/ath/ath11k/core.c:607:17: warning: unused variable 'dev' [-Wunused-variable]
struct device *dev = sc->dev;
^

Signed-off-by: John Crispin <john@phrozen.org>
---
 drivers/net/wireless/ath/ath11k/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 48a42cad4e14..af4aa8eabd81 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -747,11 +747,11 @@ static void ath11k_core_restart(struct work_struct *work)
 int ath11k_core_init(struct ath11k_base *sc)
 {
 	struct device *dev = sc->dev;
+#ifndef CONFIG_IPQ_SUBSYSTEM_RESTART
 	struct rproc *prproc;
 	phandle rproc_phandle;
 	int ret;
 
-#ifndef CONFIG_IPQ_SUBSYSTEM_RESTART
 	if (of_property_read_u32(dev->of_node, "q6_rproc", &rproc_phandle)) {
 		ath11k_err(sc, "failed to get q6_rproc handle\n");
 		return -ENOENT;
-- 
2.11.0


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

Re: [PATCH] ath11k: fix compiler warnings for unused variables

[Sven Eckelmann]

[-- Attachment #1.1: Type: text/plain, Size: 958 bytes --]

On Wednesday, 10 April 2019 07:58:40 CEST John Crispin wrote:
>   CC [M]  drivers/net/wireless/ath/ath11k/core.o
> drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_init':
> drivers/net/wireless/ath/ath11k/core.c:609:10: warning: unused variable 'rproc_phandle' [-Wunused-variable]
> phandle rproc_phandle;
> ^
> drivers/net/wireless/ath/ath11k/core.c:608:16: warning: unused variable 'prproc' [-Wunused-variable]
> struct rproc *prproc;
> ^
> drivers/net/wireless/ath/ath11k/core.c:607:17: warning: unused variable 'dev' [-Wunused-variable]
> struct device *dev = sc->dev;
> ^

This patch doesn't apply because they just dropped the 
CONFIG_IPQ_SUBSYSTEM_RESTART support (which is their only way to get the Q6 up 
in their 4.4 Hawkeye kernel) using a off-the-list patch [1] submission.

Kind regards,
	Sven

[1] https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath11k-bringup&id=426598fdbef82ace7b4a728445f61ecf034f233c

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

Re: [PATCH] ath11k: fix compiler warnings for unused variables

[Kalle Valo]

Sven Eckelmann <seckelmann@datto.com> writes:

> On Wednesday, 10 April 2019 07:58:40 CEST John Crispin wrote:
>>   CC [M]  drivers/net/wireless/ath/ath11k/core.o
>> drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_init':
>> drivers/net/wireless/ath/ath11k/core.c:609:10: warning: unused
>> variable 'rproc_phandle' [-Wunused-variable]
>> phandle rproc_phandle;
>> ^
>> drivers/net/wireless/ath/ath11k/core.c:608:16: warning: unused
>> variable 'prproc' [-Wunused-variable]
>> struct rproc *prproc;
>> ^
>> drivers/net/wireless/ath/ath11k/core.c:607:17: warning: unused
>> variable 'dev' [-Wunused-variable]
>> struct device *dev = sc->dev;
>> ^
>
> This patch doesn't apply because they just dropped the 
> CONFIG_IPQ_SUBSYSTEM_RESTART support (which is their only way to get the Q6 up 
> in their 4.4 Hawkeye kernel) using a off-the-list patch [1] submission.

BTW, now as the ath11k mailing list is up and running, I won't apply
patches directly to ath11k-bringup branch anymore. I only take them from
this list after review, I was thinking to wait minimum two days for
comments.

-- 
Kalle Valo

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k