* ath11k
@ 2024-04-29 14:53 Lindner, Frank
2024-04-30 1:54 ` ath11k Kang Yang
0 siblings, 1 reply; 13+ messages in thread
From: Lindner, Frank @ 2024-04-29 14:53 UTC (permalink / raw)
To: ath11k@lists.infradead.org
Hi dev-guys,
QCN9074 mPCIe-module with ath-next Kernel 6.9.0-rc1 (Ubuntu 24.04) causing Kernel Crash, when setting device to monitor mode. This does not happen instantly, it make take some time to fail.
[Mon Apr 29 14:17:57 2024] rcu: INFO: rcu_preempt self-detected stall on CPU
[Mon Apr 29 14:17:57 2024] rcu: 0-....: (15661 ticks this GP) idle=9394/1/0x4000000000000000 softirq=26961/26962 fqs=7499
[Mon Apr 29 14:17:57 2024] rcu: (t=15000 jiffies g=78093 q=1070 ncpus=16)
[Mon Apr 29 14:17:57 2024] CPU: 0 PID: 15 Comm: ksoftirqd/0 Tainted: G L 6.9.0-rc1-ath-next-j001 #11
[Mon Apr 29 14:17:57 2024] Hardware name: To Be Filled By O.E.M. Z590M Pro4/Z590M Pro4, BIOS P2.20 06/06/2022
[Mon Apr 29 14:17:57 2024] RIP: 0010:ath11k_hal_srng_dst_peek+0x18/0x30 [ath11k]
[Mon Apr 29 14:17:57 2024] Code: 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 66 0f 1f 00 0f 1f 44 00 00 55 8b 46 60 45 31 c0 48 89 e5 3b 46 70 74 08 <48> 8b 56 10 4c 8d 04 82 4c 89 c0 5d c3 cc cc cc cc 0f 1f 80 00 00
[Mon Apr 29 14:17:57 2024] RSP: 0018:ffffba0e80113b90 EFLAGS: 00000283
[Mon Apr 29 14:17:57 2024] RAX: 0000000000001bf8 RBX: ffff924e4a81a3f8 RCX: 0000000000000000
[Mon Apr 29 14:17:57 2024] RDX: 0000000000000c0a RSI: ffff924e45347088 RDI: ffff924e45340000
[Mon Apr 29 14:17:57 2024] RBP: ffffba0e80113b90 R08: 0000000000000000 R09: ffff924e4a81a1d0
[Mon Apr 29 14:17:57 2024] R10: ffffba0e80113ae8 R11: 000000000000ffff R12: 0000000000000000
[Mon Apr 29 14:17:57 2024] R13: ffff924e4a819fe0 R14: ffff924e4d575c00 R15: ffff924e45347088
[Mon Apr 29 14:17:57 2024] FS: 0000000000000000(0000) GS:ffff926d1ee00000(0000) knlGS:0000000000000000
[Mon Apr 29 14:17:57 2024] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[Mon Apr 29 14:17:57 2024] CR2: 00007fcc86d166e0 CR3: 000000082703c003 CR4: 0000000000770ef0
[Mon Apr 29 14:17:57 2024] PKRU: 55555554
[Mon Apr 29 14:17:57 2024] Call Trace:
[Mon Apr 29 14:17:57 2024] <IRQ>
[Mon Apr 29 14:17:57 2024] ? show_regs+0x6d/0x80
[Mon Apr 29 14:17:57 2024] ? dump_cpu_task+0x75/0x90
[Mon Apr 29 14:17:57 2024] ? rcu_dump_cpu_stacks+0xeb/0x180
[Mon Apr 29 14:17:57 2024] ? rcu_sched_clock_irq+0x572/0x1330
[Mon Apr 29 14:17:57 2024] ? raw_notifier_call_chain+0x1a/0x20
[Mon Apr 29 14:17:57 2024] ? timekeeping_update+0xf7/0x150
[Mon Apr 29 14:17:57 2024] ? account_system_index_time+0x9f/0xc0
[Mon Apr 29 14:17:57 2024] ? update_process_times+0x75/0xc0
[Mon Apr 29 14:17:57 2024] ? tick_nohz_handler+0xdc/0x140
[Mon Apr 29 14:17:57 2024] ? __pfx_tick_nohz_handler+0x10/0x10
[Mon Apr 29 14:17:57 2024] ? __hrtimer_run_queues+0x10e/0x290
[Mon Apr 29 14:17:57 2024] ? clockevents_program_event+0xae/0x130
[Mon Apr 29 14:17:57 2024] ? hrtimer_interrupt+0x108/0x240
[Mon Apr 29 14:17:57 2024] ? handle_edge_irq+0xde/0x240
[Mon Apr 29 14:17:57 2024] ? __sysvec_apic_timer_interrupt+0x5a/0x150
[Mon Apr 29 14:17:57 2024] ? sysvec_apic_timer_interrupt+0x7f/0x90
[Mon Apr 29 14:17:57 2024] </IRQ>
[Mon Apr 29 14:17:57 2024] <TASK>
[Mon Apr 29 14:17:57 2024] ? asm_sysvec_apic_timer_interrupt+0x1f/0x30
[Mon Apr 29 14:17:57 2024] ? ath11k_hal_srng_dst_peek+0x18/0x30 [ath11k]
[Mon Apr 29 14:17:57 2024] ath11k_dp_rx_process_mon_status+0xc45/0x1190 [ath11k]
[Mon Apr 29 14:17:57 2024] ? idr_alloc_u32+0x97/0xd0
[Mon Apr 29 14:17:57 2024] ath11k_dp_rx_process_mon_rings+0x32a/0x550 [ath11k]
[Mon Apr 29 14:17:57 2024] ath11k_dp_service_srng+0x289/0x5a0 [ath11k]
[Mon Apr 29 14:17:57 2024] ath11k_pcic_ext_grp_napi_poll+0x30/0xd0 [ath11k]
[Mon Apr 29 14:17:57 2024] __napi_poll+0x30/0x1f0
[Mon Apr 29 14:17:57 2024] net_rx_action+0x198/0x320
[Mon Apr 29 14:17:57 2024] __do_softirq+0xdd/0x319
[Mon Apr 29 14:17:57 2024] ? __pfx_smpboot_thread_fn+0x10/0x10
[Mon Apr 29 14:17:57 2024] run_ksoftirqd+0x31/0x50
[Mon Apr 29 14:17:57 2024] smpboot_thread_fn+0xe3/0x1e0
[Mon Apr 29 14:17:57 2024] kthread+0xf5/0x130
[Mon Apr 29 14:17:57 2024] ? __pfx_kthread+0x10/0x10
[Mon Apr 29 14:17:57 2024] ret_from_fork+0x3d/0x60
[Mon Apr 29 14:17:57 2024] ? __pfx_kthread+0x10/0x10
[Mon Apr 29 14:17:57 2024] ret_from_fork_asm+0x1a/0x30
[Mon Apr 29 14:17:57 2024] </TASK>
Any ideas?
BR Frank
Vorstand: Dirk Wilhelm (V), Wulf Jannsen
Aufsichtsrat: Ron Scheepers (V)
Handelsregister: HRB Saarbrücken Nr. 13201
Ust.ID Nr.: DE 153807627
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ath11k
2024-04-29 14:53 ath11k Lindner, Frank
@ 2024-04-30 1:54 ` Kang Yang
2024-04-30 2:03 ` ath11k Jeff Johnson
0 siblings, 1 reply; 13+ messages in thread
From: Kang Yang @ 2024-04-30 1:54 UTC (permalink / raw)
To: Lindner, Frank, ath11k@lists.infradead.org
On 4/29/2024 10:53 PM, Lindner, Frank wrote:
> Hi dev-guys,
>
> QCN9074 mPCIe-module with ath-next Kernel 6.9.0-rc1 (Ubuntu 24.04) causing Kernel Crash, when setting device to monitor mode. This does not happen instantly, it make take some time to fail.
>
> [Mon Apr 29 14:17:57 2024] rcu: INFO: rcu_preempt self-detected stall on CPU
> [Mon Apr 29 14:17:57 2024] rcu: 0-....: (15661 ticks this GP) idle=9394/1/0x4000000000000000 softirq=26961/26962 fqs=7499
> [Mon Apr 29 14:17:57 2024] rcu: (t=15000 jiffies g=78093 q=1070 ncpus=16)
> [Mon Apr 29 14:17:57 2024] CPU: 0 PID: 15 Comm: ksoftirqd/0 Tainted: G L 6.9.0-rc1-ath-next-j001 #11
> [Mon Apr 29 14:17:57 2024] Hardware name: To Be Filled By O.E.M. Z590M Pro4/Z590M Pro4, BIOS P2.20 06/06/2022
> [Mon Apr 29 14:17:57 2024] RIP: 0010:ath11k_hal_srng_dst_peek+0x18/0x30 [ath11k]
> [Mon Apr 29 14:17:57 2024] Code: 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 66 0f 1f 00 0f 1f 44 00 00 55 8b 46 60 45 31 c0 48 89 e5 3b 46 70 74 08 <48> 8b 56 10 4c 8d 04 82 4c 89 c0 5d c3 cc cc cc cc 0f 1f 80 00 00
> [Mon Apr 29 14:17:57 2024] RSP: 0018:ffffba0e80113b90 EFLAGS: 00000283
> [Mon Apr 29 14:17:57 2024] RAX: 0000000000001bf8 RBX: ffff924e4a81a3f8 RCX: 0000000000000000
> [Mon Apr 29 14:17:57 2024] RDX: 0000000000000c0a RSI: ffff924e45347088 RDI: ffff924e45340000
> [Mon Apr 29 14:17:57 2024] RBP: ffffba0e80113b90 R08: 0000000000000000 R09: ffff924e4a81a1d0
> [Mon Apr 29 14:17:57 2024] R10: ffffba0e80113ae8 R11: 000000000000ffff R12: 0000000000000000
> [Mon Apr 29 14:17:57 2024] R13: ffff924e4a819fe0 R14: ffff924e4d575c00 R15: ffff924e45347088
> [Mon Apr 29 14:17:57 2024] FS: 0000000000000000(0000) GS:ffff926d1ee00000(0000) knlGS:0000000000000000
> [Mon Apr 29 14:17:57 2024] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [Mon Apr 29 14:17:57 2024] CR2: 00007fcc86d166e0 CR3: 000000082703c003 CR4: 0000000000770ef0
> [Mon Apr 29 14:17:57 2024] PKRU: 55555554
> [Mon Apr 29 14:17:57 2024] Call Trace:
> [Mon Apr 29 14:17:57 2024] <IRQ>
> [Mon Apr 29 14:17:57 2024] ? show_regs+0x6d/0x80
> [Mon Apr 29 14:17:57 2024] ? dump_cpu_task+0x75/0x90
> [Mon Apr 29 14:17:57 2024] ? rcu_dump_cpu_stacks+0xeb/0x180
> [Mon Apr 29 14:17:57 2024] ? rcu_sched_clock_irq+0x572/0x1330
> [Mon Apr 29 14:17:57 2024] ? raw_notifier_call_chain+0x1a/0x20
> [Mon Apr 29 14:17:57 2024] ? timekeeping_update+0xf7/0x150
> [Mon Apr 29 14:17:57 2024] ? account_system_index_time+0x9f/0xc0
> [Mon Apr 29 14:17:57 2024] ? update_process_times+0x75/0xc0
> [Mon Apr 29 14:17:57 2024] ? tick_nohz_handler+0xdc/0x140
> [Mon Apr 29 14:17:57 2024] ? __pfx_tick_nohz_handler+0x10/0x10
> [Mon Apr 29 14:17:57 2024] ? __hrtimer_run_queues+0x10e/0x290
> [Mon Apr 29 14:17:57 2024] ? clockevents_program_event+0xae/0x130
> [Mon Apr 29 14:17:57 2024] ? hrtimer_interrupt+0x108/0x240
> [Mon Apr 29 14:17:57 2024] ? handle_edge_irq+0xde/0x240
> [Mon Apr 29 14:17:57 2024] ? __sysvec_apic_timer_interrupt+0x5a/0x150
> [Mon Apr 29 14:17:57 2024] ? sysvec_apic_timer_interrupt+0x7f/0x90
> [Mon Apr 29 14:17:57 2024] </IRQ>
> [Mon Apr 29 14:17:57 2024] <TASK>
> [Mon Apr 29 14:17:57 2024] ? asm_sysvec_apic_timer_interrupt+0x1f/0x30
> [Mon Apr 29 14:17:57 2024] ? ath11k_hal_srng_dst_peek+0x18/0x30 [ath11k]
> [Mon Apr 29 14:17:57 2024] ath11k_dp_rx_process_mon_status+0xc45/0x1190 [ath11k]
> [Mon Apr 29 14:17:57 2024] ? idr_alloc_u32+0x97/0xd0
> [Mon Apr 29 14:17:57 2024] ath11k_dp_rx_process_mon_rings+0x32a/0x550 [ath11k]
> [Mon Apr 29 14:17:57 2024] ath11k_dp_service_srng+0x289/0x5a0 [ath11k]
> [Mon Apr 29 14:17:57 2024] ath11k_pcic_ext_grp_napi_poll+0x30/0xd0 [ath11k]
> [Mon Apr 29 14:17:57 2024] __napi_poll+0x30/0x1f0
> [Mon Apr 29 14:17:57 2024] net_rx_action+0x198/0x320
> [Mon Apr 29 14:17:57 2024] __do_softirq+0xdd/0x319
> [Mon Apr 29 14:17:57 2024] ? __pfx_smpboot_thread_fn+0x10/0x10
> [Mon Apr 29 14:17:57 2024] run_ksoftirqd+0x31/0x50
> [Mon Apr 29 14:17:57 2024] smpboot_thread_fn+0xe3/0x1e0
> [Mon Apr 29 14:17:57 2024] kthread+0xf5/0x130
> [Mon Apr 29 14:17:57 2024] ? __pfx_kthread+0x10/0x10
> [Mon Apr 29 14:17:57 2024] ret_from_fork+0x3d/0x60
> [Mon Apr 29 14:17:57 2024] ? __pfx_kthread+0x10/0x10
> [Mon Apr 29 14:17:57 2024] ret_from_fork_asm+0x1a/0x30
> [Mon Apr 29 14:17:57 2024] </TASK>
>
> Any ideas?
Add 'spin_lock_bh(&srng->lock)' and 'spin_unlock_bh(&pmon->mon_lock)' in
ath11k_dp_rx_mon_dest_process().
BTW, next time please use an appropriate title instead of 'ath11k'🙂.
>
> BR Frank
>
>
>
>
> Vorstand: Dirk Wilhelm (V), Wulf Jannsen
> Aufsichtsrat: Ron Scheepers (V)
> Handelsregister: HRB Saarbrücken Nr. 13201
> Ust.ID Nr.: DE 153807627
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ath11k
2024-04-30 1:54 ` ath11k Kang Yang
@ 2024-04-30 2:03 ` Jeff Johnson
2024-04-30 2:09 ` ath11k Kang Yang
0 siblings, 1 reply; 13+ messages in thread
From: Jeff Johnson @ 2024-04-30 2:03 UTC (permalink / raw)
To: Kang Yang, Lindner, Frank, ath11k@lists.infradead.org
On 4/29/2024 6:54 PM, Kang Yang wrote:
>
>
> On 4/29/2024 10:53 PM, Lindner, Frank wrote:
>> Hi dev-guys,
>>
>> QCN9074 mPCIe-module with ath-next Kernel 6.9.0-rc1 (Ubuntu 24.04) causing Kernel Crash, when setting device to monitor mode. This does not happen instantly, it make take some time to fail.
>>
>> [Mon Apr 29 14:17:57 2024] rcu: INFO: rcu_preempt self-detected stall on CPU
>> [Mon Apr 29 14:17:57 2024] rcu: 0-....: (15661 ticks this GP) idle=9394/1/0x4000000000000000 softirq=26961/26962 fqs=7499
>> [Mon Apr 29 14:17:57 2024] rcu: (t=15000 jiffies g=78093 q=1070 ncpus=16)
>> [Mon Apr 29 14:17:57 2024] CPU: 0 PID: 15 Comm: ksoftirqd/0 Tainted: G L 6.9.0-rc1-ath-next-j001 #11
>> [Mon Apr 29 14:17:57 2024] Hardware name: To Be Filled By O.E.M. Z590M Pro4/Z590M Pro4, BIOS P2.20 06/06/2022
>> [Mon Apr 29 14:17:57 2024] RIP: 0010:ath11k_hal_srng_dst_peek+0x18/0x30 [ath11k]
>> [Mon Apr 29 14:17:57 2024] Code: 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 66 0f 1f 00 0f 1f 44 00 00 55 8b 46 60 45 31 c0 48 89 e5 3b 46 70 74 08 <48> 8b 56 10 4c 8d 04 82 4c 89 c0 5d c3 cc cc cc cc 0f 1f 80 00 00
>> [Mon Apr 29 14:17:57 2024] RSP: 0018:ffffba0e80113b90 EFLAGS: 00000283
>> [Mon Apr 29 14:17:57 2024] RAX: 0000000000001bf8 RBX: ffff924e4a81a3f8 RCX: 0000000000000000
>> [Mon Apr 29 14:17:57 2024] RDX: 0000000000000c0a RSI: ffff924e45347088 RDI: ffff924e45340000
>> [Mon Apr 29 14:17:57 2024] RBP: ffffba0e80113b90 R08: 0000000000000000 R09: ffff924e4a81a1d0
>> [Mon Apr 29 14:17:57 2024] R10: ffffba0e80113ae8 R11: 000000000000ffff R12: 0000000000000000
>> [Mon Apr 29 14:17:57 2024] R13: ffff924e4a819fe0 R14: ffff924e4d575c00 R15: ffff924e45347088
>> [Mon Apr 29 14:17:57 2024] FS: 0000000000000000(0000) GS:ffff926d1ee00000(0000) knlGS:0000000000000000
>> [Mon Apr 29 14:17:57 2024] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> [Mon Apr 29 14:17:57 2024] CR2: 00007fcc86d166e0 CR3: 000000082703c003 CR4: 0000000000770ef0
>> [Mon Apr 29 14:17:57 2024] PKRU: 55555554
>> [Mon Apr 29 14:17:57 2024] Call Trace:
>> [Mon Apr 29 14:17:57 2024] <IRQ>
>> [Mon Apr 29 14:17:57 2024] ? show_regs+0x6d/0x80
>> [Mon Apr 29 14:17:57 2024] ? dump_cpu_task+0x75/0x90
>> [Mon Apr 29 14:17:57 2024] ? rcu_dump_cpu_stacks+0xeb/0x180
>> [Mon Apr 29 14:17:57 2024] ? rcu_sched_clock_irq+0x572/0x1330
>> [Mon Apr 29 14:17:57 2024] ? raw_notifier_call_chain+0x1a/0x20
>> [Mon Apr 29 14:17:57 2024] ? timekeeping_update+0xf7/0x150
>> [Mon Apr 29 14:17:57 2024] ? account_system_index_time+0x9f/0xc0
>> [Mon Apr 29 14:17:57 2024] ? update_process_times+0x75/0xc0
>> [Mon Apr 29 14:17:57 2024] ? tick_nohz_handler+0xdc/0x140
>> [Mon Apr 29 14:17:57 2024] ? __pfx_tick_nohz_handler+0x10/0x10
>> [Mon Apr 29 14:17:57 2024] ? __hrtimer_run_queues+0x10e/0x290
>> [Mon Apr 29 14:17:57 2024] ? clockevents_program_event+0xae/0x130
>> [Mon Apr 29 14:17:57 2024] ? hrtimer_interrupt+0x108/0x240
>> [Mon Apr 29 14:17:57 2024] ? handle_edge_irq+0xde/0x240
>> [Mon Apr 29 14:17:57 2024] ? __sysvec_apic_timer_interrupt+0x5a/0x150
>> [Mon Apr 29 14:17:57 2024] ? sysvec_apic_timer_interrupt+0x7f/0x90
>> [Mon Apr 29 14:17:57 2024] </IRQ>
>> [Mon Apr 29 14:17:57 2024] <TASK>
>> [Mon Apr 29 14:17:57 2024] ? asm_sysvec_apic_timer_interrupt+0x1f/0x30
>> [Mon Apr 29 14:17:57 2024] ? ath11k_hal_srng_dst_peek+0x18/0x30 [ath11k]
>> [Mon Apr 29 14:17:57 2024] ath11k_dp_rx_process_mon_status+0xc45/0x1190 [ath11k]
>> [Mon Apr 29 14:17:57 2024] ? idr_alloc_u32+0x97/0xd0
>> [Mon Apr 29 14:17:57 2024] ath11k_dp_rx_process_mon_rings+0x32a/0x550 [ath11k]
>> [Mon Apr 29 14:17:57 2024] ath11k_dp_service_srng+0x289/0x5a0 [ath11k]
>> [Mon Apr 29 14:17:57 2024] ath11k_pcic_ext_grp_napi_poll+0x30/0xd0 [ath11k]
>> [Mon Apr 29 14:17:57 2024] __napi_poll+0x30/0x1f0
>> [Mon Apr 29 14:17:57 2024] net_rx_action+0x198/0x320
>> [Mon Apr 29 14:17:57 2024] __do_softirq+0xdd/0x319
>> [Mon Apr 29 14:17:57 2024] ? __pfx_smpboot_thread_fn+0x10/0x10
>> [Mon Apr 29 14:17:57 2024] run_ksoftirqd+0x31/0x50
>> [Mon Apr 29 14:17:57 2024] smpboot_thread_fn+0xe3/0x1e0
>> [Mon Apr 29 14:17:57 2024] kthread+0xf5/0x130
>> [Mon Apr 29 14:17:57 2024] ? __pfx_kthread+0x10/0x10
>> [Mon Apr 29 14:17:57 2024] ret_from_fork+0x3d/0x60
>> [Mon Apr 29 14:17:57 2024] ? __pfx_kthread+0x10/0x10
>> [Mon Apr 29 14:17:57 2024] ret_from_fork_asm+0x1a/0x30
>> [Mon Apr 29 14:17:57 2024] </TASK>
>>
>> Any ideas?
>
>
> Add 'spin_lock_bh(&srng->lock)' and 'spin_unlock_bh(&pmon->mon_lock)' in
> ath11k_dp_rx_mon_dest_process().
this advice looks confusing.
that function already has logic to lock/unlock &pmon->mon_lock so I don't see
where you'd add another 'spin_unlock_bh(&pmon->mon_lock)'
and you don't specify where to add 'spin_lock_bh(&srng->lock)', and why isn't
there an unlock for that?
perhaps propose an actual patch :)
/jeff
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ath11k
2024-04-30 2:03 ` ath11k Jeff Johnson
@ 2024-04-30 2:09 ` Kang Yang
2024-04-30 11:34 ` AW: ath11k Lindner, Frank
0 siblings, 1 reply; 13+ messages in thread
From: Kang Yang @ 2024-04-30 2:09 UTC (permalink / raw)
To: Jeff Johnson, Lindner, Frank, ath11k@lists.infradead.org
On 4/30/2024 10:03 AM, Jeff Johnson wrote:
> On 4/29/2024 6:54 PM, Kang Yang wrote:
>>
>>
>> On 4/29/2024 10:53 PM, Lindner, Frank wrote:
>>> Hi dev-guys,
>>>
>>> QCN9074 mPCIe-module with ath-next Kernel 6.9.0-rc1 (Ubuntu 24.04) causing Kernel Crash, when setting device to monitor mode. This does not happen instantly, it make take some time to fail.
>>>
>>> [Mon Apr 29 14:17:57 2024] rcu: INFO: rcu_preempt self-detected stall on CPU
>>> [Mon Apr 29 14:17:57 2024] rcu: 0-....: (15661 ticks this GP) idle=9394/1/0x4000000000000000 softirq=26961/26962 fqs=7499
>>> [Mon Apr 29 14:17:57 2024] rcu: (t=15000 jiffies g=78093 q=1070 ncpus=16)
>>> [Mon Apr 29 14:17:57 2024] CPU: 0 PID: 15 Comm: ksoftirqd/0 Tainted: G L 6.9.0-rc1-ath-next-j001 #11
>>> [Mon Apr 29 14:17:57 2024] Hardware name: To Be Filled By O.E.M. Z590M Pro4/Z590M Pro4, BIOS P2.20 06/06/2022
>>> [Mon Apr 29 14:17:57 2024] RIP: 0010:ath11k_hal_srng_dst_peek+0x18/0x30 [ath11k]
>>> [Mon Apr 29 14:17:57 2024] Code: 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 66 0f 1f 00 0f 1f 44 00 00 55 8b 46 60 45 31 c0 48 89 e5 3b 46 70 74 08 <48> 8b 56 10 4c 8d 04 82 4c 89 c0 5d c3 cc cc cc cc 0f 1f 80 00 00
>>> [Mon Apr 29 14:17:57 2024] RSP: 0018:ffffba0e80113b90 EFLAGS: 00000283
>>> [Mon Apr 29 14:17:57 2024] RAX: 0000000000001bf8 RBX: ffff924e4a81a3f8 RCX: 0000000000000000
>>> [Mon Apr 29 14:17:57 2024] RDX: 0000000000000c0a RSI: ffff924e45347088 RDI: ffff924e45340000
>>> [Mon Apr 29 14:17:57 2024] RBP: ffffba0e80113b90 R08: 0000000000000000 R09: ffff924e4a81a1d0
>>> [Mon Apr 29 14:17:57 2024] R10: ffffba0e80113ae8 R11: 000000000000ffff R12: 0000000000000000
>>> [Mon Apr 29 14:17:57 2024] R13: ffff924e4a819fe0 R14: ffff924e4d575c00 R15: ffff924e45347088
>>> [Mon Apr 29 14:17:57 2024] FS: 0000000000000000(0000) GS:ffff926d1ee00000(0000) knlGS:0000000000000000
>>> [Mon Apr 29 14:17:57 2024] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>>> [Mon Apr 29 14:17:57 2024] CR2: 00007fcc86d166e0 CR3: 000000082703c003 CR4: 0000000000770ef0
>>> [Mon Apr 29 14:17:57 2024] PKRU: 55555554
>>> [Mon Apr 29 14:17:57 2024] Call Trace:
>>> [Mon Apr 29 14:17:57 2024] <IRQ>
>>> [Mon Apr 29 14:17:57 2024] ? show_regs+0x6d/0x80
>>> [Mon Apr 29 14:17:57 2024] ? dump_cpu_task+0x75/0x90
>>> [Mon Apr 29 14:17:57 2024] ? rcu_dump_cpu_stacks+0xeb/0x180
>>> [Mon Apr 29 14:17:57 2024] ? rcu_sched_clock_irq+0x572/0x1330
>>> [Mon Apr 29 14:17:57 2024] ? raw_notifier_call_chain+0x1a/0x20
>>> [Mon Apr 29 14:17:57 2024] ? timekeeping_update+0xf7/0x150
>>> [Mon Apr 29 14:17:57 2024] ? account_system_index_time+0x9f/0xc0
>>> [Mon Apr 29 14:17:57 2024] ? update_process_times+0x75/0xc0
>>> [Mon Apr 29 14:17:57 2024] ? tick_nohz_handler+0xdc/0x140
>>> [Mon Apr 29 14:17:57 2024] ? __pfx_tick_nohz_handler+0x10/0x10
>>> [Mon Apr 29 14:17:57 2024] ? __hrtimer_run_queues+0x10e/0x290
>>> [Mon Apr 29 14:17:57 2024] ? clockevents_program_event+0xae/0x130
>>> [Mon Apr 29 14:17:57 2024] ? hrtimer_interrupt+0x108/0x240
>>> [Mon Apr 29 14:17:57 2024] ? handle_edge_irq+0xde/0x240
>>> [Mon Apr 29 14:17:57 2024] ? __sysvec_apic_timer_interrupt+0x5a/0x150
>>> [Mon Apr 29 14:17:57 2024] ? sysvec_apic_timer_interrupt+0x7f/0x90
>>> [Mon Apr 29 14:17:57 2024] </IRQ>
>>> [Mon Apr 29 14:17:57 2024] <TASK>
>>> [Mon Apr 29 14:17:57 2024] ? asm_sysvec_apic_timer_interrupt+0x1f/0x30
>>> [Mon Apr 29 14:17:57 2024] ? ath11k_hal_srng_dst_peek+0x18/0x30 [ath11k]
>>> [Mon Apr 29 14:17:57 2024] ath11k_dp_rx_process_mon_status+0xc45/0x1190 [ath11k]
>>> [Mon Apr 29 14:17:57 2024] ? idr_alloc_u32+0x97/0xd0
>>> [Mon Apr 29 14:17:57 2024] ath11k_dp_rx_process_mon_rings+0x32a/0x550 [ath11k]
>>> [Mon Apr 29 14:17:57 2024] ath11k_dp_service_srng+0x289/0x5a0 [ath11k]
>>> [Mon Apr 29 14:17:57 2024] ath11k_pcic_ext_grp_napi_poll+0x30/0xd0 [ath11k]
>>> [Mon Apr 29 14:17:57 2024] __napi_poll+0x30/0x1f0
>>> [Mon Apr 29 14:17:57 2024] net_rx_action+0x198/0x320
>>> [Mon Apr 29 14:17:57 2024] __do_softirq+0xdd/0x319
>>> [Mon Apr 29 14:17:57 2024] ? __pfx_smpboot_thread_fn+0x10/0x10
>>> [Mon Apr 29 14:17:57 2024] run_ksoftirqd+0x31/0x50
>>> [Mon Apr 29 14:17:57 2024] smpboot_thread_fn+0xe3/0x1e0
>>> [Mon Apr 29 14:17:57 2024] kthread+0xf5/0x130
>>> [Mon Apr 29 14:17:57 2024] ? __pfx_kthread+0x10/0x10
>>> [Mon Apr 29 14:17:57 2024] ret_from_fork+0x3d/0x60
>>> [Mon Apr 29 14:17:57 2024] ? __pfx_kthread+0x10/0x10
>>> [Mon Apr 29 14:17:57 2024] ret_from_fork_asm+0x1a/0x30
>>> [Mon Apr 29 14:17:57 2024] </TASK>
>>>
>>> Any ideas?
>>
>>
>> Add 'spin_lock_bh(&srng->lock)' and 'spin_unlock_bh(&pmon->mon_lock)' in
>> ath11k_dp_rx_mon_dest_process().
>
> this advice looks confusing.
> that function already has logic to lock/unlock &pmon->mon_lock so I don't see
> where you'd add another 'spin_unlock_bh(&pmon->mon_lock)'
Sorry...copy error, shuold be 'spin_lock_bh(&srng->lock);' and
'spin_unlock_bh(&srng->lock);'
This lock is needed by ath11k_hal_srng_dst_peek().
> and you don't specify where to add 'spin_lock_bh(&srng->lock)', and why isn't
> there an unlock for that?
>
> perhaps propose an actual patch :)
Will do that.
>
> /jeff
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* AW: ath11k
2024-04-30 2:09 ` ath11k Kang Yang
@ 2024-04-30 11:34 ` Lindner, Frank
2024-06-14 14:24 ` AW: ath11k monitor mode Lindner, Frank
0 siblings, 1 reply; 13+ messages in thread
From: Lindner, Frank @ 2024-04-30 11:34 UTC (permalink / raw)
To: Kang Yang, Jeff Johnson, ath11k@lists.infradead.org
Hi,
seems I need a patch for this?
I'm not really sure where to add this lock-statement.
Also, the unlock statemant seems allready to exist.
BR Frank
-----Ursprüngliche Nachricht-----
Von: Kang Yang <quic_kangyang@quicinc.com>
Gesendet: Dienstag, 30. April 2024 04:09
An: Jeff Johnson <quic_jjohnson@quicinc.com>; Lindner, Frank <Frank.Lindner@ghmt.de>; ath11k@lists.infradead.org
Betreff: Re: ath11k
On 4/30/2024 10:03 AM, Jeff Johnson wrote:
> On 4/29/2024 6:54 PM, Kang Yang wrote:
>>
>>
>> On 4/29/2024 10:53 PM, Lindner, Frank wrote:
>>> Hi dev-guys,
>>>
>>> QCN9074 mPCIe-module with ath-next Kernel 6.9.0-rc1 (Ubuntu 24.04) causing Kernel Crash, when setting device to monitor mode. This does not happen instantly, it make take some time to fail.
>>>
>>> [Mon Apr 29 14:17:57 2024] rcu: INFO: rcu_preempt self-detected stall on CPU
>>> [Mon Apr 29 14:17:57 2024] rcu: 0-....: (15661 ticks this GP) idle=9394/1/0x4000000000000000 softirq=26961/26962 fqs=7499
>>> [Mon Apr 29 14:17:57 2024] rcu: (t=15000 jiffies g=78093 q=1070 ncpus=16)
>>> [Mon Apr 29 14:17:57 2024] CPU: 0 PID: 15 Comm: ksoftirqd/0 Tainted: G L 6.9.0-rc1-ath-next-j001 #11
>>> [Mon Apr 29 14:17:57 2024] Hardware name: To Be Filled By O.E.M.
>>> Z590M Pro4/Z590M Pro4, BIOS P2.20 06/06/2022 [Mon Apr 29 14:17:57
>>> 2024] RIP: 0010:ath11k_hal_srng_dst_peek+0x18/0x30 [ath11k] [Mon Apr
>>> 29 14:17:57 2024] Code: 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90
>>> 90 90 90 66 0f 1f 00 0f 1f 44 00 00 55 8b 46 60 45 31 c0 48 89 e5 3b
>>> 46 70 74 08 <48> 8b 56 10 4c 8d 04 82 4c 89 c0 5d c3 cc cc cc cc 0f
>>> 1f 80 00 00 [Mon Apr 29 14:17:57 2024] RSP: 0018:ffffba0e80113b90
>>> EFLAGS: 00000283 [Mon Apr 29 14:17:57 2024] RAX: 0000000000001bf8
>>> RBX: ffff924e4a81a3f8 RCX: 0000000000000000 [Mon Apr 29 14:17:57
>>> 2024] RDX: 0000000000000c0a RSI: ffff924e45347088 RDI:
>>> ffff924e45340000 [Mon Apr 29 14:17:57 2024] RBP: ffffba0e80113b90
>>> R08: 0000000000000000 R09: ffff924e4a81a1d0 [Mon Apr 29 14:17:57
>>> 2024] R10: ffffba0e80113ae8 R11: 000000000000ffff R12:
>>> 0000000000000000 [Mon Apr 29 14:17:57 2024] R13: ffff924e4a819fe0 R14: ffff924e4d575c00 R15: ffff924e45347088 [Mon Apr 29 14:17:57 2024] FS: 0000000000000000(0000) GS:ffff926d1ee00000(0000) knlGS:0000000000000000 [Mon Apr 29 14:17:57 2024] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [Mon Apr 29 14:17:57 2024] CR2: 00007fcc86d166e0 CR3: 000000082703c003 CR4: 0000000000770ef0 [Mon Apr 29 14:17:57 2024] PKRU: 55555554 [Mon Apr 29 14:17:57 2024] Call Trace:
>>> [Mon Apr 29 14:17:57 2024] <IRQ>
>>> [Mon Apr 29 14:17:57 2024] ? show_regs+0x6d/0x80 [Mon Apr 29
>>> 14:17:57 2024] ? dump_cpu_task+0x75/0x90 [Mon Apr 29 14:17:57 2024]
>>> ? rcu_dump_cpu_stacks+0xeb/0x180 [Mon Apr 29 14:17:57 2024] ?
>>> rcu_sched_clock_irq+0x572/0x1330 [Mon Apr 29 14:17:57 2024] ?
>>> raw_notifier_call_chain+0x1a/0x20 [Mon Apr 29 14:17:57 2024] ?
>>> timekeeping_update+0xf7/0x150 [Mon Apr 29 14:17:57 2024] ?
>>> account_system_index_time+0x9f/0xc0
>>> [Mon Apr 29 14:17:57 2024] ? update_process_times+0x75/0xc0 [Mon
>>> Apr 29 14:17:57 2024] ? tick_nohz_handler+0xdc/0x140 [Mon Apr 29
>>> 14:17:57 2024] ? __pfx_tick_nohz_handler+0x10/0x10 [Mon Apr 29
>>> 14:17:57 2024] ? __hrtimer_run_queues+0x10e/0x290 [Mon Apr 29
>>> 14:17:57 2024] ? clockevents_program_event+0xae/0x130
>>> [Mon Apr 29 14:17:57 2024] ? hrtimer_interrupt+0x108/0x240 [Mon Apr
>>> 29 14:17:57 2024] ? handle_edge_irq+0xde/0x240 [Mon Apr 29 14:17:57
>>> 2024] ? __sysvec_apic_timer_interrupt+0x5a/0x150
>>> [Mon Apr 29 14:17:57 2024] ? sysvec_apic_timer_interrupt+0x7f/0x90
>>> [Mon Apr 29 14:17:57 2024] </IRQ>
>>> [Mon Apr 29 14:17:57 2024] <TASK>
>>> [Mon Apr 29 14:17:57 2024] ?
>>> asm_sysvec_apic_timer_interrupt+0x1f/0x30
>>> [Mon Apr 29 14:17:57 2024] ? ath11k_hal_srng_dst_peek+0x18/0x30
>>> [ath11k] [Mon Apr 29 14:17:57 2024]
>>> ath11k_dp_rx_process_mon_status+0xc45/0x1190 [ath11k] [Mon Apr 29
>>> 14:17:57 2024] ? idr_alloc_u32+0x97/0xd0 [Mon Apr 29 14:17:57 2024]
>>> ath11k_dp_rx_process_mon_rings+0x32a/0x550 [ath11k] [Mon Apr 29
>>> 14:17:57 2024] ath11k_dp_service_srng+0x289/0x5a0 [ath11k] [Mon Apr
>>> 29 14:17:57 2024] ath11k_pcic_ext_grp_napi_poll+0x30/0xd0 [ath11k]
>>> [Mon Apr 29 14:17:57 2024] __napi_poll+0x30/0x1f0 [Mon Apr 29
>>> 14:17:57 2024] net_rx_action+0x198/0x320 [Mon Apr 29 14:17:57 2024]
>>> __do_softirq+0xdd/0x319 [Mon Apr 29 14:17:57 2024] ?
>>> __pfx_smpboot_thread_fn+0x10/0x10 [Mon Apr 29 14:17:57 2024]
>>> run_ksoftirqd+0x31/0x50 [Mon Apr 29 14:17:57 2024]
>>> smpboot_thread_fn+0xe3/0x1e0 [Mon Apr 29 14:17:57 2024]
>>> kthread+0xf5/0x130 [Mon Apr 29 14:17:57 2024] ?
>>> __pfx_kthread+0x10/0x10 [Mon Apr 29 14:17:57 2024]
>>> ret_from_fork+0x3d/0x60 [Mon Apr 29 14:17:57 2024] ?
>>> __pfx_kthread+0x10/0x10 [Mon Apr 29 14:17:57 2024]
>>> ret_from_fork_asm+0x1a/0x30 [Mon Apr 29 14:17:57 2024] </TASK>
>>>
>>> Any ideas?
>>
>>
>> Add 'spin_lock_bh(&srng->lock)' and 'spin_unlock_bh(&pmon->mon_lock)'
>> in ath11k_dp_rx_mon_dest_process().
>
> this advice looks confusing.
> that function already has logic to lock/unlock &pmon->mon_lock so I
> don't see where you'd add another 'spin_unlock_bh(&pmon->mon_lock)'
Sorry...copy error, shuold be 'spin_lock_bh(&srng->lock);' and 'spin_unlock_bh(&srng->lock);'
This lock is needed by ath11k_hal_srng_dst_peek().
> and you don't specify where to add 'spin_lock_bh(&srng->lock)', and why isn't
> there an unlock for that?
>
> perhaps propose an actual patch :)
Will do that.
>
> /jeff
>
Vorstand: Dirk Wilhelm (V), Wulf Jannsen
Aufsichtsrat: Ron Scheepers (V)
Handelsregister: HRB Saarbrücken Nr. 13201
Ust.ID Nr.: DE 153807627
^ permalink raw reply [flat|nested] 13+ messages in thread
* AW: ath11k monitor mode
2024-04-30 11:34 ` AW: ath11k Lindner, Frank
@ 2024-06-14 14:24 ` Lindner, Frank
2024-06-17 2:18 ` Kang Yang
0 siblings, 1 reply; 13+ messages in thread
From: Lindner, Frank @ 2024-06-14 14:24 UTC (permalink / raw)
To: Kang Yang, Jeff Johnson, ath11k@lists.infradead.org
Hi,
I didn't received any feedback on this?
How can I get this module working?
BR Frank
-----Ursprüngliche Nachricht-----
Von: ath11k <ath11k-bounces@lists.infradead.org> Im Auftrag von Lindner, Frank
Gesendet: Dienstag, 30. April 2024 13:35
An: Kang Yang <quic_kangyang@quicinc.com>; Jeff Johnson <quic_jjohnson@quicinc.com>; ath11k@lists.infradead.org
Betreff: AW: ath11k
Hi,
seems I need a patch for this?
I'm not really sure where to add this lock-statement.
Also, the unlock statemant seems allready to exist.
BR Frank
-----Ursprüngliche Nachricht-----
Von: Kang Yang <quic_kangyang@quicinc.com>
Gesendet: Dienstag, 30. April 2024 04:09
An: Jeff Johnson <quic_jjohnson@quicinc.com>; Lindner, Frank <Frank.Lindner@ghmt.de>; ath11k@lists.infradead.org
Betreff: Re: ath11k
On 4/30/2024 10:03 AM, Jeff Johnson wrote:
> On 4/29/2024 6:54 PM, Kang Yang wrote:
>>
>>
>> On 4/29/2024 10:53 PM, Lindner, Frank wrote:
>>> Hi dev-guys,
>>>
>>> QCN9074 mPCIe-module with ath-next Kernel 6.9.0-rc1 (Ubuntu 24.04) causing Kernel Crash, when setting device to monitor mode. This does not happen instantly, it make take some time to fail.
>>>
>>> [Mon Apr 29 14:17:57 2024] rcu: INFO: rcu_preempt self-detected stall on CPU
>>> [Mon Apr 29 14:17:57 2024] rcu: 0-....: (15661 ticks this GP) idle=9394/1/0x4000000000000000 softirq=26961/26962 fqs=7499
>>> [Mon Apr 29 14:17:57 2024] rcu: (t=15000 jiffies g=78093 q=1070 ncpus=16)
>>> [Mon Apr 29 14:17:57 2024] CPU: 0 PID: 15 Comm: ksoftirqd/0 Tainted: G L 6.9.0-rc1-ath-next-j001 #11
>>> [Mon Apr 29 14:17:57 2024] Hardware name: To Be Filled By O.E.M.
>>> Z590M Pro4/Z590M Pro4, BIOS P2.20 06/06/2022 [Mon Apr 29 14:17:57
>>> 2024] RIP: 0010:ath11k_hal_srng_dst_peek+0x18/0x30 [ath11k] [Mon Apr
>>> 29 14:17:57 2024] Code: 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90
>>> 90 90 90 66 0f 1f 00 0f 1f 44 00 00 55 8b 46 60 45 31 c0 48 89 e5 3b
>>> 46 70 74 08 <48> 8b 56 10 4c 8d 04 82 4c 89 c0 5d c3 cc cc cc cc 0f
>>> 1f 80 00 00 [Mon Apr 29 14:17:57 2024] RSP: 0018:ffffba0e80113b90
>>> EFLAGS: 00000283 [Mon Apr 29 14:17:57 2024] RAX: 0000000000001bf8
>>> RBX: ffff924e4a81a3f8 RCX: 0000000000000000 [Mon Apr 29 14:17:57
>>> 2024] RDX: 0000000000000c0a RSI: ffff924e45347088 RDI:
>>> ffff924e45340000 [Mon Apr 29 14:17:57 2024] RBP: ffffba0e80113b90
>>> R08: 0000000000000000 R09: ffff924e4a81a1d0 [Mon Apr 29 14:17:57
>>> 2024] R10: ffffba0e80113ae8 R11: 000000000000ffff R12:
>>> 0000000000000000 [Mon Apr 29 14:17:57 2024] R13: ffff924e4a819fe0 R14: ffff924e4d575c00 R15: ffff924e45347088 [Mon Apr 29 14:17:57 2024] FS: 0000000000000000(0000) GS:ffff926d1ee00000(0000) knlGS:0000000000000000 [Mon Apr 29 14:17:57 2024] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [Mon Apr 29 14:17:57 2024] CR2: 00007fcc86d166e0 CR3: 000000082703c003 CR4: 0000000000770ef0 [Mon Apr 29 14:17:57 2024] PKRU: 55555554 [Mon Apr 29 14:17:57 2024] Call Trace:
>>> [Mon Apr 29 14:17:57 2024] <IRQ>
>>> [Mon Apr 29 14:17:57 2024] ? show_regs+0x6d/0x80 [Mon Apr 29
>>> 14:17:57 2024] ? dump_cpu_task+0x75/0x90 [Mon Apr 29 14:17:57 2024]
>>> ? rcu_dump_cpu_stacks+0xeb/0x180 [Mon Apr 29 14:17:57 2024] ?
>>> rcu_sched_clock_irq+0x572/0x1330 [Mon Apr 29 14:17:57 2024] ?
>>> raw_notifier_call_chain+0x1a/0x20 [Mon Apr 29 14:17:57 2024] ?
>>> timekeeping_update+0xf7/0x150 [Mon Apr 29 14:17:57 2024] ?
>>> account_system_index_time+0x9f/0xc0
>>> [Mon Apr 29 14:17:57 2024] ? update_process_times+0x75/0xc0 [Mon
>>> Apr 29 14:17:57 2024] ? tick_nohz_handler+0xdc/0x140 [Mon Apr 29
>>> 14:17:57 2024] ? __pfx_tick_nohz_handler+0x10/0x10 [Mon Apr 29
>>> 14:17:57 2024] ? __hrtimer_run_queues+0x10e/0x290 [Mon Apr 29
>>> 14:17:57 2024] ? clockevents_program_event+0xae/0x130
>>> [Mon Apr 29 14:17:57 2024] ? hrtimer_interrupt+0x108/0x240 [Mon Apr
>>> 29 14:17:57 2024] ? handle_edge_irq+0xde/0x240 [Mon Apr 29 14:17:57
>>> 2024] ? __sysvec_apic_timer_interrupt+0x5a/0x150
>>> [Mon Apr 29 14:17:57 2024] ? sysvec_apic_timer_interrupt+0x7f/0x90
>>> [Mon Apr 29 14:17:57 2024] </IRQ>
>>> [Mon Apr 29 14:17:57 2024] <TASK>
>>> [Mon Apr 29 14:17:57 2024] ?
>>> asm_sysvec_apic_timer_interrupt+0x1f/0x30
>>> [Mon Apr 29 14:17:57 2024] ? ath11k_hal_srng_dst_peek+0x18/0x30
>>> [ath11k] [Mon Apr 29 14:17:57 2024]
>>> ath11k_dp_rx_process_mon_status+0xc45/0x1190 [ath11k] [Mon Apr 29
>>> 14:17:57 2024] ? idr_alloc_u32+0x97/0xd0 [Mon Apr 29 14:17:57 2024]
>>> ath11k_dp_rx_process_mon_rings+0x32a/0x550 [ath11k] [Mon Apr 29
>>> 14:17:57 2024] ath11k_dp_service_srng+0x289/0x5a0 [ath11k] [Mon Apr
>>> 29 14:17:57 2024] ath11k_pcic_ext_grp_napi_poll+0x30/0xd0 [ath11k]
>>> [Mon Apr 29 14:17:57 2024] __napi_poll+0x30/0x1f0 [Mon Apr 29
>>> 14:17:57 2024] net_rx_action+0x198/0x320 [Mon Apr 29 14:17:57 2024]
>>> __do_softirq+0xdd/0x319 [Mon Apr 29 14:17:57 2024] ?
>>> __pfx_smpboot_thread_fn+0x10/0x10 [Mon Apr 29 14:17:57 2024]
>>> run_ksoftirqd+0x31/0x50 [Mon Apr 29 14:17:57 2024]
>>> smpboot_thread_fn+0xe3/0x1e0 [Mon Apr 29 14:17:57 2024]
>>> kthread+0xf5/0x130 [Mon Apr 29 14:17:57 2024] ?
>>> __pfx_kthread+0x10/0x10 [Mon Apr 29 14:17:57 2024]
>>> ret_from_fork+0x3d/0x60 [Mon Apr 29 14:17:57 2024] ?
>>> __pfx_kthread+0x10/0x10 [Mon Apr 29 14:17:57 2024]
>>> ret_from_fork_asm+0x1a/0x30 [Mon Apr 29 14:17:57 2024] </TASK>
>>>
>>> Any ideas?
>>
>>
>> Add 'spin_lock_bh(&srng->lock)' and 'spin_unlock_bh(&pmon->mon_lock)'
>> in ath11k_dp_rx_mon_dest_process().
>
> this advice looks confusing.
> that function already has logic to lock/unlock &pmon->mon_lock so I
> don't see where you'd add another 'spin_unlock_bh(&pmon->mon_lock)'
Sorry...copy error, shuold be 'spin_lock_bh(&srng->lock);' and 'spin_unlock_bh(&srng->lock);'
This lock is needed by ath11k_hal_srng_dst_peek().
> and you don't specify where to add 'spin_lock_bh(&srng->lock)', and
> why isn't there an unlock for that?
>
> perhaps propose an actual patch :)
Will do that.
>
> /jeff
>
Vorstand: Dirk Wilhelm (V), Wulf Jannsen
Aufsichtsrat: Ron Scheepers (V)
Handelsregister: HRB Saarbrücken Nr. 13201 Ust.ID Nr.: DE 153807627
Vorstand: Dirk Wilhelm (V), Wulf Jannsen
Aufsichtsrat: Ron Scheepers (V)
Handelsregister: HRB Saarbrücken Nr. 13201
Ust.ID Nr.: DE 153807627
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: AW: ath11k monitor mode
2024-06-14 14:24 ` AW: ath11k monitor mode Lindner, Frank
@ 2024-06-17 2:18 ` Kang Yang
2024-07-12 13:54 ` Giedrius
0 siblings, 1 reply; 13+ messages in thread
From: Kang Yang @ 2024-06-17 2:18 UTC (permalink / raw)
To: Lindner, Frank, Jeff Johnson, ath11k@lists.infradead.org
On 6/14/2024 10:24 PM, Lindner, Frank wrote:
> Hi,
> I didn't received any feedback on this?
> How can I get this module working?
>
>
Hi, there is another issue on this monitor mode, so we spent some time
on it. At present, it seems that two patches are needed to fully fix it.
One is used to fix this srng warning, the other is used to fix crash.
I will send them to review group after verification by the testing team.
> BR Frank
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: AW: ath11k monitor mode
2024-06-17 2:18 ` Kang Yang
@ 2024-07-12 13:54 ` Giedrius
2024-09-13 6:59 ` Lindner, Frank
0 siblings, 1 reply; 13+ messages in thread
From: Giedrius @ 2024-07-12 13:54 UTC (permalink / raw)
To: ath11k
On Mon, Jun 17, 2024 at 10:18:14AM +0800, Kang Yang wrote:
> Hi, there is another issue on this monitor mode, so we spent some time on
> it. At present, it seems that two patches are needed to fully fix it.
>
> I will send them to review group after verification by the testing team.
Are these patches available anywhere?
I would be interested in testing them out, even if unverified.
Currently, any significant WiFi traffic is causing RCU stall on monitor interface.
Thank you,
Giedrius
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE:: ath11k monitor mode
2024-07-12 13:54 ` Giedrius
@ 2024-09-13 6:59 ` Lindner, Frank
2024-09-13 10:11 ` : " Kang Yang
0 siblings, 1 reply; 13+ messages in thread
From: Lindner, Frank @ 2024-09-13 6:59 UTC (permalink / raw)
To: ath11k@lists.infradead.org
Hi everyone,
is there any update on the topic ath11k monitor mode?
We prefer to use QCA chipsets, but currently its not possible.
TIA, BR
Frank
-----Ursprüngliche Nachricht-----
Von: ath11k <ath11k-bounces@lists.infradead.org> Im Auftrag von Giedrius
Gesendet: Freitag, 12. Juli 2024 15:55
An: ath11k@lists.infradead.org
Betreff: Re: AW: ath11k monitor mode
On Mon, Jun 17, 2024 at 10:18:14AM +0800, Kang Yang wrote:
> Hi, there is another issue on this monitor mode, so we spent some time
> on it. At present, it seems that two patches are needed to fully fix it.
>
> I will send them to review group after verification by the testing team.
Are these patches available anywhere?
I would be interested in testing them out, even if unverified.
Currently, any significant WiFi traffic is causing RCU stall on monitor interface.
Thank you,
Giedrius
Vorstand: Dirk Wilhelm (V), Wulf Jannsen
Aufsichtsrat: Ron Scheepers (V)
Handelsregister: HRB Saarbrücken Nr. 13201
Ust.ID Nr.: DE 153807627
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: : ath11k monitor mode
2024-09-13 6:59 ` Lindner, Frank
@ 2024-09-13 10:11 ` Kang Yang
2024-09-13 13:13 ` Remi Pommarel
0 siblings, 1 reply; 13+ messages in thread
From: Kang Yang @ 2024-09-13 10:11 UTC (permalink / raw)
To: Lindner, Frank, ath11k@lists.infradead.org
On 9/13/2024 2:59 PM, Lindner, Frank wrote:
> Hi everyone,
>
> is there any update on the topic ath11k monitor mode?
> We prefer to use QCA chipsets, but currently its not possible.
>
For QCN9074, full monitor mode should work with below patch-set.
https://patchwork.kernel.org/project/linux-wireless/cover/20240913100708.756-1-quic_kangyang@quicinc.com/
But for WCN6855/QCA6390, monitor mode still needs some patches.
> TIA, BR
> Frank
>
> -----Ursprüngliche Nachricht-----
> Von: ath11k <ath11k-bounces@lists.infradead.org> Im Auftrag von Giedrius
> Gesendet: Freitag, 12. Juli 2024 15:55
> An: ath11k@lists.infradead.org
> Betreff: Re: AW: ath11k monitor mode
>
> On Mon, Jun 17, 2024 at 10:18:14AM +0800, Kang Yang wrote:
>> Hi, there is another issue on this monitor mode, so we spent some time
>> on it. At present, it seems that two patches are needed to fully fix it.
>>
>> I will send them to review group after verification by the testing team.
>
> Are these patches available anywhere?
>
> I would be interested in testing them out, even if unverified.
> Currently, any significant WiFi traffic is causing RCU stall on monitor interface.
>
> Thank you,
> Giedrius
>
>
>
> Vorstand: Dirk Wilhelm (V), Wulf Jannsen
> Aufsichtsrat: Ron Scheepers (V)
> Handelsregister: HRB Saarbrücken Nr. 13201
> Ust.ID Nr.: DE 153807627
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: : ath11k monitor mode
2024-09-13 10:11 ` : " Kang Yang
@ 2024-09-13 13:13 ` Remi Pommarel
2024-09-18 2:11 ` Kang Yang
0 siblings, 1 reply; 13+ messages in thread
From: Remi Pommarel @ 2024-09-13 13:13 UTC (permalink / raw)
To: Kang Yang; +Cc: Lindner, Frank, ath11k@lists.infradead.org
On Fri, Sep 13, 2024 at 06:11:33PM +0800, Kang Yang wrote:
>
>
> On 9/13/2024 2:59 PM, Lindner, Frank wrote:
> > Hi everyone,
> >
> > is there any update on the topic ath11k monitor mode?
> > We prefer to use QCA chipsets, but currently its not possible.
> >
>
> For QCN9074, full monitor mode should work with below patch-set.
> https://patchwork.kernel.org/project/linux-wireless/cover/20240913100708.756-1-quic_kangyang@quicinc.com/
>
Does full monitor works without [0]. Last time I checked it didn't on
QCN9074 with WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1.
Thanks
[0]: https://lore.kernel.org/ath11k/505773d9e20d14c22ce1a56ac640ba442b29ae4a.1700731974.git.repk@triplefau.lt/
--
Remi
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: : ath11k monitor mode
2024-09-13 13:13 ` Remi Pommarel
@ 2024-09-18 2:11 ` Kang Yang
2024-09-23 17:25 ` Praneesh P
0 siblings, 1 reply; 13+ messages in thread
From: Kang Yang @ 2024-09-18 2:11 UTC (permalink / raw)
To: Remi Pommarel, Praneesh P; +Cc: Lindner, Frank, ath11k@lists.infradead.org
On 9/13/2024 9:13 PM, Remi Pommarel wrote:
> On Fri, Sep 13, 2024 at 06:11:33PM +0800, Kang Yang wrote:
>>
>>
>> On 9/13/2024 2:59 PM, Lindner, Frank wrote:
>>> Hi everyone,
>>>
>>> is there any update on the topic ath11k monitor mode?
>>> We prefer to use QCA chipsets, but currently its not possible.
>>>
>>
>> For QCN9074, full monitor mode should work with below patch-set.
>> https://patchwork.kernel.org/project/linux-wireless/cover/20240913100708.756-1-quic_kangyang@quicinc.com/
>>
>
> Does full monitor works without [0]. Last time I checked it didn't on
> QCN9074 with WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1.
Not sure, Praneesh, can you reply this?
>
> Thanks
>
> [0]: https://lore.kernel.org/ath11k/505773d9e20d14c22ce1a56ac640ba442b29ae4a.1700731974.git.repk@triplefau.lt/
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: : ath11k monitor mode
2024-09-18 2:11 ` Kang Yang
@ 2024-09-23 17:25 ` Praneesh P
0 siblings, 0 replies; 13+ messages in thread
From: Praneesh P @ 2024-09-23 17:25 UTC (permalink / raw)
To: Kang Yang, Remi Pommarel; +Cc: Lindner, Frank, ath11k@lists.infradead.org
On 9/18/2024 7:41 AM, Kang Yang wrote:
>
>
> On 9/13/2024 9:13 PM, Remi Pommarel wrote:
>> On Fri, Sep 13, 2024 at 06:11:33PM +0800, Kang Yang wrote:
>>>
>>>
>>> On 9/13/2024 2:59 PM, Lindner, Frank wrote:
>>>> Hi everyone,
>>>>
>>>> is there any update on the topic ath11k monitor mode?
>>>> We prefer to use QCA chipsets, but currently its not possible.
>>>>
>>>
>>> For QCN9074, full monitor mode should work with below patch-set.
>>> https://patchwork.kernel.org/project/linux-wireless/cover/20240913100708.756-1-quic_kangyang@quicinc.com/
>>>
>>
>> Does full monitor works without [0]. Last time I checked it didn't on
>> QCN9074 with WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1.
>
> Not sure, Praneesh, can you reply this?
Hi Remi,
I have reviewed [0], and this change is necessary to prevent chipsets
that support full monitor from accessing the destination ring meant for
classical monitor.
One minor suggestion for this patch: pmon->mon_ppdu_status should be set
to DP_PPDU_STATUS_DONE before the if check. This ensures that the
ppdu_status transitions correctly from DP_PPDU_STATUS_START to
DP_PPDU_STATUS_DONE for full monitor supported chipsets.
>
>>
>> Thanks
>>
>> [0]:
>> https://lore.kernel.org/ath11k/505773d9e20d14c22ce1a56ac640ba442b29ae4a.1700731974.git.repk@triplefau.lt/
>>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2024-09-23 17:25 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 14:53 ath11k Lindner, Frank
2024-04-30 1:54 ` ath11k Kang Yang
2024-04-30 2:03 ` ath11k Jeff Johnson
2024-04-30 2:09 ` ath11k Kang Yang
2024-04-30 11:34 ` AW: ath11k Lindner, Frank
2024-06-14 14:24 ` AW: ath11k monitor mode Lindner, Frank
2024-06-17 2:18 ` Kang Yang
2024-07-12 13:54 ` Giedrius
2024-09-13 6:59 ` Lindner, Frank
2024-09-13 10:11 ` : " Kang Yang
2024-09-13 13:13 ` Remi Pommarel
2024-09-18 2:11 ` Kang Yang
2024-09-23 17:25 ` Praneesh P
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox