* Re: [PATCH v2 12/22] wifi: ath11k: Use iommu_paging_domain_alloc()
[not found] ` <20240604015134.164206-13-baolu.lu@linux.intel.com>
@ 2024-06-04 8:19 ` Kalle Valo
0 siblings, 0 replies; only message in thread
From: Kalle Valo @ 2024-06-04 8:19 UTC (permalink / raw)
To: Lu Baolu
Cc: Joerg Roedel, Will Deacon, Robin Murphy, Jason Gunthorpe,
Kevin Tian, Yi Liu, David Airlie, Daniel Vetter, Bjorn Andersson,
Mathieu Poirier, Alex Williamson, mst, Jason Wang, Thierry Reding,
Jonathan Hunter, Mikko Perttunen, iommu, dri-devel, linux-kernel,
Jeff Johnson, ath11k
Lu Baolu <baolu.lu@linux.intel.com> writes:
> An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is
> attached to ab_ahb->fw.dev in the same function.
>
> Use iommu_paging_domain_alloc() to make it explicit.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/net/wireless/ath/ath11k/ahb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
> index ca0f17ddebba..a469647719f9 100644
> --- a/drivers/net/wireless/ath/ath11k/ahb.c
> +++ b/drivers/net/wireless/ath/ath11k/ahb.c
> @@ -1001,10 +1001,10 @@ static int ath11k_ahb_fw_resources_init(struct ath11k_base *ab)
>
> ab_ahb->fw.dev = &pdev->dev;
>
> - iommu_dom = iommu_domain_alloc(&platform_bus_type);
> - if (!iommu_dom) {
> + iommu_dom = iommu_paging_domain_alloc(ab_ahb->fw.dev);
> + if (IS_ERR(iommu_dom)) {
> ath11k_err(ab, "failed to allocate iommu domain\n");
> - ret = -ENOMEM;
> + ret = PTR_ERR(iommu_dom);
> goto err_unregister;
> }
Adding Jeff and ath11k list so that they can review this as well.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] only message in thread