Re: [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings()

Re: [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings()

[Jeff Johnson]

On 7/26/2023 2:21 AM, Dmitry Antipov wrote:
> In 'ath11k_mac_validate_vht_he_fixed_rate_settings()', 'ar->ab->peers'
> list is not altered so 'list_for_each_entry()' should be safe.
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
>   drivers/net/wireless/ath/ath11k/mac.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> index 8c77ade49437..2aadf2c387b6 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -8255,7 +8255,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
>   					       const struct cfg80211_bitrate_mask *mask)
>   {
>   	bool he_fixed_rate = false, vht_fixed_rate = false;
> -	struct ath11k_peer *peer, *tmp;
> +	struct ath11k_peer *peer;
>   	const u16 *vht_mcs_mask, *he_mcs_mask;
>   	struct ieee80211_link_sta *deflink;
>   	u8 vht_nss, he_nss;
> @@ -8278,7 +8278,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
>   
>   	rcu_read_lock();
>   	spin_lock_bh(&ar->ab->base_lock);
> -	list_for_each_entry_safe(peer, tmp, &ar->ab->peers, list) {
> +	list_for_each_entry(peer, &ar->ab->peers, list) {
>   		if (peer->sta) {
>   			deflink = &peer->sta->deflink;
>   

In the future please make sure driver-specific mailing lists are 
included in your patches when they exist in the MAINTAINERS file. Adding 
ath11k@lists.infradead.org

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

Re: [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings()

[Kalle Valo]

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 7/26/2023 2:21 AM, Dmitry Antipov wrote:
>
>> In 'ath11k_mac_validate_vht_he_fixed_rate_settings()', 'ar->ab->peers'
>> list is not altered so 'list_for_each_entry()' should be safe.
>> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
>
> In the future please make sure driver-specific mailing lists are
> included in your patches when they exist in the MAINTAINERS file.
> Adding ath11k@lists.infradead.org

And this is actually v2, there was already v1 sent earlier this month:

https://patchwork.kernel.org/project/linux-wireless/patch/20230704174753.76968-1-dmantipov@yandex.ru/

Dmitry, PLEASE read our documentation from the wiki below. You need to
always mark the patch as v2 and provide a changelog what changed since
v1.

And especially slow down with the rate of patches you are submitting and
instead use that time to learn the process first.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k