ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
Cc: "ath11k@lists.infradead.org" <ath11k@lists.infradead.org>
Subject: Re: Remaining sparse warnings
Date: Fri, 31 May 2019 17:33:19 +0300	[thread overview]
Message-ID: <87v9xqzob4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <97b7a885-d357-c1e0-330e-44d00566f1e5@qti.qualcomm.com> (Vasanthakumar Thiagarajan's message of "Fri, 31 May 2019 03:51:43 +0000")

Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> writes:

> On Wednesday 29 May 2019 10:11 PM, Kalle Valo wrote:
>> 
>> there are still few sparse warnings, anyone willing to fix the last
>> ones? Though I'm not sure how to fix "dubious: x & !y" warnings, any
>> ideas?
>> 
>> drivers/net/wireless/ath/ath11k/hal_rx.c:118:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:120:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:122:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:124:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:126:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:128:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:130:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:132:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:134:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:136:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:138:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:140:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:142:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:144:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:146:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:148:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:150:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:152:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:154:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:156:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:158:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:160:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:166:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:170:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:172:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:176:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:178:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:180:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:182:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:184:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:186:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:188:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:190:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:192:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:212:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:216:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:218:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/dp_tx.c:665:23: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/dp_tx.c:667:23: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/dp_tx.c:670:23: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/dp_tx.c:830:23: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/dp_tx.c:832:23: warning: dubious: x & !y
>
> To me, this seems like a false warning, I do not see any issue with
> the way values are passed
> to FIELD_PREP() macro.

Me neither. I think I'll filter out all "dubious:" warnings in my
ath11k-check script for now. Let's just hope we don't miss any real
warnings because of this.

>> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: warning: incorrect
>> type in assignment (different base types)
>> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: expected unsigned
>> int [usertype] pkt_type_en_flags0
>> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33:    got restricted __le32 [usertype]
>> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: warning: incorrect
>> type in assignment (different base types)
>> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: expected unsigned
>> int [usertype] pkt_type_en_flags1
>> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33:    got restricted __le32 [usertype]
>> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: warning: incorrect
>> type in assignment (different base types)
>> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: expected unsigned
>> int [usertype] pkt_type_en_flags2
>> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33:    got restricted __le32 [usertype]
>> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: warning: incorrect
>> type in assignment (different base types)
>> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: expected unsigned
>> int [usertype] pkt_type_en_flags3
>> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33:    got restricted __le32 [usertype]
>> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: warning: incorrect
>> type in assignment (different base types)
>> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: expected unsigned
>> int [usertype] rx_filter_tlv
>> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28:    got restricted __le32 [usertype]
>> 
>
> Ill take a loot at these warnings.

Thanks!

-- 
Kalle Valo

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

      reply	other threads:[~2019-05-31 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 16:41 Remaining sparse warnings Kalle Valo
2019-05-31  3:51 ` Vasanthakumar Thiagarajan
2019-05-31 14:33   ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9xqzob4.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=vthiagar@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox