* [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs
@ 2024-05-20 3:07 Carl Huang
2024-05-20 4:57 ` Kalle Valo
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Carl Huang @ 2024-05-20 3:07 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless, quic_cjhuang
WCN6750 firmware crashes because of num_vdevs changed from 4 to 17
in ath11k_init_wmi_config_qca6390() as the ab->hw_params.num_vdevs
is 17. This is caused by commit f019f4dff2e4("wifi: ath11k: support
2 station interfaces") which assigns ab->hw_params.num_vdevs directly
to config->num_vdevs in ath11k_init_wmi_config_qca6390(), therefore
WCN6750 firmware crashes as it can't support such a big num_vdevs.
Fix it by assign 3 to num_vdevs in hw_params for WCN6750 as 3 is
sufficient too.
Fixes: f019f4dff2e4 ("wifi: ath11k: support 2 station interfaces")
Reported-by: Luca Weiss <luca.weiss@fairphone.com>
Closes: https://lore.kernel.org/r/D15TIIDIIESY.D1EKKJLZINMA@fairphone.com/
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-01371-QCAMSLSWPLZ-1
Signed-off-by: Carl Huang <quic_cjhuang@quicinc.com>
---
drivers/net/wireless/ath/ath11k/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 3cc817a3b4a4..b82e8fb28541 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -604,7 +604,7 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
.coldboot_cal_ftm = true,
.cbcal_restart_fw = false,
.fw_mem_mode = 0,
- .num_vdevs = 16 + 1,
+ .num_vdevs = 3,
.num_peers = 512,
.supports_suspend = false,
.hal_desc_sz = sizeof(struct hal_rx_desc_qcn9074),
base-commit: 1025c616ee13372f3803b158abb1d87ef368ae3d
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs
2024-05-20 3:07 [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs Carl Huang
@ 2024-05-20 4:57 ` Kalle Valo
2024-05-20 21:13 ` Jeff Johnson
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2024-05-20 4:57 UTC (permalink / raw)
To: Carl Huang; +Cc: ath11k, linux-wireless
Carl Huang <quic_cjhuang@quicinc.com> writes:
> WCN6750 firmware crashes because of num_vdevs changed from 4 to 17
> in ath11k_init_wmi_config_qca6390() as the ab->hw_params.num_vdevs
> is 17. This is caused by commit f019f4dff2e4("wifi: ath11k: support
> 2 station interfaces") which assigns ab->hw_params.num_vdevs directly
> to config->num_vdevs in ath11k_init_wmi_config_qca6390(), therefore
> WCN6750 firmware crashes as it can't support such a big num_vdevs.
>
> Fix it by assign 3 to num_vdevs in hw_params for WCN6750 as 3 is
> sufficient too.
>
> Fixes: f019f4dff2e4 ("wifi: ath11k: support 2 station interfaces")
> Reported-by: Luca Weiss <luca.weiss@fairphone.com>
> Closes: https://lore.kernel.org/r/D15TIIDIIESY.D1EKKJLZINMA@fairphone.com/
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-01371-QCAMSLSWPLZ-1
>
> Signed-off-by: Carl Huang <quic_cjhuang@quicinc.com>
Luca, can you test this as well just to be sure? The patch is here:
https://patchwork.kernel.org/project/linux-wireless/patch/20240520030757.2209395-1-quic_cjhuang@quicinc.com/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs
2024-05-20 3:07 [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs Carl Huang
2024-05-20 4:57 ` Kalle Valo
@ 2024-05-20 21:13 ` Jeff Johnson
2024-05-21 8:04 ` Kalle Valo
2024-05-23 12:44 ` Kalle Valo
3 siblings, 0 replies; 6+ messages in thread
From: Jeff Johnson @ 2024-05-20 21:13 UTC (permalink / raw)
To: Carl Huang, ath11k; +Cc: linux-wireless
On 5/19/2024 8:07 PM, Carl Huang wrote:
> WCN6750 firmware crashes because of num_vdevs changed from 4 to 17
> in ath11k_init_wmi_config_qca6390() as the ab->hw_params.num_vdevs
> is 17. This is caused by commit f019f4dff2e4("wifi: ath11k: support
> 2 station interfaces") which assigns ab->hw_params.num_vdevs directly
> to config->num_vdevs in ath11k_init_wmi_config_qca6390(), therefore
> WCN6750 firmware crashes as it can't support such a big num_vdevs.
>
> Fix it by assign 3 to num_vdevs in hw_params for WCN6750 as 3 is
> sufficient too.
>
> Fixes: f019f4dff2e4 ("wifi: ath11k: support 2 station interfaces")
> Reported-by: Luca Weiss <luca.weiss@fairphone.com>
> Closes: https://lore.kernel.org/r/D15TIIDIIESY.D1EKKJLZINMA@fairphone.com/
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-01371-QCAMSLSWPLZ-1
>
> Signed-off-by: Carl Huang <quic_cjhuang@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs
2024-05-20 3:07 [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs Carl Huang
2024-05-20 4:57 ` Kalle Valo
2024-05-20 21:13 ` Jeff Johnson
@ 2024-05-21 8:04 ` Kalle Valo
2024-05-22 7:44 ` Luca Weiss
2024-05-23 12:44 ` Kalle Valo
3 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2024-05-21 8:04 UTC (permalink / raw)
To: Carl Huang; +Cc: ath11k, linux-wireless, quic_cjhuang, Luca Weiss
Carl Huang <quic_cjhuang@quicinc.com> wrote:
> WCN6750 firmware crashes because of num_vdevs changed from 4 to 17
> in ath11k_init_wmi_config_qca6390() as the ab->hw_params.num_vdevs
> is 17. This is caused by commit f019f4dff2e4("wifi: ath11k: support
> 2 station interfaces") which assigns ab->hw_params.num_vdevs directly
> to config->num_vdevs in ath11k_init_wmi_config_qca6390(), therefore
> WCN6750 firmware crashes as it can't support such a big num_vdevs.
>
> Fix it by assign 3 to num_vdevs in hw_params for WCN6750 as 3 is
> sufficient too.
>
> Fixes: f019f4dff2e4 ("wifi: ath11k: support 2 station interfaces")
> Reported-by: Luca Weiss <luca.weiss@fairphone.com>
> Closes: https://lore.kernel.org/r/D15TIIDIIESY.D1EKKJLZINMA@fairphone.com/
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-01371-QCAMSLSWPLZ-1
>
> Signed-off-by: Carl Huang <quic_cjhuang@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
This patch should go to v5.10 but I'll wait for Luca to test this first. No
rush with testing, this is just a status update.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240520030757.2209395-1-quic_cjhuang@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs
2024-05-21 8:04 ` Kalle Valo
@ 2024-05-22 7:44 ` Luca Weiss
0 siblings, 0 replies; 6+ messages in thread
From: Luca Weiss @ 2024-05-22 7:44 UTC (permalink / raw)
To: Kalle Valo, Carl Huang; +Cc: ath11k, linux-wireless
On Tue May 21, 2024 at 10:04 AM CEST, Kalle Valo wrote:
> Carl Huang <quic_cjhuang@quicinc.com> wrote:
>
> > WCN6750 firmware crashes because of num_vdevs changed from 4 to 17
> > in ath11k_init_wmi_config_qca6390() as the ab->hw_params.num_vdevs
> > is 17. This is caused by commit f019f4dff2e4("wifi: ath11k: support
> > 2 station interfaces") which assigns ab->hw_params.num_vdevs directly
> > to config->num_vdevs in ath11k_init_wmi_config_qca6390(), therefore
> > WCN6750 firmware crashes as it can't support such a big num_vdevs.
> >
> > Fix it by assign 3 to num_vdevs in hw_params for WCN6750 as 3 is
> > sufficient too.
> >
> > Fixes: f019f4dff2e4 ("wifi: ath11k: support 2 station interfaces")
> > Reported-by: Luca Weiss <luca.weiss@fairphone.com>
> > Closes: https://lore.kernel.org/r/D15TIIDIIESY.D1EKKJLZINMA@fairphone.com/
> > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
> > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-01371-QCAMSLSWPLZ-1
> >
> > Signed-off-by: Carl Huang <quic_cjhuang@quicinc.com>
> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>
> This patch should go to v5.10 but I'll wait for Luca to test this first. No
> rush with testing, this is just a status update.
Hi Kalle & Carl,
Thanks for adding me to CC, I didn't receive the original patch (@Carl
maybe check your email setup why I didn't get that one?).
I've reverted the previous patch "fix WCN6750 firmware crash" in my
branch and applied this one and everything still looks fine. Thanks!
Tested-by: Luca Weiss <luca.weiss@fairphone.com>
Regards
Luca
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs
2024-05-20 3:07 [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs Carl Huang
` (2 preceding siblings ...)
2024-05-21 8:04 ` Kalle Valo
@ 2024-05-23 12:44 ` Kalle Valo
3 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2024-05-23 12:44 UTC (permalink / raw)
To: Carl Huang; +Cc: ath11k, linux-wireless, quic_cjhuang
Carl Huang <quic_cjhuang@quicinc.com> wrote:
> WCN6750 firmware crashes because of num_vdevs changed from 4 to 17
> in ath11k_init_wmi_config_qca6390() as the ab->hw_params.num_vdevs
> is 17. This is caused by commit f019f4dff2e4 ("wifi: ath11k: support
> 2 station interfaces") which assigns ab->hw_params.num_vdevs directly
> to config->num_vdevs in ath11k_init_wmi_config_qca6390(), therefore
> WCN6750 firmware crashes as it can't support such a big num_vdevs.
>
> Fix it by assign 3 to num_vdevs in hw_params for WCN6750 as 3 is
> sufficient too.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-01371-QCAMSLSWPLZ-1
>
> Fixes: f019f4dff2e4 ("wifi: ath11k: support 2 station interfaces")
> Reported-by: Luca Weiss <luca.weiss@fairphone.com>
> Tested-by: Luca Weiss <luca.weiss@fairphone.com>
> Closes: https://lore.kernel.org/r/D15TIIDIIESY.D1EKKJLZINMA@fairphone.com/
> Signed-off-by: Carl Huang <quic_cjhuang@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-current branch of ath.git, thanks.
ed281c6ab6eb wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240520030757.2209395-1-quic_cjhuang@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-23 12:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-20 3:07 [PATCH] wifi: ath11k: fix WCN6750 firmware crash caused by 17 num_vdevs Carl Huang
2024-05-20 4:57 ` Kalle Valo
2024-05-20 21:13 ` Jeff Johnson
2024-05-21 8:04 ` Kalle Valo
2024-05-22 7:44 ` Luca Weiss
2024-05-23 12:44 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox