From: Johannes Berg <johannes@sipsolutions.net>
To: John Crispin <john@phrozen.org>, Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Shashidhar Lakkavalli <slakkavalli@datto.com>,
Srini Kode <skode@qti.qualcomm.com>,
Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
ath11k@lists.infradead.org
Subject: Re: [PATCH 1/3] mac80211: allow turning TWT responder support on and off via netlink
Date: Fri, 26 Apr 2019 10:49:17 +0200 [thread overview]
Message-ID: <b35bf3e3778858cf95d4e8b743a884e4cc424798.camel@sipsolutions.net> (raw)
In-Reply-To: <20190426084244.28098-2-john@phrozen.org>
On Fri, 2019-04-26 at 10:42 +0200, John Crispin wrote:
>
> +++ b/net/wireless/nl80211.c
> @@ -6105,6 +6105,7 @@ static int nl80211_set_bss(struct sk_buff *skb, struct genl_info *info)
> params.ht_opmode = -1;
> params.p2p_ctwindow = -1;
> params.p2p_opp_ps = -1;
> + params.twt_responder = -1;
>
> if (info->attrs[NL80211_ATTR_BSS_CTS_PROT])
> params.use_cts_prot =
> @@ -6149,6 +6150,10 @@ static int nl80211_set_bss(struct sk_buff *skb, struct genl_info *info)
> return -EINVAL;
> }
>
> + if (info->attrs[NL80211_ATTR_TWT_RESPONDER])
> + params.twt_responder =
> + nla_get_u8(info->attrs[NL80211_ATTR_TWT_RESPONDER]);
You need an NLA_POLICY_RANGE() policy for that attribute.
johannes
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2019-04-26 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 8:42 [PATCH 0/3] mac80211: notify the driver when it should enable TWT John Crispin
2019-04-26 8:42 ` [PATCH 1/3] mac80211: allow turning TWT responder support on and off via netlink John Crispin
2019-04-26 8:49 ` Johannes Berg [this message]
2019-04-26 8:42 ` [PATCH 2/3] mac80211: dynamically turn TWT requester support on and off John Crispin
2019-04-26 8:42 ` [PATCH 3/3] ath11k: add TWT support John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35bf3e3778858cf95d4e8b743a884e4cc424798.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qti.qualcomm.com \
--cc=skode@qti.qualcomm.com \
--cc=slakkavalli@datto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox