* [PATCH 7/7] arm64: dts: qcom: sda660-ifc6560: enable mDSP and WiFi devices
2024-09-07 18:48 [PATCH 0/7] arm64: qcom: sda660-ifc6560: enable GPU and WiFi support Dmitry Baryshkov
@ 2024-09-07 18:48 ` Dmitry Baryshkov
2024-09-09 11:40 ` Konrad Dybcio
2024-09-09 16:15 ` [PATCH 0/7] arm64: qcom: sda660-ifc6560: enable GPU and WiFi support Will Deacon
2024-10-07 14:25 ` (subset) " Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-09-07 18:48 UTC (permalink / raw)
To: Rob Clark, Will Deacon, Robin Murphy, Joerg Roedel,
AngeloGioacchino Del Regno, Konrad Dybcio, Bjorn Andersson,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: iommu, linux-arm-msm, linux-arm-kernel, linux-kernel, devicetree,
ath11k, Kalle Valo
Enable the onboard WiFi device present on the Inforce IFC6560 SBC.
Pretty much like MSM8998 this device also doesn't generate the
MSA_READY_IND indication.
For the reference:
ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40050000
ath10k_snoc 18800000.wifi: qmi fw_version 0x101d01da fw_build_timestamp 2018-07-26 21:42 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0.1.c2-00474-QCAHLSWMTPLZ-1
ath10k_snoc 18800000.wifi: qmi not waiting for msa_ready indicator
ath10k_snoc 18800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000
ath10k_snoc 18800000.wifi: kconfig debug 1 debugfs 0 tracing 0 dfs 0 testmode 0
ath10k_snoc 18800000.wifi: firmware ver api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790
ath10k_snoc 18800000.wifi: htt-ver 3.54 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1
ath10k_snoc 18800000.wifi: invalid MAC address; choosing random
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Cc: ath11k@lists.infradead.org
Cc: Kalle Valo <kvalo@kernel.org>
---
.../arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
index 09bc010ce56a..7948c8f6ab64 100644
--- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
+++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
@@ -252,6 +252,11 @@ &qusb2phy1 {
vdda-phy-dpdm-supply = <&vreg_l7b_3p125>;
};
+&remoteproc_mss {
+ firmware-name = "qcom/sda660/mba.mbn", "qcom/sda660/modem.mbn";
+ status = "okay";
+};
+
&rpm_requests {
regulators-0 {
compatible = "qcom,rpm-pm660-regulators";
@@ -291,6 +296,11 @@ vreg_l1a_1p225: l1 {
regulator-allow-set-load;
};
+ vreg_l5a_0p8: l5 {
+ regulator-min-microvolt = <848000>;
+ regulator-max-microvolt = <848000>;
+ };
+
vreg_l6a_1p3: l6 {
regulator-min-microvolt = <1304000>;
regulator-max-microvolt = <1368000>;
@@ -489,3 +499,15 @@ &usb3_qmpphy {
vdda-pll-supply = <&vreg_l10a_1p8>;
status = "okay";
};
+
+&wifi {
+ status = "okay";
+
+ vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
+ vdd-1.8-xo-supply = <&vreg_l9a_1p8>;
+ vdd-1.3-rfa-supply = <&vreg_l6a_1p3>;
+ vdd-3.3-ch0-supply = <&vreg_l19a_3p3>;
+ vdd-3.3-ch1-supply = <&vreg_l8b_3p3>;
+
+ qcom,ath10k-calibration-variant = "Inforce_IFC6560";
+};
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 7/7] arm64: dts: qcom: sda660-ifc6560: enable mDSP and WiFi devices
2024-09-07 18:48 ` [PATCH 7/7] arm64: dts: qcom: sda660-ifc6560: enable mDSP and WiFi devices Dmitry Baryshkov
@ 2024-09-09 11:40 ` Konrad Dybcio
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2024-09-09 11:40 UTC (permalink / raw)
To: Dmitry Baryshkov, Rob Clark, Will Deacon, Robin Murphy,
Joerg Roedel, AngeloGioacchino Del Regno, Konrad Dybcio,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: iommu, linux-arm-msm, linux-arm-kernel, linux-kernel, devicetree,
ath11k, Kalle Valo
On 7.09.2024 8:48 PM, Dmitry Baryshkov wrote:
> Enable the onboard WiFi device present on the Inforce IFC6560 SBC.
> Pretty much like MSM8998 this device also doesn't generate the
> MSA_READY_IND indication.
>
> For the reference:
>
> ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40050000
> ath10k_snoc 18800000.wifi: qmi fw_version 0x101d01da fw_build_timestamp 2018-07-26 21:42 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0.1.c2-00474-QCAHLSWMTPLZ-1
> ath10k_snoc 18800000.wifi: qmi not waiting for msa_ready indicator
> ath10k_snoc 18800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000
> ath10k_snoc 18800000.wifi: kconfig debug 1 debugfs 0 tracing 0 dfs 0 testmode 0
> ath10k_snoc 18800000.wifi: firmware ver api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790
> ath10k_snoc 18800000.wifi: htt-ver 3.54 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1
> ath10k_snoc 18800000.wifi: invalid MAC address; choosing random
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> ---
> Cc: ath11k@lists.infradead.org
> Cc: Kalle Valo <kvalo@kernel.org>
> ---
> .../arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> index 09bc010ce56a..7948c8f6ab64 100644
> --- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> +++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> @@ -252,6 +252,11 @@ &qusb2phy1 {
> vdda-phy-dpdm-supply = <&vreg_l7b_3p125>;
> };
>
> +&remoteproc_mss {
> + firmware-name = "qcom/sda660/mba.mbn", "qcom/sda660/modem.mbn";
> + status = "okay";
> +};
> +
> &rpm_requests {
> regulators-0 {
> compatible = "qcom,rpm-pm660-regulators";
> @@ -291,6 +296,11 @@ vreg_l1a_1p225: l1 {
> regulator-allow-set-load;
> };
>
> + vreg_l5a_0p8: l5 {
> + regulator-min-microvolt = <848000>;
> + regulator-max-microvolt = <848000>;
> + };
> +
> vreg_l6a_1p3: l6 {
> regulator-min-microvolt = <1304000>;
> regulator-max-microvolt = <1368000>;
> @@ -489,3 +499,15 @@ &usb3_qmpphy {
> vdda-pll-supply = <&vreg_l10a_1p8>;
> status = "okay";
> };
> +
> +&wifi {
> + status = "okay";
You placed status last in the addition above but not here :P
with that fixed:
Reviewed-by: Konrad Dybcio <konradybcio@kernel.org>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/7] arm64: qcom: sda660-ifc6560: enable GPU and WiFi support
2024-09-07 18:48 [PATCH 0/7] arm64: qcom: sda660-ifc6560: enable GPU and WiFi support Dmitry Baryshkov
2024-09-07 18:48 ` [PATCH 7/7] arm64: dts: qcom: sda660-ifc6560: enable mDSP and WiFi devices Dmitry Baryshkov
@ 2024-09-09 16:15 ` Will Deacon
2024-10-07 14:25 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2024-09-09 16:15 UTC (permalink / raw)
To: Rob Clark, Robin Murphy, Joerg Roedel, AngeloGioacchino Del Regno,
Konrad Dybcio, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov
Cc: catalin.marinas, kernel-team, Will Deacon, iommu, linux-arm-msm,
linux-arm-kernel, linux-kernel, devicetree, ath11k, Kalle Valo
On Sat, 07 Sep 2024 21:48:11 +0300, Dmitry Baryshkov wrote:
> Follow the MSM8998 example and limit num_context_banks on SDM630 /
> SDM660 platforms. This allows Linux to make use of the A2NOC and KGSL
> SMMU, making it possible to enable GPU and WiFi on those platforms, and,
> in particular, Inforce IFC6560 SBC.
>
> Note, while WiFI starts up and can work for a short amount of time, MSS
> starts crashing with the following message:
>
> [...]
Applied SMMU driver change to will (for-joerg/arm-smmu/updates), thanks!
[1/7] iommu/arm-smmu-qcom: apply num_context_bank fixes for SDM630 / SDM660
https://git.kernel.org/will/c/19eb465c969f
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: (subset) [PATCH 0/7] arm64: qcom: sda660-ifc6560: enable GPU and WiFi support
2024-09-07 18:48 [PATCH 0/7] arm64: qcom: sda660-ifc6560: enable GPU and WiFi support Dmitry Baryshkov
2024-09-07 18:48 ` [PATCH 7/7] arm64: dts: qcom: sda660-ifc6560: enable mDSP and WiFi devices Dmitry Baryshkov
2024-09-09 16:15 ` [PATCH 0/7] arm64: qcom: sda660-ifc6560: enable GPU and WiFi support Will Deacon
@ 2024-10-07 14:25 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2024-10-07 14:25 UTC (permalink / raw)
To: Rob Clark, Will Deacon, Robin Murphy, Joerg Roedel,
AngeloGioacchino Del Regno, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Dmitry Baryshkov
Cc: iommu, linux-arm-msm, linux-arm-kernel, linux-kernel, devicetree,
ath11k, Kalle Valo
On Sat, 07 Sep 2024 21:48:11 +0300, Dmitry Baryshkov wrote:
> Follow the MSM8998 example and limit num_context_banks on SDM630 /
> SDM660 platforms. This allows Linux to make use of the A2NOC and KGSL
> SMMU, making it possible to enable GPU and WiFi on those platforms, and,
> in particular, Inforce IFC6560 SBC.
>
> Note, while WiFI starts up and can work for a short amount of time, MSS
> starts crashing with the following message:
>
> [...]
Applied, thanks!
[2/7] arm64: dts: qcom: sdm630: enable GPU SMMU and GPUCC
commit: 166b955a8d60b38d4fbbb9a18994a49e607ab17e
[3/7] arm64: dts: qcom: sda660-ifc6560: enable GPU
commit: deac51aedd1e1e5ba0d46f23ef0012a8754e4871
[4/7] arm64: dts: qcom: sda660-ifc6560: fix l10a voltage ranges
commit: 1dd7d9d41dedf8d42e04c0f2febd4dbe5a062d4a
[5/7] arm64: dts: qcom: sdm630: enable A2NOC and LPASS SMMU
commit: 41caaf517014d11c17b2e6f3b057f7b6c9507cb0
[6/7] arm64: dts: qcom: sdm630: add WiFI device node
commit: d7e67846c08f46974da26c54af7793d47037d452
[7/7] arm64: dts: qcom: sda660-ifc6560: enable mDSP and WiFi devices
commit: 04d8ed02cb9b86a0e231ae0271527fbbfb411695
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread