* Re: [PATCH] net: qrtr: free flow in __qrtr_node_release
[not found] <1592882523-12870-1-git-send-email-cjhuang@codeaurora.org>
@ 2020-06-24 3:26 ` David Miller
2020-06-29 11:50 ` cjhuang
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2020-06-24 3:26 UTC (permalink / raw)
To: cjhuang; +Cc: netdev, linux-kernel, ath11k
From: Carl Huang <cjhuang@codeaurora.org>
Date: Tue, 23 Jun 2020 11:22:03 +0800
> @@ -168,6 +168,7 @@ static void __qrtr_node_release(struct kref *kref)
> struct radix_tree_iter iter;
> unsigned long flags;
> void __rcu **slot;
> + struct qrtr_tx_flow *flow;
Please retain the reverse christmas tree ordering of local variables here.
Thanks.
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: qrtr: free flow in __qrtr_node_release
2020-06-24 3:26 ` [PATCH] net: qrtr: free flow in __qrtr_node_release David Miller
@ 2020-06-29 11:50 ` cjhuang
0 siblings, 0 replies; 2+ messages in thread
From: cjhuang @ 2020-06-29 11:50 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel, ath11k
On 2020-06-24 11:26, David Miller wrote:
> From: Carl Huang <cjhuang@codeaurora.org>
> Date: Tue, 23 Jun 2020 11:22:03 +0800
>
>> @@ -168,6 +168,7 @@ static void __qrtr_node_release(struct kref *kref)
>> struct radix_tree_iter iter;
>> unsigned long flags;
>> void __rcu **slot;
>> + struct qrtr_tx_flow *flow;
>
> Please retain the reverse christmas tree ordering of local variables
> here.
OK. Will send V2 for it.
>
> Thanks.
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-29 11:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1592882523-12870-1-git-send-email-cjhuang@codeaurora.org>
2020-06-24 3:26 ` [PATCH] net: qrtr: free flow in __qrtr_node_release David Miller
2020-06-29 11:50 ` cjhuang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox