From: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/4] wifi: ath12k: Refactor the ath12k_hw get helper function argument
Date: Thu, 12 Dec 2024 15:01:00 +0530 [thread overview]
Message-ID: <3696af43-bb2e-868a-e301-6e612134a142@quicinc.com> (raw)
In-Reply-To: <874j39qr5h.fsf@kernel.org>
On 12/12/2024 1:17 PM, Kalle Valo wrote:
> Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
>
>> Currently, ath12k_hw is placed inside the ath12k_hw_group. However, the
>> ath12k_hw get helper function takes the device handle and the index as
>> parameters. Here, the index parameter is specific to the group handle.
>> Therefore, change this helper function argument from the device handle
>> to the group handle.
>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
>
> Why?
>
It just remove the dependency of device handle (ab) for using the helper
function ath12k_*_to_ah(). Now the caller can directly use
ath12k_hw_group (ag) instead of forcing to use the device handle from ag.
--
Karthikeyan Periyasamy
--
கார்த்திகேயன் பெரியசாமி
next prev parent reply other threads:[~2024-12-12 9:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 0:49 [PATCH 0/4] wifi: ath12k: Fix the static checker warning Karthikeyan Periyasamy
2024-12-12 0:49 ` [PATCH 1/4] wifi: ath12k: Refactor ath12k_hw set helper function argument Karthikeyan Periyasamy
2024-12-12 7:46 ` Kalle Valo
2024-12-12 9:21 ` Karthikeyan Periyasamy
2024-12-12 0:49 ` [PATCH 2/4] wifi: ath12k: Refactor the ath12k_hw get " Karthikeyan Periyasamy
2024-12-12 7:47 ` Kalle Valo
2024-12-12 9:31 ` Karthikeyan Periyasamy [this message]
2024-12-12 0:49 ` [PATCH 3/4] wifi: ath12k: Refactor ath12k_get_num_hw() " Karthikeyan Periyasamy
2024-12-12 7:49 ` Kalle Valo
2024-12-12 10:25 ` Karthikeyan Periyasamy
2024-12-12 0:49 ` [PATCH 4/4] wifi: ath12k: Fix uninitialized variable access in ath12k_mac_allocate() function Karthikeyan Periyasamy
2024-12-12 7:56 ` Kalle Valo
2024-12-12 10:37 ` Karthikeyan Periyasamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3696af43-bb2e-868a-e301-6e612134a142@quicinc.com \
--to=quic_periyasa@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox