From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH 3/4] wifi: ath12k: Refactor ath12k_get_num_hw() helper function argument
Date: Thu, 12 Dec 2024 09:49:55 +0200 [thread overview]
Message-ID: <87zfl1pcgs.fsf@kernel.org> (raw)
In-Reply-To: <20241212004906.3087425-4-quic_periyasa@quicinc.com> (Karthikeyan Periyasamy's message of "Thu, 12 Dec 2024 06:19:05 +0530")
Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
> Currently, the ath12k_get_num_hw() helper function takes the device handle
> as an argument. Here, the number of hardware is retrieved from the group
> handle. Demanding the device handle from the caller is unnecessary since
> in some cases the group handle is already available. Therefore, change this
> helper function argument from the device handle to the group handle. This
> also fixes the below Smatch static checker warning.
>
> Smatch warning:
> ath12k_mac_destroy() error: we previously assumed 'ab' could be null
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/ath12k/3e705de0-67d1-4437-97ff-4828d83ae2af@stanley.mountain/
> Closes: https://scan7.scan.coverity.com/#/project-view/52682/11354?selectedIssue=1602340
> Fixes: a343d97f27f5 ("wifi: ath12k: move struct ath12k_hw from per device to group")
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
I don't get how this is any better but of course I might be missing
something. To me this looks like shuffling code around to shut up a
smatch warning.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-12-12 7:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 0:49 [PATCH 0/4] wifi: ath12k: Fix the static checker warning Karthikeyan Periyasamy
2024-12-12 0:49 ` [PATCH 1/4] wifi: ath12k: Refactor ath12k_hw set helper function argument Karthikeyan Periyasamy
2024-12-12 7:46 ` Kalle Valo
2024-12-12 9:21 ` Karthikeyan Periyasamy
2024-12-12 0:49 ` [PATCH 2/4] wifi: ath12k: Refactor the ath12k_hw get " Karthikeyan Periyasamy
2024-12-12 7:47 ` Kalle Valo
2024-12-12 9:31 ` Karthikeyan Periyasamy
2024-12-12 0:49 ` [PATCH 3/4] wifi: ath12k: Refactor ath12k_get_num_hw() " Karthikeyan Periyasamy
2024-12-12 7:49 ` Kalle Valo [this message]
2024-12-12 10:25 ` Karthikeyan Periyasamy
2024-12-12 0:49 ` [PATCH 4/4] wifi: ath12k: Fix uninitialized variable access in ath12k_mac_allocate() function Karthikeyan Periyasamy
2024-12-12 7:56 ` Kalle Valo
2024-12-12 10:37 ` Karthikeyan Periyasamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfl1pcgs.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox