public inbox for ath12k@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, Kalle Valo <kvalo@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jeff Johnson <jjohnson@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [RFC PATCH 2/6] dt-bindings: net: wireless: ath12k: describe WSI property for QCN9274
Date: Sat, 26 Oct 2024 20:10:55 +0200	[thread overview]
Message-ID: <520c4ac3-a826-4504-9aff-6c2126a85793@kernel.org> (raw)
In-Reply-To: <db0a6797-0e51-45b2-bf8a-58d53d8cf959@quicinc.com>

On 25/10/2024 12:08, Raj Kumar Bhagat wrote:
>>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
>>> ---
>>>  .../bindings/net/wireless/qcom,ath12k.yaml    | 61 +++++++++++++++++++
>>>  1 file changed, 61 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
>>> index ecf38af747f7..6c8f97865075 100644
>>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
>>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
>>> @@ -19,6 +19,7 @@ properties:
>>>    compatible:
>>>      enum:
>>>        - pci17cb,1107  # WCN7850
>>> +      - pci17cb,1109  # QCN9274
>>
>> Missing supplies. How does the device take power? Everything through
>> standard PCI pins? Are you sure? Please submit complete binding, so with
>> all required properties.
>>
> 
> QCN9274 gets powered from the standard Pcie (3.3 V) supply. No additional
> regulators are required.

OK, just keep in mind that if you come later with PMU approach to solve
your sequencing problem, we can just NAK it based on above explanation
that PMU approach is not required.

Existing binding lists required supplies on purpose, that's not
coincidence. But of course I don't know if it applies to your case, so
above confirms that it does not apply.

Best regards,
Krzysztof



  reply	other threads:[~2024-10-26 18:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23  6:03 [RFC PATCH 0/6] wifi: ath12k: Add WSI node for QCN9274 in RDP433 for MLO Raj Kumar Bhagat
2024-10-23  6:03 ` [RFC PATCH 1/6] dt-bindings: net: wireless: update required properties for ath12k PCI module Raj Kumar Bhagat
2024-10-23  6:35   ` Krzysztof Kozlowski
2024-10-23  6:45     ` Raj Kumar Bhagat
2024-10-23  6:47       ` Krzysztof Kozlowski
2024-10-23  6:53         ` Raj Kumar Bhagat
2024-10-23  6:59           ` Krzysztof Kozlowski
2024-10-23 10:28             ` Raj Kumar Bhagat
2024-10-23 12:08               ` Krzysztof Kozlowski
2024-10-25  9:59                 ` Raj Kumar Bhagat
2024-10-23  6:03 ` [RFC PATCH 2/6] dt-bindings: net: wireless: ath12k: describe WSI property for QCN9274 Raj Kumar Bhagat
2024-10-23  6:38   ` Krzysztof Kozlowski
2024-10-23  6:48     ` Krzysztof Kozlowski
2024-10-23 12:22     ` Raj Kumar Bhagat
2024-10-23 17:57       ` Krzysztof Kozlowski
2024-10-25 10:06         ` Raj Kumar Bhagat
2024-10-23  7:00   ` Krzysztof Kozlowski
2024-10-25 10:08     ` Raj Kumar Bhagat
2024-10-26 18:10       ` Krzysztof Kozlowski [this message]
2024-10-23  6:03 ` [RFC PATCH 3/6] wifi: ath12k: parse multiple device information from device tree Raj Kumar Bhagat
2024-10-23  6:39   ` Krzysztof Kozlowski
2024-10-23  6:03 ` [RFC PATCH 4/6] wifi: ath12k: Send partner device details in QMI MLO capability Raj Kumar Bhagat
2024-10-23  6:03 ` [RFC PATCH 5/6] wifi: ath12k: assign unique hardware link IDs during QMI host cap Raj Kumar Bhagat
2024-10-23  6:03 ` [RFC PATCH 6/6] arm64: dts: qcom: ipq9574: Add WiFi nodes for RDP433 Raj Kumar Bhagat
2024-10-23  6:41   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520c4ac3-a826-4504-9aff-6c2126a85793@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jjohnson@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_rajkbhag@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox