public inbox for ath12k@lists.infradead.org
 help / color / mirror / Atom feed
From: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, Kalle Valo <kvalo@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jeff Johnson <jjohnson@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>
Subject: Re: [RFC PATCH 1/6] dt-bindings: net: wireless: update required properties for ath12k PCI module
Date: Wed, 23 Oct 2024 12:23:29 +0530	[thread overview]
Message-ID: <e7b27f57-efb2-45ea-bbe0-e5aeb90cbff9@quicinc.com> (raw)
In-Reply-To: <b97b8350-3925-40b0-8f87-f89df429a52a@kernel.org>

On 10/23/2024 12:17 PM, Krzysztof Kozlowski wrote:
> On 23/10/2024 08:45, Raj Kumar Bhagat wrote:
>> On 10/23/2024 12:05 PM, Krzysztof Kozlowski wrote:
>>> On 23/10/2024 08:03, Raj Kumar Bhagat wrote:
>>>> The current device-tree bindings for the Ath12K module list many
>>>> WCN7850-specific properties as required. However, these properties are
>>>> not applicable to other Ath12K devices.
>>>>
>>>> Hence, remove WCN7850-specific properties from the required section,
>>>> retaining only generic properties valid across all Ath12K devices.
>>>> WCN7850-specific properties will remain required based on the device's
>>>> compatible enum.
>>> Just not true. These apply to all devices described in this binding.
>>>
>>> NAK.
>>>
>>> Don't send patches for your downstream stuff.
>> This is not for downstream. This series is the per-requisite for ath12k
>> MLO support in upstream.
>>
>> In the subsequent patch [2/6] we are adding new device (QCN9274) in this
>> binding that do not require the WCN7850 specific properties.
>>
>> This is a refactoring patch for the next patch [2/6].
> It's just wrong. Not true. At this point of patch there are no other
> devices. Don't refactor uselessly introducing incorrect hardware

Ok then, If we squash this patch with the next patch [2/6], that actually adding
the new device, then this patch changes are valid right?


  reply	other threads:[~2024-10-23  6:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23  6:03 [RFC PATCH 0/6] wifi: ath12k: Add WSI node for QCN9274 in RDP433 for MLO Raj Kumar Bhagat
2024-10-23  6:03 ` [RFC PATCH 1/6] dt-bindings: net: wireless: update required properties for ath12k PCI module Raj Kumar Bhagat
2024-10-23  6:35   ` Krzysztof Kozlowski
2024-10-23  6:45     ` Raj Kumar Bhagat
2024-10-23  6:47       ` Krzysztof Kozlowski
2024-10-23  6:53         ` Raj Kumar Bhagat [this message]
2024-10-23  6:59           ` Krzysztof Kozlowski
2024-10-23 10:28             ` Raj Kumar Bhagat
2024-10-23 12:08               ` Krzysztof Kozlowski
2024-10-25  9:59                 ` Raj Kumar Bhagat
2024-10-23  6:03 ` [RFC PATCH 2/6] dt-bindings: net: wireless: ath12k: describe WSI property for QCN9274 Raj Kumar Bhagat
2024-10-23  6:38   ` Krzysztof Kozlowski
2024-10-23  6:48     ` Krzysztof Kozlowski
2024-10-23 12:22     ` Raj Kumar Bhagat
2024-10-23 17:57       ` Krzysztof Kozlowski
2024-10-25 10:06         ` Raj Kumar Bhagat
2024-10-23  7:00   ` Krzysztof Kozlowski
2024-10-25 10:08     ` Raj Kumar Bhagat
2024-10-26 18:10       ` Krzysztof Kozlowski
2024-10-23  6:03 ` [RFC PATCH 3/6] wifi: ath12k: parse multiple device information from device tree Raj Kumar Bhagat
2024-10-23  6:39   ` Krzysztof Kozlowski
2024-10-23  6:03 ` [RFC PATCH 4/6] wifi: ath12k: Send partner device details in QMI MLO capability Raj Kumar Bhagat
2024-10-23  6:03 ` [RFC PATCH 5/6] wifi: ath12k: assign unique hardware link IDs during QMI host cap Raj Kumar Bhagat
2024-10-23  6:03 ` [RFC PATCH 6/6] arm64: dts: qcom: ipq9574: Add WiFi nodes for RDP433 Raj Kumar Bhagat
2024-10-23  6:41   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7b27f57-efb2-45ea-bbe0-e5aeb90cbff9@quicinc.com \
    --to=quic_rajkbhag@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jjohnson@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox