public inbox for ath12k@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] wifi: ath12k: Support Rx PDEV HTT stats
@ 2024-07-25  5:42 Ramya Gnanasekar
  2024-07-25  6:27 ` david Atkins
  2024-07-25 17:47 ` [PATCH] wifi: " Jeff Johnson
  0 siblings, 2 replies; 5+ messages in thread
From: Ramya Gnanasekar @ 2024-07-25  5:42 UTC (permalink / raw)
  To: ath12k; +Cc: linux-wireless, Dinesh Karthikeyan, Ramya Gnanasekar

From: Dinesh Karthikeyan <quic_dinek@quicinc.com>

Add support to parse and dump the Rx PDEV related stats such as
SOC stats, PHY error, MPDU error through htt stats type 2.

Sample output:
-------------
echo 2 > /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/htt_stats_type
cat /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/htt_stats

HTT_RX_PDEV_FW_STATS_TLV:
mac_id = 0
ppdu_recvd = 215
mpdu_cnt_fcs_ok = 215
mpdu_cnt_fcs_err = 0
tcp_msdu_cnt = 0
tcp_ack_msdu_cnt = 0
udp_msdu_cnt = 0
other_msdu_cnt = 215
fw_ring_mpdu_ind = 215
fw_ring_mgmt_subtype =  0:0, 1:0, 2:0, 3:0, 4:21, 5:1, 6:0, 7:0, 8:193, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0
fw_ring_ctrl_subtype =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0
fw_ring_mcast_data_msdu = 0
fw_ring_bcast_data_msdu = 0
fw_ring_ucast_data_msdu = 0
fw_ring_null_data_msdu = 0
fw_ring_mpdu_drop = 0
ofld_local_data_ind_cnt = 0
ofld_local_data_buf_recycle_cnt = 0
drx_local_data_ind_cnt = 0
drx_local_data_buf_recycle_cnt = 0
local_nondata_ind_cnt = 215
local_nondata_buf_recycle_cnt = 215
fw_status_buf_ring_refill_cnt = 215
fw_status_buf_ring_empty_cnt = 0
fw_pkt_buf_ring_refill_cnt = 215
fw_pkt_buf_ring_empty_cnt = 0
fw_link_buf_ring_refill_cnt = 215
fw_link_buf_ring_empty_cnt = 0
host_pkt_buf_ring_refill_cnt = 0
host_pkt_buf_ring_empty_cnt = 0
mon_pkt_buf_ring_refill_cnt = 0
mon_pkt_buf_ring_empty_cnt = 0
mon_status_buf_ring_refill_cnt = 0
mon_status_buf_ring_empty_cnt = 0
mon_desc_buf_ring_refill_cnt = 0
mon_desc_buf_ring_empty_cnt = 0
mon_dest_ring_update_cnt = 0
mon_dest_ring_full_cnt = 0
rx_suspend_cnt = 0
rx_resume_fail_cnt = 0
rx_ring_switch_cnt = 0
rx_ring_restore_cnt = 0
rx_flush_cnt = 0
rx_recovery_reset_cnt = 0

HTT_RX_PDEV_FW_RING_MPDU_ERR_TLV:
fw_ring_mpdu_err =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0

HTT_RX_PDEV_FW_MPDU_DROP_TLV:
fw_mpdu_drop =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0

HTT_RX_SOC_FW_STATS_TLV:
fw_reo_ring_data_msdu = 0
fw_to_host_data_msdu_bcmc = 0
fw_to_host_data_msdu_uc = 0
ofld_remote_data_buf_recycle_cnt = 0
ofld_remote_free_buf_indication_cnt = 0
ofld_buf_to_host_data_msdu_uc = 0
reo_fw_ring_to_host_data_msdu_uc = 0
wbm_sw_ring_reap = 0
wbm_forward_to_host_cnt = 0
wbm_target_recycle_cnt = 0
target_refill_ring_recycle_cnt = 0

HTT_RX_SOC_FW_REFILL_RING_EMPTY_TLV:
refill_ring_empty_cnt =  0:0, 1:0, 2:0, 3:0

HTT_RX_SOC_FW_REFILL_RING_NUM_REFILL_TLV:
refill_ring_num_refill =  0:0, 1:0, 2:0, 3:0

HTT_RX_SOC_FW_REFILL_RING_NUM_RXDMA_ERR_TLV:
rxdma_err =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0

HTT_RX_SOC_FW_REFILL_RING_NUM_REO_ERR_TLV:
reo_err =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0

HTT_RX_PDEV_FW_STATS_PHY_ERR_TLV:
mac_id_word = 0
total_phy_err_nct = 0
phy_errs =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0, 16:0, 17:0, 18:0, 19:0, 20:0, 21:0, 22:0, 23:0, 24:0, 25:0, 26:0, 27:0, 28:0, 29:0, 30:0, 31:0, 32:0, 33:0, 34:0, 35:0, 36:0, 37:0, 38:0, 39:0, 40:0, 41:0, 42:0

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: Dinesh Karthikeyan <quic_dinek@quicinc.com>
Signed-off-by: Ramya Gnanasekar <quic_rgnanase@quicinc.com>
---
 drivers/net/wireless/ath/ath12k/debugfs.h     |   2 +
 .../wireless/ath/ath12k/debugfs_htt_stats.c   | 342 ++++++++++++++++++
 .../wireless/ath/ath12k/debugfs_htt_stats.h   | 138 +++++++
 3 files changed, 482 insertions(+)

diff --git a/drivers/net/wireless/ath/ath12k/debugfs.h b/drivers/net/wireless/ath/ath12k/debugfs.h
index 8d64ba03aa9a..00b34e00cdf2 100644
--- a/drivers/net/wireless/ath/ath12k/debugfs.h
+++ b/drivers/net/wireless/ath/ath12k/debugfs.h
@@ -7,6 +7,8 @@
 #ifndef _ATH12K_DEBUGFS_H_
 #define _ATH12K_DEBUGFS_H_
 
+#define IEEE80211_MGMT_FRAME_SUBTYPE_MAX	16
+
 #ifdef CONFIG_ATH12K_DEBUGFS
 void ath12k_debugfs_soc_create(struct ath12k_base *ab);
 void ath12k_debugfs_soc_destroy(struct ath12k_base *ab);
diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
index f1b7e74aefe4..c2b0bb134c11 100644
--- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
+++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
@@ -1447,6 +1447,320 @@ ath12k_htt_print_tx_de_compl_stats_tlv(const void *tag_buf, u16 tag_len,
 	stats_req->buf_len = len;
 }
 
+static void htt_print_rx_pdev_fw_stats_tlv(const void *tag_buf, u16 tag_len,
+					   struct debug_htt_stats_req *stats_req)
+{
+	const struct ath12k_htt_rx_pdev_fw_stats_tlv *htt_stats_buf = tag_buf;
+	u8 *buf = stats_req->buf;
+	u32 len = stats_req->buf_len;
+	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
+	u32 mac_id_word;
+
+	if (tag_len < sizeof(*htt_stats_buf))
+		return;
+
+	mac_id_word =  __le32_to_cpu(htt_stats_buf->mac_id_word);
+
+	len += scnprintf(buf + len, buf_len - len, "HTT_RX_PDEV_FW_STATS_TLV:\n");
+	len += scnprintf(buf + len, buf_len - len, "mac_id = %d\n",
+			 u32_get_bits(mac_id_word, ATH12K_HTT_STATS_MAC_ID));
+	len += scnprintf(buf + len, buf_len - len, "ppdu_recvd = %u\n",
+			 le32_to_cpu(htt_stats_buf->ppdu_recvd));
+	len += scnprintf(buf + len, buf_len - len, "mpdu_cnt_fcs_ok = %u\n",
+			 le32_to_cpu(htt_stats_buf->mpdu_cnt_fcs_ok));
+	len += scnprintf(buf + len, buf_len - len, "mpdu_cnt_fcs_err = %u\n",
+			 le32_to_cpu(htt_stats_buf->mpdu_cnt_fcs_err));
+	len += scnprintf(buf + len, buf_len - len, "tcp_msdu_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->tcp_msdu_cnt));
+	len += scnprintf(buf + len, buf_len - len, "tcp_ack_msdu_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->tcp_ack_msdu_cnt));
+	len += scnprintf(buf + len, buf_len - len, "udp_msdu_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->udp_msdu_cnt));
+	len += scnprintf(buf + len, buf_len - len, "other_msdu_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->other_msdu_cnt));
+	len += scnprintf(buf + len, buf_len - len, "fw_ring_mpdu_ind = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_ring_mpdu_ind));
+
+	len += print_array_to_buf(buf, len, "fw_ring_mgmt_subtype",
+				  htt_stats_buf->fw_ring_mgmt_subtype,
+				  IEEE80211_MGMT_FRAME_SUBTYPE_MAX, "\n");
+
+	len += print_array_to_buf(buf, len, "fw_ring_ctrl_subtype",
+				  htt_stats_buf->fw_ring_ctrl_subtype,
+				  IEEE80211_MGMT_FRAME_SUBTYPE_MAX, "\n");
+
+	len += scnprintf(buf + len, buf_len - len, "fw_ring_mcast_data_msdu = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_ring_mcast_data_msdu));
+	len += scnprintf(buf + len, buf_len - len, "fw_ring_bcast_data_msdu = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_ring_bcast_data_msdu));
+	len += scnprintf(buf + len, buf_len - len, "fw_ring_ucast_data_msdu = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_ring_ucast_data_msdu));
+	len += scnprintf(buf + len, buf_len - len, "fw_ring_null_data_msdu = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_ring_null_data_msdu));
+	len += scnprintf(buf + len, buf_len - len, "fw_ring_mpdu_drop = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_ring_mpdu_drop));
+	len += scnprintf(buf + len, buf_len - len, "ofld_local_data_ind_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->ofld_local_data_ind_cnt));
+	len += scnprintf(buf + len, buf_len - len,
+			 "ofld_local_data_buf_recycle_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->ofld_local_data_buf_recycle_cnt));
+	len += scnprintf(buf + len, buf_len - len, "drx_local_data_ind_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->drx_local_data_ind_cnt));
+	len += scnprintf(buf + len, buf_len - len,
+			 "drx_local_data_buf_recycle_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->drx_local_data_buf_recycle_cnt));
+	len += scnprintf(buf + len, buf_len - len, "local_nondata_ind_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->local_nondata_ind_cnt));
+	len += scnprintf(buf + len, buf_len - len, "local_nondata_buf_recycle_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->local_nondata_buf_recycle_cnt));
+	len += scnprintf(buf + len, buf_len - len, "fw_status_buf_ring_refill_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_status_buf_ring_refill_cnt));
+	len += scnprintf(buf + len, buf_len - len, "fw_status_buf_ring_empty_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_status_buf_ring_empty_cnt));
+	len += scnprintf(buf + len, buf_len - len, "fw_pkt_buf_ring_refill_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_pkt_buf_ring_refill_cnt));
+	len += scnprintf(buf + len, buf_len - len, "fw_pkt_buf_ring_empty_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_pkt_buf_ring_empty_cnt));
+	len += scnprintf(buf + len, buf_len - len, "fw_link_buf_ring_refill_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_link_buf_ring_refill_cnt));
+	len += scnprintf(buf + len, buf_len - len, "fw_link_buf_ring_empty_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_link_buf_ring_empty_cnt));
+	len += scnprintf(buf + len, buf_len - len, "host_pkt_buf_ring_refill_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->host_pkt_buf_ring_refill_cnt));
+	len += scnprintf(buf + len, buf_len - len, "host_pkt_buf_ring_empty_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->host_pkt_buf_ring_empty_cnt));
+	len += scnprintf(buf + len, buf_len - len, "mon_pkt_buf_ring_refill_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->mon_pkt_buf_ring_refill_cnt));
+	len += scnprintf(buf + len, buf_len - len, "mon_pkt_buf_ring_empty_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->mon_pkt_buf_ring_empty_cnt));
+	len += scnprintf(buf + len, buf_len - len,
+			 "mon_status_buf_ring_refill_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->mon_status_buf_ring_refill_cnt));
+	len += scnprintf(buf + len, buf_len - len, "mon_status_buf_ring_empty_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->mon_status_buf_ring_empty_cnt));
+	len += scnprintf(buf + len, buf_len - len, "mon_desc_buf_ring_refill_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->mon_desc_buf_ring_refill_cnt));
+	len += scnprintf(buf + len, buf_len - len, "mon_desc_buf_ring_empty_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->mon_desc_buf_ring_empty_cnt));
+	len += scnprintf(buf + len, buf_len - len, "mon_dest_ring_update_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->mon_dest_ring_update_cnt));
+	len += scnprintf(buf + len, buf_len - len, "mon_dest_ring_full_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->mon_dest_ring_full_cnt));
+	len += scnprintf(buf + len, buf_len - len, "rx_suspend_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->rx_suspend_cnt));
+	len += scnprintf(buf + len, buf_len - len, "rx_resume_fail_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->rx_resume_fail_cnt));
+	len += scnprintf(buf + len, buf_len - len, "rx_ring_switch_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->rx_ring_switch_cnt));
+	len += scnprintf(buf + len, buf_len - len, "rx_ring_restore_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->rx_ring_restore_cnt));
+	len += scnprintf(buf + len, buf_len - len, "rx_flush_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->rx_flush_cnt));
+	len += scnprintf(buf + len, buf_len - len, "rx_recovery_reset_cnt = %u\n\n",
+			 le32_to_cpu(htt_stats_buf->rx_recovery_reset_cnt));
+
+	stats_req->buf_len = len;
+}
+
+static void
+htt_print_rx_pdev_fw_ring_mpdu_err_tlv(const void *tag_buf, u16 tag_len,
+				       struct debug_htt_stats_req *stats_req)
+{
+	const struct ath12k_htt_rx_pdev_fw_ring_mpdu_err_tlv *htt_stats_buf = tag_buf;
+	u8 *buf = stats_req->buf;
+	u32 len = stats_req->buf_len;
+	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
+	u16 num_elems = min_t(u16, (tag_len >> 2),
+			      ATH12K_HTT_RX_STATS_RXDMA_MAX_ERR);
+
+	len += scnprintf(buf + len, buf_len - len,
+			 "HTT_RX_PDEV_FW_RING_MPDU_ERR_TLV:\n");
+
+	len += print_array_to_buf(buf, len, "fw_ring_mpdu_err",
+				  htt_stats_buf->fw_ring_mpdu_err,
+				  num_elems, "\n\n");
+	stats_req->buf_len = len;
+}
+
+static void
+htt_print_rx_pdev_fw_mpdu_drop_tlv(const void *tag_buf,
+				   u16 tag_len,
+				   struct debug_htt_stats_req *stats_req)
+{
+	const struct ath12k_htt_rx_pdev_fw_mpdu_drop_tlv *htt_stats_buf = tag_buf;
+	u8 *buf = stats_req->buf;
+	u32 len = stats_req->buf_len;
+	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
+	u16 num_elems = min_t(u16, (tag_len >> 2),
+			      ATH12K_HTT_RX_STATS_FW_DROP_REASON_MAX);
+
+	len += scnprintf(buf + len, buf_len - len, "HTT_RX_PDEV_FW_MPDU_DROP_TLV:\n");
+
+	len += print_array_to_buf(buf, len, "fw_mpdu_drop",
+				  htt_stats_buf->fw_mpdu_drop,
+				  num_elems, "\n\n");
+	stats_req->buf_len = len;
+}
+
+static void
+htt_print_rx_soc_fw_stats_tlv(const void *tag_buf, u16 tag_len,
+			      struct debug_htt_stats_req *stats_req)
+{
+	const struct ath12k_htt_rx_soc_fw_stats_tlv *htt_stats_buf = tag_buf;
+	u8 *buf = stats_req->buf;
+	u32 len = stats_req->buf_len;
+	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
+
+	if (tag_len < sizeof(*htt_stats_buf))
+		return;
+
+	len += scnprintf(buf + len, buf_len - len, "HTT_RX_SOC_FW_STATS_TLV:\n");
+	len += scnprintf(buf + len, buf_len - len, "fw_reo_ring_data_msdu = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_reo_ring_data_msdu));
+	len += scnprintf(buf + len, buf_len - len, "fw_to_host_data_msdu_bcmc = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_to_host_data_msdu_bcmc));
+	len += scnprintf(buf + len, buf_len - len, "fw_to_host_data_msdu_uc = %u\n",
+			 le32_to_cpu(htt_stats_buf->fw_to_host_data_msdu_uc));
+	len += scnprintf(buf + len, buf_len - len,
+			 "ofld_remote_data_buf_recycle_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->ofld_remote_data_buf_recycle_cnt));
+	len += scnprintf(buf + len, buf_len - len,
+			 "ofld_remote_free_buf_indication_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->ofld_remote_free_buf_indication_cnt));
+	len += scnprintf(buf + len, buf_len - len,
+			 "ofld_buf_to_host_data_msdu_uc = %u\n",
+			 le32_to_cpu(htt_stats_buf->ofld_buf_to_host_data_msdu_uc));
+	len += scnprintf(buf + len, buf_len - len,
+			 "reo_fw_ring_to_host_data_msdu_uc = %u\n",
+			 le32_to_cpu(htt_stats_buf->reo_fw_ring_to_host_data_msdu_uc));
+	len += scnprintf(buf + len, buf_len - len, "wbm_sw_ring_reap = %u\n",
+			 le32_to_cpu(htt_stats_buf->wbm_sw_ring_reap));
+	len += scnprintf(buf + len, buf_len - len, "wbm_forward_to_host_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->wbm_forward_to_host_cnt));
+	len += scnprintf(buf + len, buf_len - len, "wbm_target_recycle_cnt = %u\n",
+			 le32_to_cpu(htt_stats_buf->wbm_target_recycle_cnt));
+	len += scnprintf(buf + len, buf_len - len,
+			 "target_refill_ring_recycle_cnt = %u\n\n",
+			 le32_to_cpu(htt_stats_buf->target_refill_ring_recycle_cnt));
+
+	stats_req->buf_len = len;
+}
+
+static void
+htt_print_rx_soc_fw_refill_ring_empty_tlv(const void *tag_buf,
+					  u16 tag_len,
+					  struct debug_htt_stats_req *stats_req)
+{
+	const struct ath12k_htt_rx_soc_fw_refill_ring_empty_tlv *htt_stats_buf = tag_buf;
+	u8 *buf = stats_req->buf;
+	u32 len = stats_req->buf_len;
+	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
+	u16 num_elems = min_t(u16, (tag_len >> 2),
+			      ATH12K_HTT_RX_STATS_REFILL_MAX_RING);
+
+	len += scnprintf(buf + len, buf_len - len,
+			 "HTT_RX_SOC_FW_REFILL_RING_EMPTY_TLV:\n");
+
+	len += print_array_to_buf(buf, len, "refill_ring_empty_cnt",
+				  htt_stats_buf->refill_ring_empty_cnt,
+				  num_elems, "\n\n");
+
+	stats_req->buf_len = len;
+}
+
+static void
+htt_print_rx_soc_fw_refill_ring_num_refill_tlv(const void *tag_buf,
+					       u16 tag_len,
+					       struct debug_htt_stats_req *stats_req)
+{
+	const struct ath12k_htt_rx_soc_fw_refill_ring_num_refill_tlv *htt_stats_buf =
+									tag_buf;
+	u8 *buf = stats_req->buf;
+	u32 len = stats_req->buf_len;
+	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
+	u16 num_elems = min_t(u16, (tag_len >> 2),
+				    ATH12K_HTT_RX_STATS_REFILL_MAX_RING);
+
+	len += scnprintf(buf + len, buf_len - len,
+			 "HTT_RX_SOC_FW_REFILL_RING_NUM_REFILL_TLV:\n");
+
+	len += print_array_to_buf(buf, len, "refill_ring_num_refill",
+			   htt_stats_buf->refill_ring_num_refill,
+			   num_elems, "\n\n");
+
+	stats_req->buf_len = len;
+}
+
+static void
+htt_print_rx_soc_fw_refill_ring_num_rxdma_err_tlv(const void *tag_buf,
+						  u16 tag_len,
+						  struct debug_htt_stats_req *stats_req)
+{
+	const struct ath12k_htt_rx_soc_fw_refill_ring_num_rxdma_err_tlv *htt_stats_buf =
+		tag_buf;
+	u8 *buf = stats_req->buf;
+	u32 len = stats_req->buf_len;
+	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
+	u16 num_elems = min_t(u16, (tag_len >> 2), ATH12K_HTT_RX_RXDMA_MAX_ERR_CODE);
+
+	len += scnprintf(buf + len, buf_len - len,
+			 "HTT_RX_SOC_FW_REFILL_RING_NUM_RXDMA_ERR_TLV:\n");
+
+	len += print_array_to_buf(buf, len, "rxdma_err", htt_stats_buf->rxdma_err,
+				  num_elems, "\n\n");
+
+	stats_req->buf_len = len;
+}
+
+static void
+htt_print_rx_soc_fw_refill_ring_num_reo_err_tlv(const void *tag_buf,
+						u16 tag_len,
+						struct debug_htt_stats_req *stats_req)
+{
+	const struct ath12k_htt_rx_soc_fw_refill_ring_num_reo_err_tlv *htt_stats_buf =
+									tag_buf;
+	u8 *buf = stats_req->buf;
+	u32 len = stats_req->buf_len;
+	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
+	u16 num_elems = min_t(u16, (tag_len >> 2), ATH12K_HTT_RX_REO_MAX_ERR_CODE);
+
+	len += scnprintf(buf + len, buf_len - len,
+			 "HTT_RX_SOC_FW_REFILL_RING_NUM_REO_ERR_TLV:\n");
+
+	len += print_array_to_buf(buf, len, "reo_err", htt_stats_buf->reo_err,
+				  num_elems, "\n\n");
+
+	stats_req->buf_len = len;
+}
+
+static void
+htt_print_rx_pdev_fw_stats_phy_err_tlv(const void *tag_buf, u16 tag_len,
+				       struct debug_htt_stats_req *stats_req)
+{
+	const struct ath12k_htt_rx_pdev_fw_stats_phy_err_tlv *htt_stats_buf = tag_buf;
+	u8 *buf = stats_req->buf;
+	u32 len = stats_req->buf_len;
+	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
+	u32 mac_id_word;
+
+	if (tag_len < sizeof(*htt_stats_buf))
+		return;
+
+	mac_id_word = __le32_to_cpu(htt_stats_buf->mac_id__word);
+
+	len += scnprintf(buf + len, buf_len - len,
+			 "HTT_RX_PDEV_FW_STATS_PHY_ERR_TLV:\n");
+	len += scnprintf(buf + len, buf_len - len, "mac_id_word = %u\n",
+			 u32_get_bits(mac_id_word, ATH12K_HTT_STATS_MAC_ID));
+	len += scnprintf(buf + len, buf_len - len, "total_phy_err_nct = %u\n",
+			 le32_to_cpu(htt_stats_buf->total_phy_err_cnt));
+
+	len += print_array_to_buf(buf, len, "phy_errs", htt_stats_buf->phy_err,
+				  ATH12K_HTT_STATS_PHY_ERR_MAX, "\n\n");
+
+	stats_req->buf_len = len;
+}
+
 static int ath12k_dbg_htt_ext_stats_parse(struct ath12k_base *ab,
 					  u16 tag, u16 len, const void *tag_buf,
 					  void *user_data)
@@ -1552,6 +1866,34 @@ static int ath12k_dbg_htt_ext_stats_parse(struct ath12k_base *ab,
 	case HTT_STATS_TX_DE_COMPL_STATS_TAG:
 		ath12k_htt_print_tx_de_compl_stats_tlv(tag_buf, len, stats_req);
 		break;
+	case HTT_STATS_RX_REFILL_RXDMA_ERR_TAG:
+		htt_print_rx_soc_fw_refill_ring_num_rxdma_err_tlv(tag_buf, len,
+								  stats_req);
+		break;
+	case HTT_STATS_RX_REFILL_REO_ERR_TAG:
+		htt_print_rx_soc_fw_refill_ring_num_reo_err_tlv(tag_buf, len, stats_req);
+		break;
+	case HTT_STATS_RX_PDEV_FW_STATS_PHY_ERR_TAG:
+		htt_print_rx_pdev_fw_stats_phy_err_tlv(tag_buf, len, stats_req);
+		break;
+	case HTT_STATS_RX_PDEV_FW_STATS_TAG:
+		htt_print_rx_pdev_fw_stats_tlv(tag_buf, len, stats_req);
+		break;
+	case HTT_STATS_RX_PDEV_FW_RING_MPDU_ERR_TAG:
+		htt_print_rx_pdev_fw_ring_mpdu_err_tlv(tag_buf, len, stats_req);
+		break;
+	case HTT_STATS_RX_PDEV_FW_MPDU_DROP_TAG:
+		htt_print_rx_pdev_fw_mpdu_drop_tlv(tag_buf, len, stats_req);
+		break;
+	case HTT_STATS_RX_SOC_FW_STATS_TAG:
+		htt_print_rx_soc_fw_stats_tlv(tag_buf, len, stats_req);
+		break;
+	case HTT_STATS_RX_SOC_FW_REFILL_RING_EMPTY_TAG:
+		htt_print_rx_soc_fw_refill_ring_empty_tlv(tag_buf, len, stats_req);
+		break;
+	case HTT_STATS_RX_SOC_FW_REFILL_RING_NUM_REFILL_TAG:
+		htt_print_rx_soc_fw_refill_ring_num_refill_tlv(tag_buf, len, stats_req);
+		break;
 	default:
 		break;
 	}
diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
index d52b26b23e65..c411e7da4e09 100644
--- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
+++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
@@ -7,6 +7,8 @@
 #ifndef DEBUG_HTT_STATS_H
 #define DEBUG_HTT_STATS_H
 
+#include "debugfs.h"
+
 #define ATH12K_HTT_STATS_BUF_SIZE		(1024 * 512)
 #define ATH12K_HTT_STATS_COOKIE_LSB		GENMASK_ULL(31, 0)
 #define ATH12K_HTT_STATS_COOKIE_MSB		GENMASK_ULL(63, 32)
@@ -125,6 +127,7 @@ struct ath12k_htt_extd_stats_msg {
 enum ath12k_dbg_htt_ext_stats_type {
 	ATH12K_DBG_HTT_EXT_STATS_RESET		= 0,
 	ATH12K_DBG_HTT_EXT_STATS_PDEV_TX	= 1,
+	ATH12K_DBG_HTT_EXT_STATS_PDEV_RX	= 2,
 	ATH12K_DBG_HTT_EXT_STATS_PDEV_TX_SCHED	= 4,
 	ATH12K_DBG_HTT_EXT_STATS_PDEV_ERROR	= 5,
 	ATH12K_DBG_HTT_EXT_STATS_PDEV_TQM	= 6,
@@ -151,6 +154,12 @@ enum ath12k_dbg_htt_tlv_tag {
 	HTT_STATS_TX_DE_ENQUEUE_PACKETS_TAG		= 21,
 	HTT_STATS_TX_DE_ENQUEUE_DISCARD_TAG		= 22,
 	HTT_STATS_TX_DE_CMN_TAG				= 23,
+	HTT_STATS_RX_PDEV_FW_STATS_TAG			= 28,
+	HTT_STATS_RX_PDEV_FW_RING_MPDU_ERR_TAG		= 29,
+	HTT_STATS_RX_PDEV_FW_MPDU_DROP_TAG		= 30,
+	HTT_STATS_RX_SOC_FW_STATS_TAG			= 31,
+	HTT_STATS_RX_SOC_FW_REFILL_RING_EMPTY_TAG	= 32,
+	HTT_STATS_RX_SOC_FW_REFILL_RING_NUM_REFILL_TAG	= 33,
 	HTT_STATS_TX_PDEV_SCHEDULER_TXQ_STATS_TAG	= 36,
 	HTT_STATS_TX_SCHED_CMN_TAG			= 37,
 	HTT_STATS_SCHED_TXQ_CMD_POSTED_TAG		= 39,
@@ -161,6 +170,9 @@ enum ath12k_dbg_htt_tlv_tag {
 	HTT_STATS_TX_DE_COMPL_STATS_TAG			= 65,
 	HTT_STATS_WHAL_TX_TAG				= 66,
 	HTT_STATS_TX_PDEV_SIFS_HIST_TAG			= 67,
+	HTT_STATS_RX_PDEV_FW_STATS_PHY_ERR_TAG          = 68,
+	HTT_STATS_RX_REFILL_RXDMA_ERR_TAG               = 77,
+	HTT_STATS_RX_REFILL_REO_ERR_TAG                 = 78,
 	HTT_STATS_SCHED_TXQ_SCHED_ORDER_SU_TAG		= 86,
 	HTT_STATS_SCHED_TXQ_SCHED_INELIGIBILITY_TAG	= 87,
 	HTT_STATS_HW_WAR_TAG				= 89,
@@ -690,4 +702,130 @@ struct ath12k_htt_tx_de_compl_stats_tlv {
 	__le32 tqm_bypass_frame;
 } __packed;
 
+struct ath12k_htt_rx_pdev_fw_stats_tlv {
+	__le32 mac_id_word;
+	__le32 ppdu_recvd;
+	__le32 mpdu_cnt_fcs_ok;
+	__le32 mpdu_cnt_fcs_err;
+	__le32 tcp_msdu_cnt;
+	__le32 tcp_ack_msdu_cnt;
+	__le32 udp_msdu_cnt;
+	__le32 other_msdu_cnt;
+	__le32 fw_ring_mpdu_ind;
+	__le32 fw_ring_mgmt_subtype[IEEE80211_MGMT_FRAME_SUBTYPE_MAX];
+	__le32 fw_ring_ctrl_subtype[IEEE80211_MGMT_FRAME_SUBTYPE_MAX];
+	__le32 fw_ring_mcast_data_msdu;
+	__le32 fw_ring_bcast_data_msdu;
+	__le32 fw_ring_ucast_data_msdu;
+	__le32 fw_ring_null_data_msdu;
+	__le32 fw_ring_mpdu_drop;
+	__le32 ofld_local_data_ind_cnt;
+	__le32 ofld_local_data_buf_recycle_cnt;
+	__le32 drx_local_data_ind_cnt;
+	__le32 drx_local_data_buf_recycle_cnt;
+	__le32 local_nondata_ind_cnt;
+	__le32 local_nondata_buf_recycle_cnt;
+
+	__le32 fw_status_buf_ring_refill_cnt;
+	__le32 fw_status_buf_ring_empty_cnt;
+	__le32 fw_pkt_buf_ring_refill_cnt;
+	__le32 fw_pkt_buf_ring_empty_cnt;
+	__le32 fw_link_buf_ring_refill_cnt;
+	__le32 fw_link_buf_ring_empty_cnt;
+	__le32 host_pkt_buf_ring_refill_cnt;
+	__le32 host_pkt_buf_ring_empty_cnt;
+	__le32 mon_pkt_buf_ring_refill_cnt;
+	__le32 mon_pkt_buf_ring_empty_cnt;
+	__le32 mon_status_buf_ring_refill_cnt;
+	__le32 mon_status_buf_ring_empty_cnt;
+	__le32 mon_desc_buf_ring_refill_cnt;
+	__le32 mon_desc_buf_ring_empty_cnt;
+	__le32 mon_dest_ring_update_cnt;
+	__le32 mon_dest_ring_full_cnt;
+
+	__le32 rx_suspend_cnt;
+	__le32 rx_suspend_fail_cnt;
+	__le32 rx_resume_cnt;
+	__le32 rx_resume_fail_cnt;
+	__le32 rx_ring_switch_cnt;
+	__le32 rx_ring_restore_cnt;
+	__le32 rx_flush_cnt;
+	__le32 rx_recovery_reset_cnt;
+} __packed;
+
+#define ATH12K_HTT_RX_STATS_RXDMA_MAX_ERR	16
+
+struct ath12k_htt_rx_pdev_fw_ring_mpdu_err_tlv {
+	DECLARE_FLEX_ARRAY(__le32, fw_ring_mpdu_err);
+} __packed;
+
+#define ATH12K_HTT_RX_STATS_FW_DROP_REASON_MAX	16
+struct ath12k_htt_rx_pdev_fw_mpdu_drop_tlv {
+	DECLARE_FLEX_ARRAY(__le32, fw_mpdu_drop);
+};
+
+struct ath12k_htt_rx_soc_fw_stats_tlv {
+	__le32 fw_reo_ring_data_msdu;
+	__le32 fw_to_host_data_msdu_bcmc;
+	__le32 fw_to_host_data_msdu_uc;
+	__le32 ofld_remote_data_buf_recycle_cnt;
+	__le32 ofld_remote_free_buf_indication_cnt;
+	__le32 ofld_buf_to_host_data_msdu_uc;
+	__le32 reo_fw_ring_to_host_data_msdu_uc;
+	__le32 wbm_sw_ring_reap;
+	__le32 wbm_forward_to_host_cnt;
+	__le32 wbm_target_recycle_cnt;
+	__le32 target_refill_ring_recycle_cnt;
+} __packed;
+
+#define ATH12K_HTT_RX_STATS_REFILL_MAX_RING	4
+
+struct ath12k_htt_rx_soc_fw_refill_ring_num_refill_tlv {
+	DECLARE_FLEX_ARRAY(__le32, refill_ring_num_refill);
+} __packed;
+
+struct ath12k_htt_rx_soc_fw_refill_ring_empty_tlv {
+	DECLARE_FLEX_ARRAY(__le32, refill_ring_empty_cnt);
+} __packed;
+
+#define ATH12K_HTT_RX_RXDMA_MAX_ERR_CODE	16
+struct ath12k_htt_rx_soc_fw_refill_ring_num_rxdma_err_tlv {
+	DECLARE_FLEX_ARRAY(__le32, rxdma_err);
+} __packed;
+
+enum ath12k_htt_rx_reo_error_code_enum {
+	HTT_RX_REO_QUEUE_DESC_ADDR_ZERO		= 0,
+	HTT_RX_REO_QUEUE_DESC_NOT_VALID		= 1,
+	HTT_RX_AMPDU_IN_NON_BA			= 2,
+	HTT_RX_NON_BA_DUPLICATE			= 3,
+	HTT_RX_BA_DUPLICATE			= 4,
+	HTT_RX_REGULAR_FRAME_2K_JUMP		= 5,
+	HTT_RX_BAR_FRAME_2K_JUMP		= 6,
+	HTT_RX_REGULAR_FRAME_OOR		= 7,
+	HTT_RX_BAR_FRAME_OOR			= 8,
+	HTT_RX_BAR_FRAME_NO_BA_SESSION		= 9,
+	HTT_RX_BAR_FRAME_SN_EQUALS_SSN		= 10,
+	HTT_RX_PN_CHECK_FAILED			= 11,
+	HTT_RX_2K_ERROR_HANDLING_FLAG_SET	= 12,
+	HTT_RX_PN_ERROR_HANDLING_FLAG_SET	= 13,
+	HTT_RX_QUEUE_DESCRIPTOR_BLOCKED_SET	= 14,
+	HTT_RX_REO_ERR_CODE_RVSD		= 15,
+
+	HTT_RX_REO_MAX_ERR_CODE
+};
+
+#define ATH12K_HTT_RX_REO_MAX_ERR_CODE		HTT_RX_REO_MAX_ERR_CODE
+
+struct ath12k_htt_rx_soc_fw_refill_ring_num_reo_err_tlv {
+	DECLARE_FLEX_ARRAY(__le32, reo_err);
+} __packed;
+
+#define ATH12K_HTT_STATS_PHY_ERR_MAX		43
+
+struct ath12k_htt_rx_pdev_fw_stats_phy_err_tlv {
+	__le32 mac_id__word;
+	__le32 total_phy_err_cnt;
+	__le32 phy_err[ATH12K_HTT_STATS_PHY_ERR_MAX];
+} __packed;
+
 #endif
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* RE: [PATCH] wifi: ath12k: Support Rx PDEV HTT stats
  2024-07-25  5:42 [PATCH] wifi: ath12k: Support Rx PDEV HTT stats Ramya Gnanasekar
@ 2024-07-25  6:27 ` david Atkins
  2024-07-31 11:16   ` Kalle Valo
  2024-07-25 17:47 ` [PATCH] wifi: " Jeff Johnson
  1 sibling, 1 reply; 5+ messages in thread
From: david Atkins @ 2024-07-25  6:27 UTC (permalink / raw)
  To: ath12k@lists.infradead.org

Just retested the WCN7850 on systems to see if its working on Wifi-7 for me.

Initial results promising but driver fails after a few minutes, do see 1 giga bit/s for a while with iperf3

Afte checking "iw scan" results I'm only seeing MCS 0-11 for the Wi-Fi 7 access points and no eht entries
 
Looking into the dmesg logs is see this (many lines cut to just ath12k relevant)

[    0.000000] Linux version 6.10.0-rc7-wt-ath+ (root@wifi7-amd) (gcc (Ubuntu 13.2.0-23ubuntu4) 13.2.0, GNU ld (GNU Binutils for Ubuntu) 2.42) #1 SMP PREEMPT_DYNAMIC Mon Jul 22 15:00:18 BST 2024
[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-6.10.0-rc7-wt-ath+ root=UUID=2bd2d7a8-7ae2-4ab9-8905-770c0ad4ba20 ro quiet splash vt.handoff=7
[    0.000000] KERNEL supported cpus:
[    0.000000]   Intel GenuineIntel
[    0.000000]   AMD AuthenticAMD

[    3.357900] ath12k_pci 0000:01:00.0: BAR 0 [mem 0xfc600000-0xfc7fffff 64bit]: assigned
[    3.357916] ath12k_pci 0000:01:00.0: enabling device (0000 -> 0002)
[    3.358191] ath12k_pci 0000:01:00.0: MSI vectors: 16
[    3.358195] ath12k_pci 0000:01:00.0: Hardware name: wcn7850 hw2.0
[    3.386444] NET: Registered PF_QIPCRTR protocol family
[    3.442566] mhi mhi0: Requested to power ON
[    3.442579] mhi mhi0: Power on setup success
[    3.533238] mhi mhi0: Wait for device to enter SBL or Mission mode

[    3.917435] ath12k_pci 0000:01:00.0: chip_id 0x2 chip_family 0x4 board_id 0x10e soc_id 0x40170200
[    3.917441] ath12k_pci 0000:01:00.0: fw_version 0x100301e1 fw_build_timestamp 2023-12-06 04:05 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
[    4.116000] ath12k_pci 0000:01:00.0 wlp1s0: renamed from wlan0


[   13.049675] wlp1s0: required MCSes not supported, disabling EHT
[   13.304272] wlp1s0: authenticate with ac:91:9b:b7:05:b0 (local address=00:03:7f:58:34:42)
[   13.304281] wlp1s0: send auth to ac:91:9b:b7:05:b0 (try 1/3)
[   13.312345] wlp1s0: authenticate with ac:91:9b:b7:05:b0 (local address=00:03:7f:58:34:42)
[   13.312352] wlp1s0: send auth to ac:91:9b:b7:05:b0 (try 1/3)
[   13.314787] wlp1s0: authenticated
[   13.315249] wlp1s0: associate with ac:91:9b:b7:05:b0 (try 1/3)
[   13.321883] wlp1s0: RX AssocResp from ac:91:9b:b7:05:b0 (capab=0x1111 status=0 aid=6)
[   13.334818] wlp1s0: associated

Do I need to use different firmware, I have this.

openwrt@wifi7-amd:/usr/lib/firmware/ath12k/WCN7850/hw2.0$ ls -lt
total 2932
-rw-r--r-- 1 root root 2821564 May  6 09:17 amss.bin.zst
-rw-r--r-- 1 root root   21517 May  6 09:17 board-2.bin.zst
-rw-r--r-- 1 root root  139662 May  6 09:17 m3.bin.zst
-rw-r--r-- 1 root root   10699 May  6 09:17 Notice.txt.zst
openwrt@wifi7-amd:/usr/lib/firmware/ath12k/WCN7850/hw2.0$

David


> -----Original Message-----
> From: ath12k <ath12k-bounces@lists.infradead.org> On Behalf Of Ramya
> Gnanasekar
> Sent: Thursday, July 25, 2024 6:42 AM
> To: ath12k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org; Dinesh Karthikeyan
> <quic_dinek@quicinc.com>; Ramya Gnanasekar
> <quic_rgnanase@quicinc.com>
> Subject: [PATCH] wifi: ath12k: Support Rx PDEV HTT stats
> 
> From: Dinesh Karthikeyan <quic_dinek@quicinc.com>
> 
> Add support to parse and dump the Rx PDEV related stats such as SOC stats,
> PHY error, MPDU error through htt stats type 2.
> 
> Sample output:
> -------------
> echo 2 > /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/htt_stats_type
> cat /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/htt_stats
> 
> HTT_RX_PDEV_FW_STATS_TLV:
> mac_id = 0
> ppdu_recvd = 215
> mpdu_cnt_fcs_ok = 215
> mpdu_cnt_fcs_err = 0
> tcp_msdu_cnt = 0
> tcp_ack_msdu_cnt = 0
> udp_msdu_cnt = 0
> other_msdu_cnt = 215
> fw_ring_mpdu_ind = 215
> fw_ring_mgmt_subtype =  0:0, 1:0, 2:0, 3:0, 4:21, 5:1, 6:0, 7:0, 8:193, 9:0, 10:0,
> 11:0, 12:0, 13:0, 14:0, 15:0 fw_ring_ctrl_subtype =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0,
> 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0 fw_ring_mcast_data_msdu =
> 0 fw_ring_bcast_data_msdu = 0 fw_ring_ucast_data_msdu = 0
> fw_ring_null_data_msdu = 0 fw_ring_mpdu_drop = 0
> ofld_local_data_ind_cnt = 0 ofld_local_data_buf_recycle_cnt = 0
> drx_local_data_ind_cnt = 0 drx_local_data_buf_recycle_cnt = 0
> local_nondata_ind_cnt = 215 local_nondata_buf_recycle_cnt = 215
> fw_status_buf_ring_refill_cnt = 215 fw_status_buf_ring_empty_cnt = 0
> fw_pkt_buf_ring_refill_cnt = 215 fw_pkt_buf_ring_empty_cnt = 0
> fw_link_buf_ring_refill_cnt = 215 fw_link_buf_ring_empty_cnt = 0
> host_pkt_buf_ring_refill_cnt = 0 host_pkt_buf_ring_empty_cnt = 0
> mon_pkt_buf_ring_refill_cnt = 0 mon_pkt_buf_ring_empty_cnt = 0
> mon_status_buf_ring_refill_cnt = 0 mon_status_buf_ring_empty_cnt = 0
> mon_desc_buf_ring_refill_cnt = 0 mon_desc_buf_ring_empty_cnt = 0
> mon_dest_ring_update_cnt = 0 mon_dest_ring_full_cnt = 0 rx_suspend_cnt =
> 0 rx_resume_fail_cnt = 0 rx_ring_switch_cnt = 0 rx_ring_restore_cnt = 0
> rx_flush_cnt = 0 rx_recovery_reset_cnt = 0
> 
> HTT_RX_PDEV_FW_RING_MPDU_ERR_TLV:
> fw_ring_mpdu_err =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0,
> 12:0, 13:0, 14:0, 15:0
> 
> HTT_RX_PDEV_FW_MPDU_DROP_TLV:
> fw_mpdu_drop =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0,
> 13:0, 14:0, 15:0
> 
> HTT_RX_SOC_FW_STATS_TLV:
> fw_reo_ring_data_msdu = 0
> fw_to_host_data_msdu_bcmc = 0
> fw_to_host_data_msdu_uc = 0
> ofld_remote_data_buf_recycle_cnt = 0
> ofld_remote_free_buf_indication_cnt = 0
> ofld_buf_to_host_data_msdu_uc = 0
> reo_fw_ring_to_host_data_msdu_uc = 0
> wbm_sw_ring_reap = 0
> wbm_forward_to_host_cnt = 0
> wbm_target_recycle_cnt = 0
> target_refill_ring_recycle_cnt = 0
> 
> HTT_RX_SOC_FW_REFILL_RING_EMPTY_TLV:
> refill_ring_empty_cnt =  0:0, 1:0, 2:0, 3:0
> 
> HTT_RX_SOC_FW_REFILL_RING_NUM_REFILL_TLV:
> refill_ring_num_refill =  0:0, 1:0, 2:0, 3:0
> 
> HTT_RX_SOC_FW_REFILL_RING_NUM_RXDMA_ERR_TLV:
> rxdma_err =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0,
> 14:0, 15:0
> 
> HTT_RX_SOC_FW_REFILL_RING_NUM_REO_ERR_TLV:
> reo_err =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0,
> 14:0, 15:0
> 
> HTT_RX_PDEV_FW_STATS_PHY_ERR_TLV:
> mac_id_word = 0
> total_phy_err_nct = 0
> phy_errs =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0,
> 14:0, 15:0, 16:0, 17:0, 18:0, 19:0, 20:0, 21:0, 22:0, 23:0, 24:0, 25:0, 26:0, 27:0,
> 28:0, 29:0, 30:0, 31:0, 32:0, 33:0, 34:0, 35:0, 36:0, 37:0, 38:0, 39:0, 40:0, 41:0,
> 42:0
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-
> QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-
> QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> Signed-off-by: Dinesh Karthikeyan <quic_dinek@quicinc.com>
> Signed-off-by: Ramya Gnanasekar <quic_rgnanase@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/debugfs.h     |   2 +
>  .../wireless/ath/ath12k/debugfs_htt_stats.c   | 342 ++++++++++++++++++
>  .../wireless/ath/ath12k/debugfs_htt_stats.h   | 138 +++++++
>  3 files changed, 482 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs.h
> b/drivers/net/wireless/ath/ath12k/debugfs.h
> index 8d64ba03aa9a..00b34e00cdf2 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs.h
> +++ b/drivers/net/wireless/ath/ath12k/debugfs.h
> @@ -7,6 +7,8 @@
>  #ifndef _ATH12K_DEBUGFS_H_
>  #define _ATH12K_DEBUGFS_H_
> 
> +#define IEEE80211_MGMT_FRAME_SUBTYPE_MAX	16
> +
>  #ifdef CONFIG_ATH12K_DEBUGFS
>  void ath12k_debugfs_soc_create(struct ath12k_base *ab);  void
> ath12k_debugfs_soc_destroy(struct ath12k_base *ab); diff --git
> a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> index f1b7e74aefe4..c2b0bb134c11 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> +++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> @@ -1447,6 +1447,320 @@ ath12k_htt_print_tx_de_compl_stats_tlv(const
> void *tag_buf, u16 tag_len,
>  	stats_req->buf_len = len;
>  }
> 
> +static void htt_print_rx_pdev_fw_stats_tlv(const void *tag_buf, u16 tag_len,
> +					   struct debug_htt_stats_req
> *stats_req) {
> +	const struct ath12k_htt_rx_pdev_fw_stats_tlv *htt_stats_buf =
> tag_buf;
> +	u8 *buf = stats_req->buf;
> +	u32 len = stats_req->buf_len;
> +	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
> +	u32 mac_id_word;
> +
> +	if (tag_len < sizeof(*htt_stats_buf))
> +		return;
> +
> +	mac_id_word =  __le32_to_cpu(htt_stats_buf->mac_id_word);
> +
> +	len += scnprintf(buf + len, buf_len - len,
> "HTT_RX_PDEV_FW_STATS_TLV:\n");
> +	len += scnprintf(buf + len, buf_len - len, "mac_id = %d\n",
> +			 u32_get_bits(mac_id_word,
> ATH12K_HTT_STATS_MAC_ID));
> +	len += scnprintf(buf + len, buf_len - len, "ppdu_recvd = %u\n",
> +			 le32_to_cpu(htt_stats_buf->ppdu_recvd));
> +	len += scnprintf(buf + len, buf_len - len, "mpdu_cnt_fcs_ok = %u\n",
> +			 le32_to_cpu(htt_stats_buf->mpdu_cnt_fcs_ok));
> +	len += scnprintf(buf + len, buf_len - len, "mpdu_cnt_fcs_err = %u\n",
> +			 le32_to_cpu(htt_stats_buf->mpdu_cnt_fcs_err));
> +	len += scnprintf(buf + len, buf_len - len, "tcp_msdu_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf->tcp_msdu_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "tcp_ack_msdu_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf->tcp_ack_msdu_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "udp_msdu_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf->udp_msdu_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "other_msdu_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf->other_msdu_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "fw_ring_mpdu_ind = %u\n",
> +			 le32_to_cpu(htt_stats_buf->fw_ring_mpdu_ind));
> +
> +	len += print_array_to_buf(buf, len, "fw_ring_mgmt_subtype",
> +				  htt_stats_buf->fw_ring_mgmt_subtype,
> +				  IEEE80211_MGMT_FRAME_SUBTYPE_MAX,
> "\n");
> +
> +	len += print_array_to_buf(buf, len, "fw_ring_ctrl_subtype",
> +				  htt_stats_buf->fw_ring_ctrl_subtype,
> +				  IEEE80211_MGMT_FRAME_SUBTYPE_MAX,
> "\n");
> +
> +	len += scnprintf(buf + len, buf_len - len, "fw_ring_mcast_data_msdu =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_ring_mcast_data_msdu));
> +	len += scnprintf(buf + len, buf_len - len, "fw_ring_bcast_data_msdu =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_ring_bcast_data_msdu));
> +	len += scnprintf(buf + len, buf_len - len, "fw_ring_ucast_data_msdu =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_ring_ucast_data_msdu));
> +	len += scnprintf(buf + len, buf_len - len, "fw_ring_null_data_msdu =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_ring_null_data_msdu));
> +	len += scnprintf(buf + len, buf_len - len, "fw_ring_mpdu_drop =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf->fw_ring_mpdu_drop));
> +	len += scnprintf(buf + len, buf_len - len, "ofld_local_data_ind_cnt =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >ofld_local_data_ind_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "ofld_local_data_buf_recycle_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >ofld_local_data_buf_recycle_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "drx_local_data_ind_cnt =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >drx_local_data_ind_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "drx_local_data_buf_recycle_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >drx_local_data_buf_recycle_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "local_nondata_ind_cnt =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf->local_nondata_ind_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> "local_nondata_buf_recycle_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >local_nondata_buf_recycle_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> "fw_status_buf_ring_refill_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_status_buf_ring_refill_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> "fw_status_buf_ring_empty_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_status_buf_ring_empty_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "fw_pkt_buf_ring_refill_cnt =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_pkt_buf_ring_refill_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "fw_pkt_buf_ring_empty_cnt
> = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_pkt_buf_ring_empty_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "fw_link_buf_ring_refill_cnt =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_link_buf_ring_refill_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "fw_link_buf_ring_empty_cnt
> = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_link_buf_ring_empty_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "host_pkt_buf_ring_refill_cnt
> = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >host_pkt_buf_ring_refill_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> "host_pkt_buf_ring_empty_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >host_pkt_buf_ring_empty_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "mon_pkt_buf_ring_refill_cnt
> = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >mon_pkt_buf_ring_refill_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> "mon_pkt_buf_ring_empty_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >mon_pkt_buf_ring_empty_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "mon_status_buf_ring_refill_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >mon_status_buf_ring_refill_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> "mon_status_buf_ring_empty_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >mon_status_buf_ring_empty_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> "mon_desc_buf_ring_refill_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >mon_desc_buf_ring_refill_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> "mon_desc_buf_ring_empty_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >mon_desc_buf_ring_empty_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "mon_dest_ring_update_cnt
> = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >mon_dest_ring_update_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "mon_dest_ring_full_cnt =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >mon_dest_ring_full_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "rx_suspend_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf->rx_suspend_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "rx_resume_fail_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf->rx_resume_fail_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "rx_ring_switch_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf->rx_ring_switch_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "rx_ring_restore_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf->rx_ring_restore_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "rx_flush_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf->rx_flush_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "rx_recovery_reset_cnt =
> %u\n\n",
> +			 le32_to_cpu(htt_stats_buf->rx_recovery_reset_cnt));
> +
> +	stats_req->buf_len = len;
> +}
> +
> +static void
> +htt_print_rx_pdev_fw_ring_mpdu_err_tlv(const void *tag_buf, u16 tag_len,
> +				       struct debug_htt_stats_req *stats_req) {
> +	const struct ath12k_htt_rx_pdev_fw_ring_mpdu_err_tlv
> *htt_stats_buf = tag_buf;
> +	u8 *buf = stats_req->buf;
> +	u32 len = stats_req->buf_len;
> +	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
> +	u16 num_elems = min_t(u16, (tag_len >> 2),
> +			      ATH12K_HTT_RX_STATS_RXDMA_MAX_ERR);
> +
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "HTT_RX_PDEV_FW_RING_MPDU_ERR_TLV:\n");
> +
> +	len += print_array_to_buf(buf, len, "fw_ring_mpdu_err",
> +				  htt_stats_buf->fw_ring_mpdu_err,
> +				  num_elems, "\n\n");
> +	stats_req->buf_len = len;
> +}
> +
> +static void
> +htt_print_rx_pdev_fw_mpdu_drop_tlv(const void *tag_buf,
> +				   u16 tag_len,
> +				   struct debug_htt_stats_req *stats_req) {
> +	const struct ath12k_htt_rx_pdev_fw_mpdu_drop_tlv *htt_stats_buf =
> tag_buf;
> +	u8 *buf = stats_req->buf;
> +	u32 len = stats_req->buf_len;
> +	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
> +	u16 num_elems = min_t(u16, (tag_len >> 2),
> +
> ATH12K_HTT_RX_STATS_FW_DROP_REASON_MAX);
> +
> +	len += scnprintf(buf + len, buf_len - len,
> +"HTT_RX_PDEV_FW_MPDU_DROP_TLV:\n");
> +
> +	len += print_array_to_buf(buf, len, "fw_mpdu_drop",
> +				  htt_stats_buf->fw_mpdu_drop,
> +				  num_elems, "\n\n");
> +	stats_req->buf_len = len;
> +}
> +
> +static void
> +htt_print_rx_soc_fw_stats_tlv(const void *tag_buf, u16 tag_len,
> +			      struct debug_htt_stats_req *stats_req) {
> +	const struct ath12k_htt_rx_soc_fw_stats_tlv *htt_stats_buf = tag_buf;
> +	u8 *buf = stats_req->buf;
> +	u32 len = stats_req->buf_len;
> +	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
> +
> +	if (tag_len < sizeof(*htt_stats_buf))
> +		return;
> +
> +	len += scnprintf(buf + len, buf_len - len,
> "HTT_RX_SOC_FW_STATS_TLV:\n");
> +	len += scnprintf(buf + len, buf_len - len, "fw_reo_ring_data_msdu =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_reo_ring_data_msdu));
> +	len += scnprintf(buf + len, buf_len - len,
> "fw_to_host_data_msdu_bcmc = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_to_host_data_msdu_bcmc));
> +	len += scnprintf(buf + len, buf_len - len, "fw_to_host_data_msdu_uc
> = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >fw_to_host_data_msdu_uc));
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "ofld_remote_data_buf_recycle_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >ofld_remote_data_buf_recycle_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "ofld_remote_free_buf_indication_cnt = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >ofld_remote_free_buf_indication_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "ofld_buf_to_host_data_msdu_uc = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >ofld_buf_to_host_data_msdu_uc));
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "reo_fw_ring_to_host_data_msdu_uc = %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >reo_fw_ring_to_host_data_msdu_uc));
> +	len += scnprintf(buf + len, buf_len - len, "wbm_sw_ring_reap = %u\n",
> +			 le32_to_cpu(htt_stats_buf->wbm_sw_ring_reap));
> +	len += scnprintf(buf + len, buf_len - len, "wbm_forward_to_host_cnt =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >wbm_forward_to_host_cnt));
> +	len += scnprintf(buf + len, buf_len - len, "wbm_target_recycle_cnt =
> %u\n",
> +			 le32_to_cpu(htt_stats_buf-
> >wbm_target_recycle_cnt));
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "target_refill_ring_recycle_cnt = %u\n\n",
> +			 le32_to_cpu(htt_stats_buf-
> >target_refill_ring_recycle_cnt));
> +
> +	stats_req->buf_len = len;
> +}
> +
> +static void
> +htt_print_rx_soc_fw_refill_ring_empty_tlv(const void *tag_buf,
> +					  u16 tag_len,
> +					  struct debug_htt_stats_req
> *stats_req) {
> +	const struct ath12k_htt_rx_soc_fw_refill_ring_empty_tlv
> *htt_stats_buf = tag_buf;
> +	u8 *buf = stats_req->buf;
> +	u32 len = stats_req->buf_len;
> +	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
> +	u16 num_elems = min_t(u16, (tag_len >> 2),
> +			      ATH12K_HTT_RX_STATS_REFILL_MAX_RING);
> +
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "HTT_RX_SOC_FW_REFILL_RING_EMPTY_TLV:\n");
> +
> +	len += print_array_to_buf(buf, len, "refill_ring_empty_cnt",
> +				  htt_stats_buf->refill_ring_empty_cnt,
> +				  num_elems, "\n\n");
> +
> +	stats_req->buf_len = len;
> +}
> +
> +static void
> +htt_print_rx_soc_fw_refill_ring_num_refill_tlv(const void *tag_buf,
> +					       u16 tag_len,
> +					       struct debug_htt_stats_req
> *stats_req) {
> +	const struct ath12k_htt_rx_soc_fw_refill_ring_num_refill_tlv
> *htt_stats_buf =
> +
> 	tag_buf;
> +	u8 *buf = stats_req->buf;
> +	u32 len = stats_req->buf_len;
> +	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
> +	u16 num_elems = min_t(u16, (tag_len >> 2),
> +
> ATH12K_HTT_RX_STATS_REFILL_MAX_RING);
> +
> +	len += scnprintf(buf + len, buf_len - len,
> +
> "HTT_RX_SOC_FW_REFILL_RING_NUM_REFILL_TLV:\n");
> +
> +	len += print_array_to_buf(buf, len, "refill_ring_num_refill",
> +			   htt_stats_buf->refill_ring_num_refill,
> +			   num_elems, "\n\n");
> +
> +	stats_req->buf_len = len;
> +}
> +
> +static void
> +htt_print_rx_soc_fw_refill_ring_num_rxdma_err_tlv(const void *tag_buf,
> +						  u16 tag_len,
> +						  struct debug_htt_stats_req
> *stats_req) {
> +	const struct ath12k_htt_rx_soc_fw_refill_ring_num_rxdma_err_tlv
> *htt_stats_buf =
> +		tag_buf;
> +	u8 *buf = stats_req->buf;
> +	u32 len = stats_req->buf_len;
> +	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
> +	u16 num_elems = min_t(u16, (tag_len >> 2),
> +ATH12K_HTT_RX_RXDMA_MAX_ERR_CODE);
> +
> +	len += scnprintf(buf + len, buf_len - len,
> +
> "HTT_RX_SOC_FW_REFILL_RING_NUM_RXDMA_ERR_TLV:\n");
> +
> +	len += print_array_to_buf(buf, len, "rxdma_err", htt_stats_buf-
> >rxdma_err,
> +				  num_elems, "\n\n");
> +
> +	stats_req->buf_len = len;
> +}
> +
> +static void
> +htt_print_rx_soc_fw_refill_ring_num_reo_err_tlv(const void *tag_buf,
> +						u16 tag_len,
> +						struct debug_htt_stats_req
> *stats_req) {
> +	const struct ath12k_htt_rx_soc_fw_refill_ring_num_reo_err_tlv
> *htt_stats_buf =
> +
> 	tag_buf;
> +	u8 *buf = stats_req->buf;
> +	u32 len = stats_req->buf_len;
> +	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
> +	u16 num_elems = min_t(u16, (tag_len >> 2),
> +ATH12K_HTT_RX_REO_MAX_ERR_CODE);
> +
> +	len += scnprintf(buf + len, buf_len - len,
> +
> "HTT_RX_SOC_FW_REFILL_RING_NUM_REO_ERR_TLV:\n");
> +
> +	len += print_array_to_buf(buf, len, "reo_err", htt_stats_buf->reo_err,
> +				  num_elems, "\n\n");
> +
> +	stats_req->buf_len = len;
> +}
> +
> +static void
> +htt_print_rx_pdev_fw_stats_phy_err_tlv(const void *tag_buf, u16 tag_len,
> +				       struct debug_htt_stats_req *stats_req) {
> +	const struct ath12k_htt_rx_pdev_fw_stats_phy_err_tlv *htt_stats_buf
> = tag_buf;
> +	u8 *buf = stats_req->buf;
> +	u32 len = stats_req->buf_len;
> +	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
> +	u32 mac_id_word;
> +
> +	if (tag_len < sizeof(*htt_stats_buf))
> +		return;
> +
> +	mac_id_word = __le32_to_cpu(htt_stats_buf->mac_id__word);
> +
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "HTT_RX_PDEV_FW_STATS_PHY_ERR_TLV:\n");
> +	len += scnprintf(buf + len, buf_len - len, "mac_id_word = %u\n",
> +			 u32_get_bits(mac_id_word,
> ATH12K_HTT_STATS_MAC_ID));
> +	len += scnprintf(buf + len, buf_len - len, "total_phy_err_nct = %u\n",
> +			 le32_to_cpu(htt_stats_buf->total_phy_err_cnt));
> +
> +	len += print_array_to_buf(buf, len, "phy_errs", htt_stats_buf-
> >phy_err,
> +				  ATH12K_HTT_STATS_PHY_ERR_MAX, "\n\n");
> +
> +	stats_req->buf_len = len;
> +}
> +
>  static int ath12k_dbg_htt_ext_stats_parse(struct ath12k_base *ab,
>  					  u16 tag, u16 len, const void
> *tag_buf,
>  					  void *user_data)
> @@ -1552,6 +1866,34 @@ static int ath12k_dbg_htt_ext_stats_parse(struct
> ath12k_base *ab,
>  	case HTT_STATS_TX_DE_COMPL_STATS_TAG:
>  		ath12k_htt_print_tx_de_compl_stats_tlv(tag_buf, len,
> stats_req);
>  		break;
> +	case HTT_STATS_RX_REFILL_RXDMA_ERR_TAG:
> +		htt_print_rx_soc_fw_refill_ring_num_rxdma_err_tlv(tag_buf,
> len,
> +								  stats_req);
> +		break;
> +	case HTT_STATS_RX_REFILL_REO_ERR_TAG:
> +		htt_print_rx_soc_fw_refill_ring_num_reo_err_tlv(tag_buf,
> len, stats_req);
> +		break;
> +	case HTT_STATS_RX_PDEV_FW_STATS_PHY_ERR_TAG:
> +		htt_print_rx_pdev_fw_stats_phy_err_tlv(tag_buf, len,
> stats_req);
> +		break;
> +	case HTT_STATS_RX_PDEV_FW_STATS_TAG:
> +		htt_print_rx_pdev_fw_stats_tlv(tag_buf, len, stats_req);
> +		break;
> +	case HTT_STATS_RX_PDEV_FW_RING_MPDU_ERR_TAG:
> +		htt_print_rx_pdev_fw_ring_mpdu_err_tlv(tag_buf, len,
> stats_req);
> +		break;
> +	case HTT_STATS_RX_PDEV_FW_MPDU_DROP_TAG:
> +		htt_print_rx_pdev_fw_mpdu_drop_tlv(tag_buf, len,
> stats_req);
> +		break;
> +	case HTT_STATS_RX_SOC_FW_STATS_TAG:
> +		htt_print_rx_soc_fw_stats_tlv(tag_buf, len, stats_req);
> +		break;
> +	case HTT_STATS_RX_SOC_FW_REFILL_RING_EMPTY_TAG:
> +		htt_print_rx_soc_fw_refill_ring_empty_tlv(tag_buf, len,
> stats_req);
> +		break;
> +	case HTT_STATS_RX_SOC_FW_REFILL_RING_NUM_REFILL_TAG:
> +		htt_print_rx_soc_fw_refill_ring_num_refill_tlv(tag_buf, len,
> stats_req);
> +		break;
>  	default:
>  		break;
>  	}
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> index d52b26b23e65..c411e7da4e09 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> +++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> @@ -7,6 +7,8 @@
>  #ifndef DEBUG_HTT_STATS_H
>  #define DEBUG_HTT_STATS_H
> 
> +#include "debugfs.h"
> +
>  #define ATH12K_HTT_STATS_BUF_SIZE		(1024 * 512)
>  #define ATH12K_HTT_STATS_COOKIE_LSB		GENMASK_ULL(31, 0)
>  #define ATH12K_HTT_STATS_COOKIE_MSB		GENMASK_ULL(63,
> 32)
> @@ -125,6 +127,7 @@ struct ath12k_htt_extd_stats_msg {  enum
> ath12k_dbg_htt_ext_stats_type {
>  	ATH12K_DBG_HTT_EXT_STATS_RESET		= 0,
>  	ATH12K_DBG_HTT_EXT_STATS_PDEV_TX	= 1,
> +	ATH12K_DBG_HTT_EXT_STATS_PDEV_RX	= 2,
>  	ATH12K_DBG_HTT_EXT_STATS_PDEV_TX_SCHED	= 4,
>  	ATH12K_DBG_HTT_EXT_STATS_PDEV_ERROR	= 5,
>  	ATH12K_DBG_HTT_EXT_STATS_PDEV_TQM	= 6,
> @@ -151,6 +154,12 @@ enum ath12k_dbg_htt_tlv_tag {
>  	HTT_STATS_TX_DE_ENQUEUE_PACKETS_TAG		= 21,
>  	HTT_STATS_TX_DE_ENQUEUE_DISCARD_TAG		= 22,
>  	HTT_STATS_TX_DE_CMN_TAG				= 23,
> +	HTT_STATS_RX_PDEV_FW_STATS_TAG			= 28,
> +	HTT_STATS_RX_PDEV_FW_RING_MPDU_ERR_TAG		= 29,
> +	HTT_STATS_RX_PDEV_FW_MPDU_DROP_TAG		= 30,
> +	HTT_STATS_RX_SOC_FW_STATS_TAG			= 31,
> +	HTT_STATS_RX_SOC_FW_REFILL_RING_EMPTY_TAG	= 32,
> +	HTT_STATS_RX_SOC_FW_REFILL_RING_NUM_REFILL_TAG	= 33,
>  	HTT_STATS_TX_PDEV_SCHEDULER_TXQ_STATS_TAG	= 36,
>  	HTT_STATS_TX_SCHED_CMN_TAG			= 37,
>  	HTT_STATS_SCHED_TXQ_CMD_POSTED_TAG		= 39,
> @@ -161,6 +170,9 @@ enum ath12k_dbg_htt_tlv_tag {
>  	HTT_STATS_TX_DE_COMPL_STATS_TAG			= 65,
>  	HTT_STATS_WHAL_TX_TAG				= 66,
>  	HTT_STATS_TX_PDEV_SIFS_HIST_TAG			= 67,
> +	HTT_STATS_RX_PDEV_FW_STATS_PHY_ERR_TAG          = 68,
> +	HTT_STATS_RX_REFILL_RXDMA_ERR_TAG               = 77,
> +	HTT_STATS_RX_REFILL_REO_ERR_TAG                 = 78,
>  	HTT_STATS_SCHED_TXQ_SCHED_ORDER_SU_TAG		= 86,
>  	HTT_STATS_SCHED_TXQ_SCHED_INELIGIBILITY_TAG	= 87,
>  	HTT_STATS_HW_WAR_TAG				= 89,
> @@ -690,4 +702,130 @@ struct ath12k_htt_tx_de_compl_stats_tlv {
>  	__le32 tqm_bypass_frame;
>  } __packed;
> 
> +struct ath12k_htt_rx_pdev_fw_stats_tlv {
> +	__le32 mac_id_word;
> +	__le32 ppdu_recvd;
> +	__le32 mpdu_cnt_fcs_ok;
> +	__le32 mpdu_cnt_fcs_err;
> +	__le32 tcp_msdu_cnt;
> +	__le32 tcp_ack_msdu_cnt;
> +	__le32 udp_msdu_cnt;
> +	__le32 other_msdu_cnt;
> +	__le32 fw_ring_mpdu_ind;
> +	__le32
> fw_ring_mgmt_subtype[IEEE80211_MGMT_FRAME_SUBTYPE_MAX];
> +	__le32
> fw_ring_ctrl_subtype[IEEE80211_MGMT_FRAME_SUBTYPE_MAX];
> +	__le32 fw_ring_mcast_data_msdu;
> +	__le32 fw_ring_bcast_data_msdu;
> +	__le32 fw_ring_ucast_data_msdu;
> +	__le32 fw_ring_null_data_msdu;
> +	__le32 fw_ring_mpdu_drop;
> +	__le32 ofld_local_data_ind_cnt;
> +	__le32 ofld_local_data_buf_recycle_cnt;
> +	__le32 drx_local_data_ind_cnt;
> +	__le32 drx_local_data_buf_recycle_cnt;
> +	__le32 local_nondata_ind_cnt;
> +	__le32 local_nondata_buf_recycle_cnt;
> +
> +	__le32 fw_status_buf_ring_refill_cnt;
> +	__le32 fw_status_buf_ring_empty_cnt;
> +	__le32 fw_pkt_buf_ring_refill_cnt;
> +	__le32 fw_pkt_buf_ring_empty_cnt;
> +	__le32 fw_link_buf_ring_refill_cnt;
> +	__le32 fw_link_buf_ring_empty_cnt;
> +	__le32 host_pkt_buf_ring_refill_cnt;
> +	__le32 host_pkt_buf_ring_empty_cnt;
> +	__le32 mon_pkt_buf_ring_refill_cnt;
> +	__le32 mon_pkt_buf_ring_empty_cnt;
> +	__le32 mon_status_buf_ring_refill_cnt;
> +	__le32 mon_status_buf_ring_empty_cnt;
> +	__le32 mon_desc_buf_ring_refill_cnt;
> +	__le32 mon_desc_buf_ring_empty_cnt;
> +	__le32 mon_dest_ring_update_cnt;
> +	__le32 mon_dest_ring_full_cnt;
> +
> +	__le32 rx_suspend_cnt;
> +	__le32 rx_suspend_fail_cnt;
> +	__le32 rx_resume_cnt;
> +	__le32 rx_resume_fail_cnt;
> +	__le32 rx_ring_switch_cnt;
> +	__le32 rx_ring_restore_cnt;
> +	__le32 rx_flush_cnt;
> +	__le32 rx_recovery_reset_cnt;
> +} __packed;
> +
> +#define ATH12K_HTT_RX_STATS_RXDMA_MAX_ERR	16
> +
> +struct ath12k_htt_rx_pdev_fw_ring_mpdu_err_tlv {
> +	DECLARE_FLEX_ARRAY(__le32, fw_ring_mpdu_err); } __packed;
> +
> +#define ATH12K_HTT_RX_STATS_FW_DROP_REASON_MAX	16
> +struct ath12k_htt_rx_pdev_fw_mpdu_drop_tlv {
> +	DECLARE_FLEX_ARRAY(__le32, fw_mpdu_drop); };
> +
> +struct ath12k_htt_rx_soc_fw_stats_tlv {
> +	__le32 fw_reo_ring_data_msdu;
> +	__le32 fw_to_host_data_msdu_bcmc;
> +	__le32 fw_to_host_data_msdu_uc;
> +	__le32 ofld_remote_data_buf_recycle_cnt;
> +	__le32 ofld_remote_free_buf_indication_cnt;
> +	__le32 ofld_buf_to_host_data_msdu_uc;
> +	__le32 reo_fw_ring_to_host_data_msdu_uc;
> +	__le32 wbm_sw_ring_reap;
> +	__le32 wbm_forward_to_host_cnt;
> +	__le32 wbm_target_recycle_cnt;
> +	__le32 target_refill_ring_recycle_cnt; } __packed;
> +
> +#define ATH12K_HTT_RX_STATS_REFILL_MAX_RING	4
> +
> +struct ath12k_htt_rx_soc_fw_refill_ring_num_refill_tlv {
> +	DECLARE_FLEX_ARRAY(__le32, refill_ring_num_refill); } __packed;
> +
> +struct ath12k_htt_rx_soc_fw_refill_ring_empty_tlv {
> +	DECLARE_FLEX_ARRAY(__le32, refill_ring_empty_cnt); } __packed;
> +
> +#define ATH12K_HTT_RX_RXDMA_MAX_ERR_CODE	16
> +struct ath12k_htt_rx_soc_fw_refill_ring_num_rxdma_err_tlv {
> +	DECLARE_FLEX_ARRAY(__le32, rxdma_err); } __packed;
> +
> +enum ath12k_htt_rx_reo_error_code_enum {
> +	HTT_RX_REO_QUEUE_DESC_ADDR_ZERO		= 0,
> +	HTT_RX_REO_QUEUE_DESC_NOT_VALID		= 1,
> +	HTT_RX_AMPDU_IN_NON_BA			= 2,
> +	HTT_RX_NON_BA_DUPLICATE			= 3,
> +	HTT_RX_BA_DUPLICATE			= 4,
> +	HTT_RX_REGULAR_FRAME_2K_JUMP		= 5,
> +	HTT_RX_BAR_FRAME_2K_JUMP		= 6,
> +	HTT_RX_REGULAR_FRAME_OOR		= 7,
> +	HTT_RX_BAR_FRAME_OOR			= 8,
> +	HTT_RX_BAR_FRAME_NO_BA_SESSION		= 9,
> +	HTT_RX_BAR_FRAME_SN_EQUALS_SSN		= 10,
> +	HTT_RX_PN_CHECK_FAILED			= 11,
> +	HTT_RX_2K_ERROR_HANDLING_FLAG_SET	= 12,
> +	HTT_RX_PN_ERROR_HANDLING_FLAG_SET	= 13,
> +	HTT_RX_QUEUE_DESCRIPTOR_BLOCKED_SET	= 14,
> +	HTT_RX_REO_ERR_CODE_RVSD		= 15,
> +
> +	HTT_RX_REO_MAX_ERR_CODE
> +};
> +
> +#define ATH12K_HTT_RX_REO_MAX_ERR_CODE
> 	HTT_RX_REO_MAX_ERR_CODE
> +
> +struct ath12k_htt_rx_soc_fw_refill_ring_num_reo_err_tlv {
> +	DECLARE_FLEX_ARRAY(__le32, reo_err);
> +} __packed;
> +
> +#define ATH12K_HTT_STATS_PHY_ERR_MAX		43
> +
> +struct ath12k_htt_rx_pdev_fw_stats_phy_err_tlv {
> +	__le32 mac_id__word;
> +	__le32 total_phy_err_cnt;
> +	__le32 phy_err[ATH12K_HTT_STATS_PHY_ERR_MAX];
> +} __packed;
> +
>  #endif
> --
> 2.17.1
> 



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] wifi: ath12k: Support Rx PDEV HTT stats
  2024-07-25  5:42 [PATCH] wifi: ath12k: Support Rx PDEV HTT stats Ramya Gnanasekar
  2024-07-25  6:27 ` david Atkins
@ 2024-07-25 17:47 ` Jeff Johnson
  1 sibling, 0 replies; 5+ messages in thread
From: Jeff Johnson @ 2024-07-25 17:47 UTC (permalink / raw)
  To: Ramya Gnanasekar, ath12k; +Cc: linux-wireless, Dinesh Karthikeyan

On 7/24/2024 10:42 PM, Ramya Gnanasekar wrote:
> From: Dinesh Karthikeyan <quic_dinek@quicinc.com>
> 
> Add support to parse and dump the Rx PDEV related stats such as
> SOC stats, PHY error, MPDU error through htt stats type 2.
> 
> Sample output:
> -------------
> echo 2 > /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/htt_stats_type
> cat /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/htt_stats
> 
> HTT_RX_PDEV_FW_STATS_TLV:
> mac_id = 0
> ppdu_recvd = 215
> mpdu_cnt_fcs_ok = 215
> mpdu_cnt_fcs_err = 0
> tcp_msdu_cnt = 0
> tcp_ack_msdu_cnt = 0
> udp_msdu_cnt = 0
> other_msdu_cnt = 215
> fw_ring_mpdu_ind = 215
> fw_ring_mgmt_subtype =  0:0, 1:0, 2:0, 3:0, 4:21, 5:1, 6:0, 7:0, 8:193, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0
> fw_ring_ctrl_subtype =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0
> fw_ring_mcast_data_msdu = 0
> fw_ring_bcast_data_msdu = 0
> fw_ring_ucast_data_msdu = 0
> fw_ring_null_data_msdu = 0
> fw_ring_mpdu_drop = 0
> ofld_local_data_ind_cnt = 0
> ofld_local_data_buf_recycle_cnt = 0
> drx_local_data_ind_cnt = 0
> drx_local_data_buf_recycle_cnt = 0
> local_nondata_ind_cnt = 215
> local_nondata_buf_recycle_cnt = 215
> fw_status_buf_ring_refill_cnt = 215
> fw_status_buf_ring_empty_cnt = 0
> fw_pkt_buf_ring_refill_cnt = 215
> fw_pkt_buf_ring_empty_cnt = 0
> fw_link_buf_ring_refill_cnt = 215
> fw_link_buf_ring_empty_cnt = 0
> host_pkt_buf_ring_refill_cnt = 0
> host_pkt_buf_ring_empty_cnt = 0
> mon_pkt_buf_ring_refill_cnt = 0
> mon_pkt_buf_ring_empty_cnt = 0
> mon_status_buf_ring_refill_cnt = 0
> mon_status_buf_ring_empty_cnt = 0
> mon_desc_buf_ring_refill_cnt = 0
> mon_desc_buf_ring_empty_cnt = 0
> mon_dest_ring_update_cnt = 0
> mon_dest_ring_full_cnt = 0
> rx_suspend_cnt = 0
> rx_resume_fail_cnt = 0
> rx_ring_switch_cnt = 0
> rx_ring_restore_cnt = 0
> rx_flush_cnt = 0
> rx_recovery_reset_cnt = 0
> 
> HTT_RX_PDEV_FW_RING_MPDU_ERR_TLV:
> fw_ring_mpdu_err =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0
> 
> HTT_RX_PDEV_FW_MPDU_DROP_TLV:
> fw_mpdu_drop =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0
> 
> HTT_RX_SOC_FW_STATS_TLV:
> fw_reo_ring_data_msdu = 0
> fw_to_host_data_msdu_bcmc = 0
> fw_to_host_data_msdu_uc = 0
> ofld_remote_data_buf_recycle_cnt = 0
> ofld_remote_free_buf_indication_cnt = 0
> ofld_buf_to_host_data_msdu_uc = 0
> reo_fw_ring_to_host_data_msdu_uc = 0
> wbm_sw_ring_reap = 0
> wbm_forward_to_host_cnt = 0
> wbm_target_recycle_cnt = 0
> target_refill_ring_recycle_cnt = 0
> 
> HTT_RX_SOC_FW_REFILL_RING_EMPTY_TLV:
> refill_ring_empty_cnt =  0:0, 1:0, 2:0, 3:0
> 
> HTT_RX_SOC_FW_REFILL_RING_NUM_REFILL_TLV:
> refill_ring_num_refill =  0:0, 1:0, 2:0, 3:0
> 
> HTT_RX_SOC_FW_REFILL_RING_NUM_RXDMA_ERR_TLV:
> rxdma_err =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0
> 
> HTT_RX_SOC_FW_REFILL_RING_NUM_REO_ERR_TLV:
> reo_err =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0
> 
> HTT_RX_PDEV_FW_STATS_PHY_ERR_TLV:
> mac_id_word = 0
> total_phy_err_nct = 0
> phy_errs =  0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0, 13:0, 14:0, 15:0, 16:0, 17:0, 18:0, 19:0, 20:0, 21:0, 22:0, 23:0, 24:0, 25:0, 26:0, 27:0, 28:0, 29:0, 30:0, 31:0, 32:0, 33:0, 34:0, 35:0, 36:0, 37:0, 38:0, 39:0, 40:0, 41:0, 42:0
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> Signed-off-by: Dinesh Karthikeyan <quic_dinek@quicinc.com>
> Signed-off-by: Ramya Gnanasekar <quic_rgnanase@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/debugfs.h     |   2 +
>  .../wireless/ath/ath12k/debugfs_htt_stats.c   | 342 ++++++++++++++++++
>  .../wireless/ath/ath12k/debugfs_htt_stats.h   | 138 +++++++
>  3 files changed, 482 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs.h b/drivers/net/wireless/ath/ath12k/debugfs.h
> index 8d64ba03aa9a..00b34e00cdf2 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs.h
> +++ b/drivers/net/wireless/ath/ath12k/debugfs.h
> @@ -7,6 +7,8 @@
>  #ifndef _ATH12K_DEBUGFS_H_
>  #define _ATH12K_DEBUGFS_H_
>  
> +#define IEEE80211_MGMT_FRAME_SUBTYPE_MAX	16

why define this here given that this header file doesn't need it?

seems this should be defined in debugfs_htt_stats.h since that actually uses it

also seems we should drop "MGMT_" since this is applicable to all frame types,
not just management frames

> +
>  #ifdef CONFIG_ATH12K_DEBUGFS
>  void ath12k_debugfs_soc_create(struct ath12k_base *ab);
>  void ath12k_debugfs_soc_destroy(struct ath12k_base *ab);
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> index f1b7e74aefe4..c2b0bb134c11 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> +++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> @@ -1447,6 +1447,320 @@ ath12k_htt_print_tx_de_compl_stats_tlv(const void *tag_buf, u16 tag_len,
>  	stats_req->buf_len = len;
>  }
>  
...
> +static void
> +htt_print_rx_soc_fw_refill_ring_num_refill_tlv(const void *tag_buf,
> +					       u16 tag_len,
> +					       struct debug_htt_stats_req *stats_req)
> +{
> +	const struct ath12k_htt_rx_soc_fw_refill_ring_num_refill_tlv *htt_stats_buf =
> +									tag_buf;
> +	u8 *buf = stats_req->buf;
> +	u32 len = stats_req->buf_len;
> +	u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
> +	u16 num_elems = min_t(u16, (tag_len >> 2),
> +				    ATH12K_HTT_RX_STATS_REFILL_MAX_RING);

bad alignment? align on min_t(

> +
> +	len += scnprintf(buf + len, buf_len - len,
> +			 "HTT_RX_SOC_FW_REFILL_RING_NUM_REFILL_TLV:\n");
> +
> +	len += print_array_to_buf(buf, len, "refill_ring_num_refill",
> +			   htt_stats_buf->refill_ring_num_refill,
> +			   num_elems, "\n\n");
> +
> +	stats_req->buf_len = len;
> +}
...
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> index d52b26b23e65..c411e7da4e09 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> +++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> @@ -7,6 +7,8 @@
>  #ifndef DEBUG_HTT_STATS_H
>  #define DEBUG_HTT_STATS_H
>  
> +#include "debugfs.h"

is this needed if you move IEEE80211_[MGMT_]FRAME_SUBTYPE_MAX to this file?

just those nit comments from me

/jeff


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] wifi: ath12k: Support Rx PDEV HTT stats
  2024-07-25  6:27 ` david Atkins
@ 2024-07-31 11:16   ` Kalle Valo
  2024-08-02  6:29     ` [PATCH] Wi-Fi: " david Atkins
  0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2024-07-31 11:16 UTC (permalink / raw)
  To: david Atkins; +Cc: ath12k@lists.infradead.org

david Atkins <david@3adesign.co.uk> writes:

> Just retested the WCN7850 on systems to see if its working on Wifi-7 for me.
>
> Initial results promising but driver fails after a few minutes, do see 1 giga bit/s for a while with iperf3

Please start a new thread about your problems, don't hijack an existing
thread.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] Wi-Fi: ath12k: Support Rx PDEV HTT stats
  2024-07-31 11:16   ` Kalle Valo
@ 2024-08-02  6:29     ` david Atkins
  0 siblings, 0 replies; 5+ messages in thread
From: david Atkins @ 2024-08-02  6:29 UTC (permalink / raw)
  To: Kalle Valo; +Cc: ath12k@lists.infradead.org

Will do, messed up that time....


> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Wednesday, July 31, 2024 12:16 PM
> To: david Atkins <david@3adesign.co.uk>
> Cc: ath12k@lists.infradead.org
> Subject: Re: [PATCH] wifi: ath12k: Support Rx PDEV HTT stats
> 
> david Atkins <david@3adesign.co.uk> writes:
> 
> > Just retested the WCN7850 on systems to see if its working on Wifi-7 for me.
> >
> > Initial results promising but driver fails after a few minutes, do see
> > 1 giga bit/s for a while with iperf3
> 
> Please start a new thread about your problems, don't hijack an existing
> thread.
> 
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpat
> ches


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-08-02  6:30 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-25  5:42 [PATCH] wifi: ath12k: Support Rx PDEV HTT stats Ramya Gnanasekar
2024-07-25  6:27 ` david Atkins
2024-07-31 11:16   ` Kalle Valo
2024-08-02  6:29     ` [PATCH] Wi-Fi: " david Atkins
2024-07-25 17:47 ` [PATCH] wifi: " Jeff Johnson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox