From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
<ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS
Date: Tue, 14 May 2024 08:25:11 +0300 [thread overview]
Message-ID: <87cyppdky0.fsf@kernel.org> (raw)
In-Reply-To: <23354bb4-4d12-da14-1764-ea71ab05ff45@quicinc.com> (Karthikeyan Periyasamy's message of "Tue, 14 May 2024 06:37:29 +0530")
Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
> On 5/14/2024 5:01 AM, Jeff Johnson wrote:
>> On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote:
>>> The current value of the MAX_RADIOS define is 3. However, this value is
>>> incorrect as the maximum number of radios supported by all devices does
>>> not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2.
>> Use imperative tense: Therefore, modify ...
>>
>
> Sure, will modify in the next version.
>
>> What is the observed problem, if any, with the current code?
>>
>
> No problem observed but it leads to unnecessary space allocated for
> the hw links in the group and also it gives incorrect perspective to
> the code reader that ath12k support max three radio platform.
Information like this is always good to include in the commit message.
There's less guessing that way.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-05-14 5:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 1:36 [PATCH 0/2] wifi: ath12k: Refactor MAX_RADIOS definition Karthikeyan Periyasamy
2024-05-11 1:36 ` [PATCH 1/2] wifi: ath12k: remove duplicate definition of MAX_RADIOS Karthikeyan Periyasamy
2024-05-13 23:28 ` Jeff Johnson
2024-05-11 1:36 ` [PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS Karthikeyan Periyasamy
2024-05-13 23:31 ` Jeff Johnson
2024-05-14 1:07 ` Karthikeyan Periyasamy
2024-05-14 5:25 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyppdky0.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox