[PATCH 0/2] wifi: ath12k: Refactor MAX_RADIOS definition

[PATCH 0/2] wifi: ath12k: Refactor MAX_RADIOS definition

[Karthikeyan Periyasamy]

Remove the duplicate definition and use the correct max value.

Karthikeyan Periyasamy (2):
  wifi: ath12k: remove duplicate definition of MAX_RADIOS
  wifi: ath12k: use correct MAX_RADIOS

 drivers/net/wireless/ath/ath12k/core.h | 2 --
 drivers/net/wireless/ath/ath12k/wmi.h  | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)


base-commit: 1025c616ee13372f3803b158abb1d87ef368ae3d
-- 
2.34.1

[PATCH 1/2] wifi: ath12k: remove duplicate definition of MAX_RADIOS

[Karthikeyan Periyasamy]

Remove the duplicate definition of MAX_RADIOS from the core header file.

No functional changes, compile tested only.

Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
---
 drivers/net/wireless/ath/ath12k/core.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index bb6c1b562baf..345d47fe63ff 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -180,8 +180,6 @@ struct ath12k_he {
 	u32 heop_param;
 };
 
-#define MAX_RADIOS 3
-
 enum {
 	WMI_HOST_TP_SCALE_MAX   = 0,
 	WMI_HOST_TP_SCALE_50    = 1,
-- 
2.34.1

Re: [PATCH 1/2] wifi: ath12k: remove duplicate definition of MAX_RADIOS

[Jeff Johnson]

On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote:
> Remove the duplicate definition of MAX_RADIOS from the core header file.
> 
> No functional changes, compile tested only.
> 
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>

[PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS

[Karthikeyan Periyasamy]

The current value of the MAX_RADIOS define is 3. However, this value is
incorrect as the maximum number of radios supported by all devices does
not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
---
 drivers/net/wireless/ath/ath12k/wmi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
index 496866673aea..27bec3800bff 100644
--- a/drivers/net/wireless/ath/ath12k/wmi.h
+++ b/drivers/net/wireless/ath/ath12k/wmi.h
@@ -4770,7 +4770,7 @@ struct wmi_probe_tmpl_cmd {
 	__le32 buf_len;
 } __packed;
 
-#define MAX_RADIOS 3
+#define MAX_RADIOS 2
 
 #define WMI_SERVICE_READY_TIMEOUT_HZ (5 * HZ)
 #define WMI_SEND_TIMEOUT_HZ (3 * HZ)
-- 
2.34.1

Re: [PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS

[Jeff Johnson]

On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote:
> The current value of the MAX_RADIOS define is 3. However, this value is
> incorrect as the maximum number of radios supported by all devices does
> not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2.

Use imperative tense: Therefore, modify ...

What is the observed problem, if any, with the current code?

> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/wmi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
> index 496866673aea..27bec3800bff 100644
> --- a/drivers/net/wireless/ath/ath12k/wmi.h
> +++ b/drivers/net/wireless/ath/ath12k/wmi.h
> @@ -4770,7 +4770,7 @@ struct wmi_probe_tmpl_cmd {
>  	__le32 buf_len;
>  } __packed;
>  
> -#define MAX_RADIOS 3
> +#define MAX_RADIOS 2
>  
>  #define WMI_SERVICE_READY_TIMEOUT_HZ (5 * HZ)
>  #define WMI_SEND_TIMEOUT_HZ (3 * HZ)

Re: [PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS

[Karthikeyan Periyasamy]

On 5/14/2024 5:01 AM, Jeff Johnson wrote:
> On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote:
>> The current value of the MAX_RADIOS define is 3. However, this value is
>> incorrect as the maximum number of radios supported by all devices does
>> not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2.
> 
> Use imperative tense: Therefore, modify ...
> 

Sure, will modify in the next version.

> What is the observed problem, if any, with the current code?
> 

No problem observed but it leads to unnecessary space allocated for the 
hw links in the group and also it gives incorrect perspective to the 
code reader that ath12k support max three radio platform.

>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
>> ---
>>   drivers/net/wireless/ath/ath12k/wmi.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
>> index 496866673aea..27bec3800bff 100644
>> --- a/drivers/net/wireless/ath/ath12k/wmi.h
>> +++ b/drivers/net/wireless/ath/ath12k/wmi.h
>> @@ -4770,7 +4770,7 @@ struct wmi_probe_tmpl_cmd {
>>   	__le32 buf_len;
>>   } __packed;
>>   
>> -#define MAX_RADIOS 3
>> +#define MAX_RADIOS 2
>>   
>>   #define WMI_SERVICE_READY_TIMEOUT_HZ (5 * HZ)
>>   #define WMI_SEND_TIMEOUT_HZ (3 * HZ)
> 

-- 
Karthikeyan Periyasamy
--
கார்த்திகேயன் பெரியசாமி

Re: [PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS

[Kalle Valo]

Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:

> On 5/14/2024 5:01 AM, Jeff Johnson wrote:
>> On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote:
>>> The current value of the MAX_RADIOS define is 3. However, this value is
>>> incorrect as the maximum number of radios supported by all devices does
>>> not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2.
>> Use imperative tense: Therefore, modify ...
>> 
>
> Sure, will modify in the next version.
>
>> What is the observed problem, if any, with the current code?
>> 
>
> No problem observed but it leads to unnecessary space allocated for
> the hw links in the group and also it gives incorrect perspective to
> the code reader that ath12k support max three radio platform.

Information like this is always good to include in the commit message.
There's less guessing that way.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches