ath12k-check warnings

[Kalle Valo <kvalo@kernel.org>]

(dropping linux-wireless and changing the title)

Wen Gong <quic_wgong@quicinc.com> writes:

> On 8/25/2023 3:53 PM, Kalle Valo wrote:
>
>> New warning:
>>
>> drivers/net/wireless/ath/ath12k/wmi.c:4199:69: warning: restricted
>> __le32 degrades to integer
>>
>> Remember to ALWAYS run ath12k-check.
>>
>> Patch set to Changes Requested.
>
> I found ath12k-check output many logs, about 5000 lines.
>
> And ath12k-check only has one item in CHECKPATCH_IGNORE, it does not 
> have the other items which
>
> existed in ath10k-check/ath11k-check, so ath12k-check output many info
>
> "struct  should normally be const"/"networking block comments don't use 
> an empty /* line, use /* Comment..."/.
>
> Also it print many "note: in included file ..." by sparse.
>
>
> May I change ath12k-check with diff below and use "ath12k-check | grep 
> -v "note: in included file"" for the patch check?
>
> wgong@wgong-Latitude-E6430:~/opensource/kernel/ath$ ./ath12k-check --version
> /home/wgong/opensource/kernel/ath/./ath12k-check:32: DeprecationWarning: 
> The distutils package is deprecated and slated for removal in Python 
> 3.12. Use setuptools or check PEP 632 for potential alternatives
>    import distutils.spawn
> ath12k-check (md5sum 194c6d6c4bad47f9780fe22541f2f68c)
>
> gcc:            gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
> sparse:         0.6.4 (Ubuntu: 0.6.4-2)
> checkpatch.pl:  Version: 0.32 (md5sum b169dcb45a7f32bd19b128e08288e9cc)
> gtags:          gtags (Global) 6.6.7

I assume this is because you are using an old version of checkpatch.pl.
I forgot to update the commit id in ath1?k-check scripts but I fixed it
now:

https://github.com/qca/qca-swiss-army-knife/commit/27d9574ce670d759681b662e380a826ca6106e48

This is the correct version of checkpatch.pl you should be using (also
printed in --help):

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl?id=362173572a4018e9c8e39c616823189c41d39d41

Did that fix the issue?

I also added a check to make sure that I don't forget to update the
commit id in the future:

https://github.com/qca/qca-swiss-army-knife/commit/c880314adbb1006184265f002016ec3f87bef40d

Please always report any issues you have with ath12k-check. You should
see no warnings in output, otherwise something is wrong.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k