public inbox for ath12k@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v2] wifi: ath12k: enable 320 MHz bandwidth for 6 GHz band in EHT PHY capbility for WCN7850
@ 2023-08-24  2:54 Wen Gong
  2023-08-24  4:22 ` Jeff Johnson
  2023-08-25  7:53 ` Kalle Valo
  0 siblings, 2 replies; 8+ messages in thread
From: Wen Gong @ 2023-08-24  2:54 UTC (permalink / raw)
  To: ath12k; +Cc: linux-wireless, quic_wgong

320 MHz bandwidth is reported only for single PHY mode for WCN7850, get it
from WMI_HOST_HW_MODE_SINGLE ath12k_wmi_caps_ext_params and report it for
6 GHz band.

After this patch, "iw list" show 320MHz support for WCN7850:
EHT Iftypes: managed
        EHT PHY Capabilities: (0xe26f090010768800):
                320MHz in 6GHz Supported
        EHT bw=320 MHz, max NSS for MCS 8-9: Rx=0, Tx=0
        EHT bw=320 MHz, max NSS for MCS 10-11: Rx=0, Tx=0
        EHT bw=320 MHz, max NSS for MCS 12-13: Rx=0, Tx=0

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4

Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
---
v2: change eht_cap_phy_info_5G to eht_cap_phy_info_5ghz.

 drivers/net/wireless/ath/ath12k/wmi.c | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c
index 9ed33e2d6da0..824c5d777ee6 100644
--- a/drivers/net/wireless/ath/ath12k/wmi.c
+++ b/drivers/net/wireless/ath/ath12k/wmi.c
@@ -4148,7 +4148,11 @@ static void ath12k_wmi_eht_caps_parse(struct ath12k_pdev *pdev, u32 band,
 				       __le32 cap_info_internal)
 {
 	struct ath12k_band_cap *cap_band = &pdev->cap.band[band];
-	u8 i;
+	u8 i, support_320mhz;
+
+	if (band == NL80211_BAND_6GHZ)
+		support_320mhz = cap_band->eht_cap_phy_info[0] &
+					IEEE80211_EHT_PHY_CAP0_320MHZ_IN_6GHZ;
 
 	for (i = 0; i < WMI_MAX_EHTCAP_MAC_SIZE; i++)
 		cap_band->eht_cap_mac_info[i] = le32_to_cpu(cap_mac_info[i]);
@@ -4156,6 +4160,9 @@ static void ath12k_wmi_eht_caps_parse(struct ath12k_pdev *pdev, u32 band,
 	for (i = 0; i < WMI_MAX_EHTCAP_PHY_SIZE; i++)
 		cap_band->eht_cap_phy_info[i] = le32_to_cpu(cap_phy_info[i]);
 
+	if (band == NL80211_BAND_6GHZ)
+		cap_band->eht_cap_phy_info[0] |= support_320mhz;
+
 	cap_band->eht_mcs_20_only = le32_to_cpu(supp_mcs[0]);
 	cap_band->eht_mcs_80 = le32_to_cpu(supp_mcs[1]);
 	if (band != NL80211_BAND_2GHZ) {
@@ -4177,10 +4184,20 @@ ath12k_wmi_tlv_mac_phy_caps_ext_parse(struct ath12k_base *ab,
 				      const struct ath12k_wmi_caps_ext_params *caps,
 				      struct ath12k_pdev *pdev)
 {
+	struct ath12k_band_cap *cap_band;
 	u32 bands;
 	int i;
+	u8 support_320mhz;
 
 	if (ab->hw_params->single_pdev_only) {
+		if (caps->hw_mode_id == WMI_HOST_HW_MODE_SINGLE) {
+			support_320mhz = caps->eht_cap_phy_info_5ghz[0] &
+				IEEE80211_EHT_PHY_CAP0_320MHZ_IN_6GHZ;
+			cap_band = &pdev->cap.band[NL80211_BAND_6GHZ];
+			cap_band->eht_cap_phy_info[0] |= support_320mhz;
+			return 0;
+		}
+
 		for (i = 0; i < ab->fw_pdev_count; i++) {
 			struct ath12k_fw_pdev *fw_pdev = &ab->fw_pdev[i];
 
@@ -4236,7 +4253,8 @@ static int ath12k_wmi_tlv_mac_phy_caps_ext(struct ath12k_base *ab, u16 tag,
 		return -EPROTO;
 
 	if (ab->hw_params->single_pdev_only) {
-		if (ab->wmi_ab.preferred_hw_mode != le32_to_cpu(caps->hw_mode_id))
+		if (ab->wmi_ab.preferred_hw_mode != le32_to_cpu(caps->hw_mode_id) &&
+		    caps->hw_mode_id != WMI_HOST_HW_MODE_SINGLE)
 			return 0;
 	} else {
 		for (i = 0; i < ab->num_radios; i++) {

base-commit: 3f257461ab0ab19806bae2bfde4c3cd88dbf050e
-- 
2.40.1


-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] wifi: ath12k: enable 320 MHz bandwidth for 6 GHz band in EHT PHY capbility for WCN7850
  2023-08-24  2:54 [PATCH v2] wifi: ath12k: enable 320 MHz bandwidth for 6 GHz band in EHT PHY capbility for WCN7850 Wen Gong
@ 2023-08-24  4:22 ` Jeff Johnson
  2023-08-25  7:53 ` Kalle Valo
  1 sibling, 0 replies; 8+ messages in thread
From: Jeff Johnson @ 2023-08-24  4:22 UTC (permalink / raw)
  To: Wen Gong, ath12k; +Cc: linux-wireless

 > wifi: ath12k: enable 320 MHz bandwidth for 6 GHz band in EHT PHY 
capbility for WCN7850

s/capbility/capability/

Kalle can make that change when he submits to -pending

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] wifi: ath12k: enable 320 MHz bandwidth for 6 GHz band in EHT PHY capbility for WCN7850
  2023-08-24  2:54 [PATCH v2] wifi: ath12k: enable 320 MHz bandwidth for 6 GHz band in EHT PHY capbility for WCN7850 Wen Gong
  2023-08-24  4:22 ` Jeff Johnson
@ 2023-08-25  7:53 ` Kalle Valo
  2023-08-28  6:09   ` Wen Gong
  1 sibling, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2023-08-25  7:53 UTC (permalink / raw)
  To: Wen Gong; +Cc: ath12k, linux-wireless, quic_wgong

Wen Gong <quic_wgong@quicinc.com> wrote:

> 320 MHz bandwidth is reported only for single PHY mode for WCN7850, get it
> from WMI_HOST_HW_MODE_SINGLE ath12k_wmi_caps_ext_params and report it for
> 6 GHz band.
> 
> After this patch, "iw list" show 320MHz support for WCN7850:
> EHT Iftypes: managed
>         EHT PHY Capabilities: (0xe26f090010768800):
>                 320MHz in 6GHz Supported
>         EHT bw=320 MHz, max NSS for MCS 8-9: Rx=0, Tx=0
>         EHT bw=320 MHz, max NSS for MCS 10-11: Rx=0, Tx=0
>         EHT bw=320 MHz, max NSS for MCS 12-13: Rx=0, Tx=0
> 
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
> 
> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

New warning:

drivers/net/wireless/ath/ath12k/wmi.c:4199:69: warning: restricted __le32 degrades to integer

Remember to ALWAYS run ath12k-check.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230824025432.19406-1-quic_wgong@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] wifi: ath12k: enable 320 MHz bandwidth for 6 GHz band in EHT PHY capbility for WCN7850
  2023-08-25  7:53 ` Kalle Valo
@ 2023-08-28  6:09   ` Wen Gong
  2023-09-06 14:04     ` ath12k-check warnings Kalle Valo
  0 siblings, 1 reply; 8+ messages in thread
From: Wen Gong @ 2023-08-28  6:09 UTC (permalink / raw)
  To: Kalle Valo; +Cc: ath12k, linux-wireless

On 8/25/2023 3:53 PM, Kalle Valo wrote:
> Wen Gong <quic_wgong@quicinc.com> wrote:
>
>> 320 MHz bandwidth is reported only for single PHY mode for WCN7850, get it
>> from WMI_HOST_HW_MODE_SINGLE ath12k_wmi_caps_ext_params and report it for
>> 6 GHz band.
>>
>> After this patch, "iw list" show 320MHz support for WCN7850:
>> EHT Iftypes: managed
>>          EHT PHY Capabilities: (0xe26f090010768800):
>>                  320MHz in 6GHz Supported
>>          EHT bw=320 MHz, max NSS for MCS 8-9: Rx=0, Tx=0
>>          EHT bw=320 MHz, max NSS for MCS 10-11: Rx=0, Tx=0
>>          EHT bw=320 MHz, max NSS for MCS 12-13: Rx=0, Tx=0
>>
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
>>
>> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> New warning:
>
> drivers/net/wireless/ath/ath12k/wmi.c:4199:69: warning: restricted __le32 degrades to integer
>
> Remember to ALWAYS run ath12k-check.
>
> Patch set to Changes Requested.

I found ath12k-check output many logs, about 5000 lines.

And ath12k-check only has one item in CHECKPATCH_IGNORE, it does not 
have the other items which

existed in ath10k-check/ath11k-check, so ath12k-check output many info

"struct  should normally be const"/"networking block comments don't use 
an empty /* line, use /* Comment..."/.

Also it print many "note: in included file ..." by sparse.


May I change ath12k-check with diff below and use "ath12k-check | grep 
-v "note: in included file"" for the patch check?

wgong@wgong-Latitude-E6430:~/opensource/kernel/ath$ ./ath12k-check --version
/home/wgong/opensource/kernel/ath/./ath12k-check:32: DeprecationWarning: 
The distutils package is deprecated and slated for removal in Python 
3.12. Use setuptools or check PEP 632 for potential alternatives
   import distutils.spawn
ath12k-check (md5sum 194c6d6c4bad47f9780fe22541f2f68c)

gcc:            gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
sparse:         0.6.4 (Ubuntu: 0.6.4-2)
checkpatch.pl:  Version: 0.32 (md5sum b169dcb45a7f32bd19b128e08288e9cc)
gtags:          gtags (Global) 6.6.7

wgong@wgong-Latitude-E6430:~/opensource/kernel/ath$ ./ath12k-check | 
grep -v "note: in included file"
/home/wgong/opensource/kernel/ath/./ath12k-check:32: DeprecationWarning: 
The distutils package is deprecated and slated for removal in Python 
3.12. Use setuptools or check PEP 632 for potential alternatives
   import distutils.spawn
drivers/net/wireless/ath/ath12k/wmi.c: In function 
'ath12k_wmi_tlv_mac_phy_caps_ext_parse':
drivers/net/wireless/ath/ath12k/wmi.c:4197:69: warning: restricted 
__le32 degrades to integer
drivers/net/wireless/ath/ath12k/dp_rx.c:2110: space required after that 
close brace '}'

diff --git a/tools/scripts/ath12k/ath12k-check 
b/tools/scripts/ath12k/ath12k-check
index 7112fd9..3035b34 100755
--- a/tools/scripts/ath12k/ath12k-check
+++ b/tools/scripts/ath12k/ath12k-check
@@ -41,10 +41,48 @@ FILTER_REGEXP = r'/ath'

  IGNORE_FILES = []

-CHECKPATCH_IGNORE = [
-    # some find extra parentheses helpful so ignore the warnings
-    'UNNECESSARY_PARENTHESES',
-]
+CHECKPATCH_IGNORE = ['MSLEEP',
+                     'USLEEP_RANGE',
+                     'PRINTK_WITHOUT_KERN_LEVEL',
+
+                     # ath10k does not follow networking comment style
+                     'NETWORKING_BLOCK_COMMENT_STYLE',
+
+                     'LINUX_VERSION_CODE',
+                     'COMPLEX_MACRO',
+                     'PREFER_DEV_LEVEL',
+                     'PREFER_PR_LEVEL',
+                     'COMPARISON_TO_NULL',
+                     'BIT_MACRO',
+                     'CONSTANT_COMPARISON',
+                     'MACRO_WITH_FLOW_CONTROL',
+
+                     # Spams hundreds of lines useless 'struct should
+                     # normally be const' warnings, maybe a bug in
+                     # checkpatch?
+                     'CONST_STRUCT',
+
+                     # TODO: look like valid warnings, investigate
+                     'MACRO_ARG_REUSE',
+                     'OPEN_ENDED_LINE',
+                     'FUNCTION_ARGUMENTS',
+                     'CONFIG_DESCRIPTION',
+                     'ASSIGNMENT_CONTINUATIONS',
+                     'UNNECESSARY_PARENTHESES',
+
+                     # Not sure if these really useful warnings,
+                     # disable for now.
+                     'MACRO_ARG_PRECEDENCE',
+
+                     'BOOL_MEMBER',
+
+                     # TODO: ath11k uses volatile for now, fix it
+                     'VOLATILE',
+
+                     # TODO: document all DT usage in ath11k
+                     'UNDOCUMENTED_DT_STRING',
+                     ]
+

  CHECKPATCH_OPTS = ['--strict', '-q', '--terse', '--no-summary',
                     '--max-line-length=90', '--show-types']

>

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* ath12k-check warnings
  2023-08-28  6:09   ` Wen Gong
@ 2023-09-06 14:04     ` Kalle Valo
  2023-09-26  2:32       ` Wen Gong
  0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2023-09-06 14:04 UTC (permalink / raw)
  To: Wen Gong; +Cc: ath12k

(dropping linux-wireless and changing the title)

Wen Gong <quic_wgong@quicinc.com> writes:

> On 8/25/2023 3:53 PM, Kalle Valo wrote:
>
>> New warning:
>>
>> drivers/net/wireless/ath/ath12k/wmi.c:4199:69: warning: restricted
>> __le32 degrades to integer
>>
>> Remember to ALWAYS run ath12k-check.
>>
>> Patch set to Changes Requested.
>
> I found ath12k-check output many logs, about 5000 lines.
>
> And ath12k-check only has one item in CHECKPATCH_IGNORE, it does not 
> have the other items which
>
> existed in ath10k-check/ath11k-check, so ath12k-check output many info
>
> "struct  should normally be const"/"networking block comments don't use 
> an empty /* line, use /* Comment..."/.
>
> Also it print many "note: in included file ..." by sparse.
>
>
> May I change ath12k-check with diff below and use "ath12k-check | grep 
> -v "note: in included file"" for the patch check?
>
> wgong@wgong-Latitude-E6430:~/opensource/kernel/ath$ ./ath12k-check --version
> /home/wgong/opensource/kernel/ath/./ath12k-check:32: DeprecationWarning: 
> The distutils package is deprecated and slated for removal in Python 
> 3.12. Use setuptools or check PEP 632 for potential alternatives
>    import distutils.spawn
> ath12k-check (md5sum 194c6d6c4bad47f9780fe22541f2f68c)
>
> gcc:            gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
> sparse:         0.6.4 (Ubuntu: 0.6.4-2)
> checkpatch.pl:  Version: 0.32 (md5sum b169dcb45a7f32bd19b128e08288e9cc)
> gtags:          gtags (Global) 6.6.7

I assume this is because you are using an old version of checkpatch.pl.
I forgot to update the commit id in ath1?k-check scripts but I fixed it
now:

https://github.com/qca/qca-swiss-army-knife/commit/27d9574ce670d759681b662e380a826ca6106e48

This is the correct version of checkpatch.pl you should be using (also
printed in --help):

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl?id=362173572a4018e9c8e39c616823189c41d39d41

Did that fix the issue?

I also added a check to make sure that I don't forget to update the
commit id in the future:

https://github.com/qca/qca-swiss-army-knife/commit/c880314adbb1006184265f002016ec3f87bef40d

Please always report any issues you have with ath12k-check. You should
see no warnings in output, otherwise something is wrong.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: ath12k-check warnings
  2023-09-06 14:04     ` ath12k-check warnings Kalle Valo
@ 2023-09-26  2:32       ` Wen Gong
  2023-09-26  4:42         ` Kalle Valo
  0 siblings, 1 reply; 8+ messages in thread
From: Wen Gong @ 2023-09-26  2:32 UTC (permalink / raw)
  To: Kalle Valo; +Cc: ath12k

On 9/6/2023 10:04 PM, Kalle Valo wrote:
> (dropping linux-wireless and changing the title)
>
> Wen Gong <quic_wgong@quicinc.com> writes:
>
>> On 8/25/2023 3:53 PM, Kalle Valo wrote:
>>
>>> New warning:
>>>
>>> drivers/net/wireless/ath/ath12k/wmi.c:4199:69: warning: restricted
>>> __le32 degrades to integer
>>>
>>> Remember to ALWAYS run ath12k-check.
>>>
>>> Patch set to Changes Requested.
>> I found ath12k-check output many logs, about 5000 lines.
>>
>> And ath12k-check only has one item in CHECKPATCH_IGNORE, it does not
>> have the other items which
>>
>> existed in ath10k-check/ath11k-check, so ath12k-check output many info
>>
>> "struct  should normally be const"/"networking block comments don't use
>> an empty /* line, use /* Comment..."/.
>>
>> Also it print many "note: in included file ..." by sparse.
>>
>>
>> May I change ath12k-check with diff below and use "ath12k-check | grep
>> -v "note: in included file"" for the patch check?
>>
>> wgong@wgong-Latitude-E6430:~/opensource/kernel/ath$ ./ath12k-check --version
>> /home/wgong/opensource/kernel/ath/./ath12k-check:32: DeprecationWarning:
>> The distutils package is deprecated and slated for removal in Python
>> 3.12. Use setuptools or check PEP 632 for potential alternatives
>>     import distutils.spawn
>> ath12k-check (md5sum 194c6d6c4bad47f9780fe22541f2f68c)
>>
>> gcc:            gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
>> sparse:         0.6.4 (Ubuntu: 0.6.4-2)
>> checkpatch.pl:  Version: 0.32 (md5sum b169dcb45a7f32bd19b128e08288e9cc)
>> gtags:          gtags (Global) 6.6.7
> I assume this is because you are using an old version of checkpatch.pl.
> I forgot to update the commit id in ath1?k-check scripts but I fixed it
> now:
>
> https://github.com/qca/qca-swiss-army-knife/commit/27d9574ce670d759681b662e380a826ca6106e48
>
> This is the correct version of checkpatch.pl you should be using (also
> printed in --help):
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl?id=362173572a4018e9c8e39c616823189c41d39d41
>
> Did that fix the issue?

Sorry for delay since subject title changed.

I updated to latest commit of qca-swiss-army-knife (9a16a4a - 
ath11k-check: verify checkpatch.pl md5sum),

and it still print about ~500 "note: in included file ...", they are 
print by sparse, not by checkpatch.pl.

wgong@wgong-Latitude-E6430:~/opensource/kernel/ath$ ./ath12k-check
/home/wgong/opensource/kernel/ath/./ath12k-check:32: DeprecationWarning: 
The distutils package is deprecated and slated for removal in Python 
3.12. Use setuptools or check PEP 632 for potential alternatives
   import distutils.spawn
drivers/net/wireless/ath/ath12k/hal_tx.c: note: in included file 
(through include/linux/bitops.h, include/linux/kernel.h, 
include/linux/interrupt.h, drivers/net/wireless/ath/ath12k/core.h, 
drivers/net/wireless/ath/ath12k/hal_desc.h):
drivers/net/wireless/ath/ath12k/hal_tx.c: note: in included file 
(through include/linux/bitops.h, include/linux/kernel.h, 
include/linux/interrupt.h, drivers/net/wireless/ath/ath12k/core.h, 
drivers/net/wireless/ath/ath12k/hal_desc.h):
...
...
drivers/net/wireless/ath/ath12k/dp_mon.c: note: in included file 
(through include/linux/bitops.h, include/linux/kernel.h, 
include/linux/interrupt.h, drivers/net/wireless/ath/ath12k/core.h, 
drivers/net/wireless/ath/ath12k/dp_mon.h):
drivers/net/wireless/ath/ath12k/dp_mon.c: note: in included file 
(through arch/x86/include/asm/bitops.h, include/linux/bitops.h, 
include/linux/kernel.h, include/linux/interrupt.h, 
drivers/net/wireless/ath/ath12k/core.h, ...):

wgong@wgong-Latitude-E6430:~/opensource/kernel/ath$ ./ath12k-check --version
/home/wgong/opensource/kernel/ath/./ath12k-check:32: DeprecationWarning: 
The distutils package is deprecated and slated for removal in Python 
3.12. Use setuptools or check PEP 632 for potential alternatives
   import distutils.spawn
ath12k-check (md5sum a934e18a6f7c439e351695268471156c)

gcc:            gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
sparse:         0.6.4 (Ubuntu: 0.6.4-2)
checkpatch.pl:  Version: 0.32 (md5sum 47ef327d772c156e53a36597723fc781)
gtags:          gtags (Global) 6.6.7

wgong@wgong-Latitude-E6430:~/opensource/kernel/ath$ ./ath12k-check | 
grep -c "note: in included file"
/home/wgong/opensource/kernel/ath/./ath12k-check:32: DeprecationWarning: 
The distutils package is deprecated and slated for removal in Python 
3.12. Use setuptools or check PEP 632 for potential alternatives
   import distutils.spawn
441
wgong@wgong-Latitude-E6430:~/opensource/kernel/ath$ ./ath11k-check | 
grep -c "note: in included file"
/home/wgong/opensource/kernel/ath/./ath11k-check:32: DeprecationWarning: 
The distutils package is deprecated and slated for removal in Python 
3.12. Use setuptools or check PEP 632 for potential alternatives
   import distutils.spawn
567

>
> I also added a check to make sure that I don't forget to update the
> commit id in the future:
>
> https://github.com/qca/qca-swiss-army-knife/commit/c880314adbb1006184265f002016ec3f87bef40d
>
> Please always report any issues you have with ath12k-check. You should
> see no warnings in output, otherwise something is wrong.
>

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: ath12k-check warnings
  2023-09-26  2:32       ` Wen Gong
@ 2023-09-26  4:42         ` Kalle Valo
  2023-09-27  7:09           ` Kalle Valo
  0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2023-09-26  4:42 UTC (permalink / raw)
  To: Wen Gong; +Cc: ath12k

Wen Gong <quic_wgong@quicinc.com> writes:

> I updated to latest commit of qca-swiss-army-knife (9a16a4a -
> ath11k-check: verify checkpatch.pl md5sum),
>
> and it still print about ~500 "note: in included file ...", they are
> print by sparse, not by checkpatch.pl.

Ah, I missed that these are coming from sparse.

> wgong@wgong-Latitude-E6430:~/opensource/kernel/ath$ ./ath12k-check --version
> /home/wgong/opensource/kernel/ath/./ath12k-check:32:
> DeprecationWarning: The distutils package is deprecated and slated for
> removal in Python 3.12. Use setuptools or check PEP 632 for potential
> alternatives
>   import distutils.spawn
> ath12k-check (md5sum a934e18a6f7c439e351695268471156c)
>
> gcc:            gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
> sparse:         0.6.4 (Ubuntu: 0.6.4-2)
> checkpatch.pl:  Version: 0.32 (md5sum 47ef327d772c156e53a36597723fc781)
> gtags:          gtags (Global) 6.6.7

I guess your sparse is too old. I'm using:

$ ath12k-check --version
ath12k-check (md5sum a934e18a6f7c439e351695268471156c)

gcc:		gcc (Debian 12.2.0-14) 12.2.0
sparse:		v0.6.4-39-gce1a6720f69e
checkpatch.pl:	Version: 0.32 (md5sum 47ef327d772c156e53a36597723fc781)
gtags:		gtags (Global) 6.6.9

I recommend installing sparse directly from git, it's quite easy:

https://git.kernel.org/pub/scm/devel/sparse/sparse.git/

> /home/wgong/opensource/kernel/ath/./ath12k-check:32:
> DeprecationWarning: The distutils package is deprecated and slated for
> removal in Python 3.12. Use setuptools or check PEP 632 for potential
> alternatives
>   import distutils.spawn

I don't see this warning on Debian 12 but I'll need to fix that as well.
But this is what I hate with python, they are always depracating
something and it's extra work for us.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: ath12k-check warnings
  2023-09-26  4:42         ` Kalle Valo
@ 2023-09-27  7:09           ` Kalle Valo
  0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2023-09-27  7:09 UTC (permalink / raw)
  To: Wen Gong; +Cc: ath12k

Kalle Valo <kvalo@kernel.org> writes:

>> /home/wgong/opensource/kernel/ath/./ath12k-check:32:
>> DeprecationWarning: The distutils package is deprecated and slated for
>> removal in Python 3.12. Use setuptools or check PEP 632 for potential
>> alternatives
>>   import distutils.spawn
>
> I don't see this warning on Debian 12 but I'll need to fix that as well.
> But this is what I hate with python, they are always depracating
> something and it's extra work for us.

I fixed this now:

https://github.com/qca/qca-swiss-army-knife/commit/2bd53768fa273f78ed044aee9ac88daf2ccc1682

Please let me know if you still see warnings from ath12k-check or
ath11k-check. With ath.git master branch you should get no warnings,
otherwise something is wrong.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-09-27  7:09 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-24  2:54 [PATCH v2] wifi: ath12k: enable 320 MHz bandwidth for 6 GHz band in EHT PHY capbility for WCN7850 Wen Gong
2023-08-24  4:22 ` Jeff Johnson
2023-08-25  7:53 ` Kalle Valo
2023-08-28  6:09   ` Wen Gong
2023-09-06 14:04     ` ath12k-check warnings Kalle Valo
2023-09-26  2:32       ` Wen Gong
2023-09-26  4:42         ` Kalle Valo
2023-09-27  7:09           ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox