ath12k: driver does not show tx bitrate

ath12k: driver does not show tx bitrate

[Owen Mesh.]

Dear Sirs,

I found a small bug in ath12k driver with wcn7850 adapter.
ath12k driver does not show tx bitrate.

Platform:
11th Gen Intel(R) Core(TM) i9-11900K @ 3.50GHz

System: Linux 6.8.1-060801-generic #202403151937 SMP PREEMPT_DYNAMIC
Fri Mar 15 19:52:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
(Ubuntu 23.10)

wcn7850 adapter output:
iw dev wlp6s0 link
Connected to d4:da:21:a8:06:7e (on wlp6s0)
    SSID: NETGEAR65
    freq: 5805.0
    RX: 146600 bytes (611 packets)
    TX: 8977 bytes (73 packets)
    signal: 0 dBm
    rx bitrate: 6.0 MBit/s
    bss flags: short-slot-time
    dtim period: 1
    beacon int: 100

iw dev wlp6s0 station dump
Station d4:da:21:a8:06:7e (on wlp6s0)
    inactive time:    445 ms
    rx bytes:    175927
    rx packets:    716
    tx bytes:    9573
    tx packets:    79
    tx retries:    0
    tx failed:    0
    beacon loss:    0
    beacon rx:    238
    rx drop misc:    34
    signal:      0 dBm
    beacon signal avg:    -25 dBm
    tx duration:    0 us
    rx bitrate:    6.0 MBit/s
    rx duration:    0 us
    authorized:    yes
    authenticated:    yes
    associated:    yes
    preamble:    long
    WMM/WME:    yes
    MFP:        no
    TDLS peer:    no
    DTIM period:    1
    beacon interval:100
    short slot time:yes
    connected time:    253 seconds
    associated at [boottime]:    309.866s
    associated at:    1710947541025 ms
    current time:    1710947793618 ms



Intel be200 adapter output on the same system:
iw dev wlp5s0f0 link
Connected to d4:da:21:a8:06:7e (on wlp5s0f0)
    SSID: NETGEAR65
    freq: 5805.0
    RX: 97845 bytes (282 packets)
    TX: 10930 bytes (91 packets)
    signal: -27 dBm
    rx bitrate: 6.0 MBit/s
    tx bitrate: 117.0 MBit/s 40MHz HE-MCS 3 HE-NSS 2 HE-GI 2 HE-DCM 0
    bss flags: short-slot-time
    dtim period: 1
    beacon int: 100

iw dev wlp5s0f0 station dump
Station d4:da:21:a8:06:7e (on wlp5s0f0)
    inactive time:    55 ms
    rx bytes:    1721336
    rx packets:    5459
    tx bytes:    7824741
    tx packets:    18298
    tx retries:    413
    tx failed:    0
    beacon loss:    0
    beacon rx:    0
    rx drop misc:    254
    signal:      -38 [-38, -39] dBm
    signal avg:    -36 dBm
    tx bitrate:    573.5 MBit/s 40MHz HE-MCS 11 HE-NSS 2 HE-GI 0 HE-DCM 0
    tx duration:    0 us
    rx bitrate:    573.5 MBit/s 40MHz HE-MCS 11 HE-NSS 2 HE-GI 0 HE-DCM 0
    rx duration:    0 us
    authorized:    yes
    authenticated:    yes
    associated:    yes
    preamble:    long
    WMM/WME:    yes
    MFP:        no
    TDLS peer:    no
    DTIM period:    1
    beacon interval:100
    short slot time:yes
    connected time:    2040 seconds
    associated at [boottime]:    306.733s
    associated at:    1710947537891 ms
    current time:    1710949577462 ms

Regards

Re: ath12k: driver does not show tx bitrate

[Kalle Valo]

"Owen Mesh." <owen.mesh@gmail.com> writes:

> I found a small bug in ath12k driver with wcn7850 adapter.
> ath12k driver does not show tx bitrate.

We are working on adding it:

https://patchwork.kernel.org/project/linux-wireless/patch/20240219095802.1147-1-quic_lingbok@quicinc.com/

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: ath12k: driver does not show tx bitrate

[Owen Mesh.]

Thanks, great
I also noticed that a fix for missing "signal strength" is planned!

Regards

ср, 20 мар. 2024 г. в 19:21, Kalle Valo <kvalo@kernel.org>:
>
> "Owen Mesh." <owen.mesh@gmail.com> writes:
>
> > I found a small bug in ath12k driver with wcn7850 adapter.
> > ath12k driver does not show tx bitrate.
>
> We are working on adding it:
>
> https://patchwork.kernel.org/project/linux-wireless/patch/20240219095802.1147-1-quic_lingbok@quicinc.com/
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: ath12k: driver does not show tx bitrate

[Owen Mesh.]

Dear Sirs,
I was wondering if it would be possible to add thermal sensor support
for the arh12k as it's in the ath11k.

Thank you and best regards

ср, 20 мар. 2024 г. в 19:36, Owen Mesh. <owen.mesh@gmail.com>:
>
> Thanks, great
> I also noticed that a fix for missing "signal strength" is planned!
>
> Regards
>
> ср, 20 мар. 2024 г. в 19:21, Kalle Valo <kvalo@kernel.org>:
> >
> > "Owen Mesh." <owen.mesh@gmail.com> writes:
> >
> > > I found a small bug in ath12k driver with wcn7850 adapter.
> > > ath12k driver does not show tx bitrate.
> >
> > We are working on adding it:
> >
> > https://patchwork.kernel.org/project/linux-wireless/patch/20240219095802.1147-1-quic_lingbok@quicinc.com/
> >
> > --
> > https://patchwork.kernel.org/project/linux-wireless/list/
> >
> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: ath12k: driver does not show tx bitrate

[Owen Mesh.]

Dear Sirs,
FYI
Just tried this patch
https://patchwork.kernel.org/project/linux-wireless/patch/20240219095802.1147-1-quic_lingbok@quicinc.com/
iw now shows "tx bitrate: (unknown) 80MHz":
iw dev wlp6s0 link
Connected to d4:da:21:a8:06:7e (on wlp6s0)
    SSID: NETGEAR65
    freq: 5805.0
    RX: 398485 bytes (1661 packets)
    TX: 20994 bytes (192 packets)
    signal: -25 dBm
    rx bitrate: 6.0 MBit/s
    tx bitrate: (unknown) 80MHz
    bss flags: short-slot-time
    dtim period: 1
    beacon int: 100

I believe this is due to a missing 11BE part in the patch.
Something like this:
+    } else if (ts->pkt_type == HAL_TX_RATE_STATS_PKT_TYPE_11BE) {
I have a router with a QCN9274 chip and, I believe, I have an 802.11be
connection with it.

ср, 20 мар. 2024 г. в 20:08, Owen Mesh. <owen.mesh@gmail.com>:
>
> Dear Sirs,
> I was wondering if it would be possible to add thermal sensor support
> for the arh12k as it's in the ath11k.
>
> Thank you and best regards
>
> ср, 20 мар. 2024 г. в 19:36, Owen Mesh. <owen.mesh@gmail.com>:
> >
> > Thanks, great
> > I also noticed that a fix for missing "signal strength" is planned!
> >
> > Regards
> >
> > ср, 20 мар. 2024 г. в 19:21, Kalle Valo <kvalo@kernel.org>:
> > >
> > > "Owen Mesh." <owen.mesh@gmail.com> writes:
> > >
> > > > I found a small bug in ath12k driver with wcn7850 adapter.
> > > > ath12k driver does not show tx bitrate.
> > >
> > > We are working on adding it:
> > >
> > > https://patchwork.kernel.org/project/linux-wireless/patch/20240219095802.1147-1-quic_lingbok@quicinc.com/
> > >
> > > --
> > > https://patchwork.kernel.org/project/linux-wireless/list/
> > >
> > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: ath12k: driver does not show tx bitrate

[Lingbo Kong]

The patch of tx bitrate of 11be, we're working on add it:

https://patchwork.kernel.org/project/linux-wireless/patch/20240104032202.19472-1-quic_lingbok@quicinc.com/

Best regards
Lingbo Kong

On 2024/3/21 1:43, Owen Mesh. wrote:
> Dear Sirs,
> FYI
> Just tried this patch
> https://patchwork.kernel.org/project/linux-wireless/patch/20240219095802.1147-1-quic_lingbok@quicinc.com/
> iw now shows "tx bitrate: (unknown) 80MHz":
> iw dev wlp6s0 link
> Connected to d4:da:21:a8:06:7e (on wlp6s0)
>      SSID: NETGEAR65
>      freq: 5805.0
>      RX: 398485 bytes (1661 packets)
>      TX: 20994 bytes (192 packets)
>      signal: -25 dBm
>      rx bitrate: 6.0 MBit/s
>      tx bitrate: (unknown) 80MHz
>      bss flags: short-slot-time
>      dtim period: 1
>      beacon int: 100
> 
> I believe this is due to a missing 11BE part in the patch.
> Something like this:
> +    } else if (ts->pkt_type == HAL_TX_RATE_STATS_PKT_TYPE_11BE) {
> I have a router with a QCN9274 chip and, I believe, I have an 802.11be
> connection with it.
> 
> ср, 20 мар. 2024 г. в 20:08, Owen Mesh. <owen.mesh@gmail.com>:
>>
>> Dear Sirs,
>> I was wondering if it would be possible to add thermal sensor support
>> for the arh12k as it's in the ath11k.
>>
>> Thank you and best regards
>>
>> ср, 20 мар. 2024 г. в 19:36, Owen Mesh. <owen.mesh@gmail.com>:
>>>
>>> Thanks, great
>>> I also noticed that a fix for missing "signal strength" is planned!
>>>
>>> Regards
>>>
>>> ср, 20 мар. 2024 г. в 19:21, Kalle Valo <kvalo@kernel.org>:
>>>>
>>>> "Owen Mesh." <owen.mesh@gmail.com> writes:
>>>>
>>>>> I found a small bug in ath12k driver with wcn7850 adapter.
>>>>> ath12k driver does not show tx bitrate.
>>>>
>>>> We are working on adding it:
>>>>
>>>> https://patchwork.kernel.org/project/linux-wireless/patch/20240219095802.1147-1-quic_lingbok@quicinc.com/
>>>>
>>>> --
>>>> https://patchwork.kernel.org/project/linux-wireless/list/
>>>>
>>>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> 

Re: ath12k: driver does not show tx bitrate

[Owen Mesh.]

Thanks!

I applied this patch.
It looks great for my configuration/platform!

iw now shows 802.11be tx and rx bitrates:

iw dev wlp6s0 link
Connected to d4:da:21:a8:06:7e (on wlp6s0)
    SSID: NETGEAR65
    freq: 5805.0
    RX: 36791 bytes (185 packets)
    TX: 9111 bytes (73 packets)
    signal: -27 dBm
    rx bitrate: 1801.4 MBit/s 80MHz EHT-MCS 11 EHT-NSS 3 EHT-GI 0
    tx bitrate: 1200.9 MBit/s 80MHz EHT-MCS 11 EHT-NSS 2 EHT-GI 0

    bss flags: short-slot-time
    dtim period: 1
    beacon int: 100

Best regards

On Thu, Mar 21, 2024 at 5:32 AM Lingbo Kong <quic_lingbok@quicinc.com> wrote:
>
>
> The patch of tx bitrate of 11be, we're working on add it:
>
> https://patchwork.kernel.org/project/linux-wireless/patch/20240104032202.19472-1-quic_lingbok@quicinc.com/
>
> Best regards
> Lingbo Kong
>
> On 2024/3/21 1:43, Owen Mesh. wrote:
> > Dear Sirs,
> > FYI
> > Just tried this patch
> > https://patchwork.kernel.org/project/linux-wireless/patch/20240219095802.1147-1-quic_lingbok@quicinc.com/
> > iw now shows "tx bitrate: (unknown) 80MHz":
> > iw dev wlp6s0 link
> > Connected to d4:da:21:a8:06:7e (on wlp6s0)
> >      SSID: NETGEAR65
> >      freq: 5805.0
> >      RX: 398485 bytes (1661 packets)
> >      TX: 20994 bytes (192 packets)
> >      signal: -25 dBm
> >      rx bitrate: 6.0 MBit/s
> >      tx bitrate: (unknown) 80MHz
> >      bss flags: short-slot-time
> >      dtim period: 1
> >      beacon int: 100
> >
> > I believe this is due to a missing 11BE part in the patch.
> > Something like this:
> > +    } else if (ts->pkt_type == HAL_TX_RATE_STATS_PKT_TYPE_11BE) {
> > I have a router with a QCN9274 chip and, I believe, I have an 802.11be
> > connection with it.
> >
> > ср, 20 мар. 2024 г. в 20:08, Owen Mesh. <owen.mesh@gmail.com>:
> >>
> >> Dear Sirs,
> >> I was wondering if it would be possible to add thermal sensor support
> >> for the arh12k as it's in the ath11k.
> >>
> >> Thank you and best regards
> >>
> >> ср, 20 мар. 2024 г. в 19:36, Owen Mesh. <owen.mesh@gmail.com>:
> >>>
> >>> Thanks, great
> >>> I also noticed that a fix for missing "signal strength" is planned!
> >>>
> >>> Regards
> >>>
> >>> ср, 20 мар. 2024 г. в 19:21, Kalle Valo <kvalo@kernel.org>:
> >>>>
> >>>> "Owen Mesh." <owen.mesh@gmail.com> writes:
> >>>>
> >>>>> I found a small bug in ath12k driver with wcn7850 adapter.
> >>>>> ath12k driver does not show tx bitrate.
> >>>>
> >>>> We are working on adding it:
> >>>>
> >>>> https://patchwork.kernel.org/project/linux-wireless/patch/20240219095802.1147-1-quic_lingbok@quicinc.com/
> >>>>
> >>>> --
> >>>> https://patchwork.kernel.org/project/linux-wireless/list/
> >>>>
> >>>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> >

Re: ath12k: driver does not show tx bitrate

[Jeff Johnson]

On 3/20/2024 11:33 PM, Owen Mesh. wrote:
> Thanks!
> 
> I applied this patch.
> It looks great for my configuration/platform!
> 
> iw now shows 802.11be tx and rx bitrates:
> 
> iw dev wlp6s0 link
> Connected to d4:da:21:a8:06:7e (on wlp6s0)
>     SSID: NETGEAR65
>     freq: 5805.0
>     RX: 36791 bytes (185 packets)
>     TX: 9111 bytes (73 packets)
>     signal: -27 dBm
>     rx bitrate: 1801.4 MBit/s 80MHz EHT-MCS 11 EHT-NSS 3 EHT-GI 0
>     tx bitrate: 1200.9 MBit/s 80MHz EHT-MCS 11 EHT-NSS 2 EHT-GI 0
> 
>     bss flags: short-slot-time
>     dtim period: 1
>     beacon int: 100
> 
> Best regards

Is it OK to add the following to the final commit:
Tested-by: Owen Mesh <owen.mesh@gmail.com>

Re: ath12k: driver does not show tx bitrate

[Owen Mesh.]

Yes, please!

On Thu, Mar 21, 2024 at 7:12 PM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>
> On 3/20/2024 11:33 PM, Owen Mesh. wrote:
> > Thanks!
> >
> > I applied this patch.
> > It looks great for my configuration/platform!
> >
> > iw now shows 802.11be tx and rx bitrates:
> >
> > iw dev wlp6s0 link
> > Connected to d4:da:21:a8:06:7e (on wlp6s0)
> >     SSID: NETGEAR65
> >     freq: 5805.0
> >     RX: 36791 bytes (185 packets)
> >     TX: 9111 bytes (73 packets)
> >     signal: -27 dBm
> >     rx bitrate: 1801.4 MBit/s 80MHz EHT-MCS 11 EHT-NSS 3 EHT-GI 0
> >     tx bitrate: 1200.9 MBit/s 80MHz EHT-MCS 11 EHT-NSS 2 EHT-GI 0
> >
> >     bss flags: short-slot-time
> >     dtim period: 1
> >     beacon int: 100
> >
> > Best regards
>
> Is it OK to add the following to the final commit:
> Tested-by: Owen Mesh <owen.mesh@gmail.com>
>