[bug report] wifi: ath12k: return literal zeroes

[bug report] wifi: ath12k: return literal zeroes

[Dan Carpenter]

Hello Kalle Valo,

The patch d889913205cf: "wifi: ath12k: driver for Qualcomm Wi-Fi 7
devices" from Nov 28, 2022, leads to the following Smatch static
checker warning:

drivers/net/wireless/ath/ath12k/dp.c:772 ath12k_wbm_idle_ring_setup() info: returning a literal zero is cleaner
drivers/net/wireless/ath/ath12k/htc.c:712 ath12k_htc_connect_service() info: returning a literal zero is cleaner
drivers/net/wireless/ath/ath12k/mac.c:990 ath12k_mac_monitor_vdev_delete() info: returning a literal zero is cleaner
drivers/net/wireless/ath/ath12k/mac.c:4841 ath12k_set_he_mu_sounding_mode() info: returning a literal zero is cleaner
drivers/net/wireless/ath/ath12k/core.c:568 ath12k_core_start_firmware() info: returning a literal zero is cleaner
drivers/net/wireless/ath/ath12k/dp_rx.c:980 ath12k_dp_rx_peer_tid_setup() info: returning a literal zero is cleaner
drivers/net/wireless/ath/ath12k/dp_rx.c:1091 ath12k_dp_rx_ampdu_stop() info: returning a literal zero is cleaner
drivers/net/wireless/ath/ath12k/qmi.c:2799 ath12k_qmi_event_server_arrive() info: returning a literal zero is cleaner
drivers/net/wireless/ath/ath12k/qmi.c:2813 ath12k_qmi_event_mem_request() info: returning a literal zero is cleaner
drivers/net/wireless/ath/ath12k/qmi.c:2960 ath12k_qmi_ops_new_server() info: returning a literal zero is cleaner
drivers/net/wireless/ath/ath12k/qmi.c:3077 ath12k_qmi_init_service() info: returning a literal zero is cleaner

drivers/net/wireless/ath/ath12k/dp.c
    760         *n_link_desc = n_mpdu_link_desc + n_mpdu_queue_desc +
    761                       n_tx_msdu_link_desc + n_rx_msdu_link_desc;
    762 
    763         if (*n_link_desc & (*n_link_desc - 1))
    764                 *n_link_desc = 1 << fls(*n_link_desc);
    765 
    766         ret = ath12k_dp_srng_setup(ab, &dp->wbm_idle_ring,
    767                                    HAL_WBM_IDLE_LINK, 0, 0, *n_link_desc);
    768         if (ret) {
    769                 ath12k_warn(ab, "failed to setup wbm_idle_ring: %d\n", ret);
    770                 return ret;
    771         }
--> 772         return ret;

Better to return 0;

    773 }

The rest are the same but especially this one would be better as a
literal because it's in the middle of a function:

drivers/net/wireless/ath/ath12k/dp_rx.c:980 ath12k_dp_rx_peer_tid_setup() info: returning a literal zero is cleaner

regards,
dan carpenter

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k