From: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
To: Miaoqing Pan <quic_miaoqing@quicinc.com>,
kvalo@kernel.org, quic_jjohnson@quicinc.com
Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] wifi: ath12k: fix memory leak in ath12k_pci_remove()
Date: Wed, 22 Jan 2025 22:00:35 +0530 [thread overview]
Message-ID: <b6f99b64-3b11-4a4e-8995-fa18aa4ea203@oss.qualcomm.com> (raw)
In-Reply-To: <20250122084756.817548-1-quic_miaoqing@quicinc.com>
On 1/22/25 14:17, Miaoqing Pan wrote:
> --- a/drivers/net/wireless/ath/ath12k/pci.c
> +++ b/drivers/net/wireless/ath/ath12k/pci.c
> @@ -1725,6 +1725,7 @@ static void ath12k_pci_remove(struct pci_dev *pdev)
> if (test_bit(ATH12K_FLAG_QMI_FAIL, &ab->dev_flags)) {
> ath12k_pci_power_down(ab, false);
> ath12k_qmi_deinit_service(ab);
> + ath12k_fw_unmap(ab);
> ath12k_core_hw_group_unassign(ab);
> goto qmi_fail;
> }
Instead of this, why not move the "qmi_fail:" label above unmap() ?
--
Aditya
next prev parent reply other threads:[~2025-01-22 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 8:47 [PATCH v2] wifi: ath12k: fix memory leak in ath12k_pci_remove() Miaoqing Pan
2025-01-22 16:30 ` Aditya Kumar Singh [this message]
2025-01-23 7:47 ` Miaoqing Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6f99b64-3b11-4a4e-8995-fa18aa4ea203@oss.qualcomm.com \
--to=aditya.kumar.singh@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_miaoqing@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox