From: Miaoqing Pan <quic_miaoqing@quicinc.com>
To: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>,
<kvalo@kernel.org>, <quic_jjohnson@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] wifi: ath12k: fix memory leak in ath12k_pci_remove()
Date: Thu, 23 Jan 2025 15:47:16 +0800 [thread overview]
Message-ID: <e67e6d5f-f9cf-47b3-9374-e7d48d4b68d7@quicinc.com> (raw)
In-Reply-To: <b6f99b64-3b11-4a4e-8995-fa18aa4ea203@oss.qualcomm.com>
On 1/23/2025 12:30 AM, Aditya Kumar Singh wrote:
> On 1/22/25 14:17, Miaoqing Pan wrote:
>> --- a/drivers/net/wireless/ath/ath12k/pci.c
>> +++ b/drivers/net/wireless/ath/ath12k/pci.c
>> @@ -1725,6 +1725,7 @@ static void ath12k_pci_remove(struct pci_dev *pdev)
>> if (test_bit(ATH12K_FLAG_QMI_FAIL, &ab->dev_flags)) {
>> ath12k_pci_power_down(ab, false);
>> ath12k_qmi_deinit_service(ab);
>> + ath12k_fw_unmap(ab);
>> ath12k_core_hw_group_unassign(ab);
>> goto qmi_fail;
>> }
>
> Instead of this, why not move the "qmi_fail:" label above unmap() ?
>
Good catch, the code base is changed a lot since the v1.
prev parent reply other threads:[~2025-01-23 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 8:47 [PATCH v2] wifi: ath12k: fix memory leak in ath12k_pci_remove() Miaoqing Pan
2025-01-22 16:30 ` Aditya Kumar Singh
2025-01-23 7:47 ` Miaoqing Pan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e67e6d5f-f9cf-47b3-9374-e7d48d4b68d7@quicinc.com \
--to=quic_miaoqing@quicinc.com \
--cc=aditya.kumar.singh@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox