mirror of https://lore.kernel.org/ath12k/
 help / color / mirror / Atom feed
* [linux-mainline-6.17rc3-1-x86_64] RIP at qmi_handle_release with ath12k on a MSI x870e Carbon WiFi - mainline kernel.
@ 2025-08-31 15:36 a-development
  2025-09-02  2:51 ` Baochen Qiang
  0 siblings, 1 reply; 6+ messages in thread
From: a-development @ 2025-08-31 15:36 UTC (permalink / raw)
  To: ath12k

Had the joy to build a new machine.
I had to switch to mainline kernel to boot at all.
Blacklisting with kernel 6.16 allows me to boot, or using latest 
mainline kernel.

Hardware is NEW.

Log: https://0x0.st/KH4D.txt
Alternative: 
https://paste.gg/p/anonymous/52779beef5144f2fbe74be2673951f50

What should I do?


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [linux-mainline-6.17rc3-1-x86_64] RIP at qmi_handle_release with ath12k on a MSI x870e Carbon WiFi - mainline kernel.
  2025-08-31 15:36 [linux-mainline-6.17rc3-1-x86_64] RIP at qmi_handle_release with ath12k on a MSI x870e Carbon WiFi - mainline kernel a-development
@ 2025-09-02  2:51 ` Baochen Qiang
  2025-09-02  7:11   ` a-development
  0 siblings, 1 reply; 6+ messages in thread
From: Baochen Qiang @ 2025-09-02  2:51 UTC (permalink / raw)
  To: a-development, ath12k



On 8/31/2025 11:36 PM, a-development@posteo.de wrote:
> Had the joy to build a new machine.
> I had to switch to mainline kernel to boot at all.
> Blacklisting with kernel 6.16 allows me to boot, or using latest mainline kernel.
> 
> Hardware is NEW.
> 
> Log: https://0x0.st/KH4D.txt
> Alternative: https://paste.gg/p/anonymous/52779beef5144f2fbe74be2673951f50
> 
> What should I do?

Could you try if below diff can fix your issue:

diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c
index 8d2839cf1de3..bc40958e885d 100644
--- a/drivers/net/wireless/ath/ath12k/core.c
+++ b/drivers/net/wireless/ath/ath12k/core.c
@@ -2109,14 +2109,27 @@ static int ath12k_core_hw_group_create(struct ath12k_hw_group *ag)
                ret = ath12k_core_soc_create(ab);
                if (ret) {
                        mutex_unlock(&ab->core_lock);
-                       ath12k_err(ab, "failed to create soc core: %d\n", ret);
-                       return ret;
+                       ath12k_err(ab, "failed to create soc %d core: %d\n", i, ret);
+                       goto destroy;
                }

                mutex_unlock(&ab->core_lock);
        }

        return 0;
+
+destroy:
+       for (i--; i >= 0; i--) {
+               ab = ag->ab[i];
+               if (!ab)
+                       continue;
+
+               mutex_lock(&ab->core_lock);
+               ath12k_core_soc_destroy(ab);
+               mutex_unlock(&ab->core_lock);
+       }
+
+       return ret;
 }

 void ath12k_core_hw_group_set_mlo_capable(struct ath12k_hw_group *ag)
@@ -2191,7 +2204,7 @@ int ath12k_core_init(struct ath12k_base *ab)
                if (ret) {
                        mutex_unlock(&ag->mutex);
                        ath12k_warn(ab, "unable to create hw group\n");
-                       goto err_destroy_hw_group;
+                       goto err_unassign_hw_group;
                }
        }

@@ -2199,8 +2212,7 @@ int ath12k_core_init(struct ath12k_base *ab)

        return 0;

-err_destroy_hw_group:
-       ath12k_core_hw_group_destroy(ab->ag);
+err_unassign_hw_group:
        ath12k_core_hw_group_unassign(ab);
 err_unregister_notifier:
        ath12k_core_panic_notifier_unregister(ab);


> 



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [linux-mainline-6.17rc3-1-x86_64] RIP at qmi_handle_release with ath12k on a MSI x870e Carbon WiFi - mainline kernel.
  2025-09-02  2:51 ` Baochen Qiang
@ 2025-09-02  7:11   ` a-development
  2025-09-02  7:56     ` Baochen Qiang
  0 siblings, 1 reply; 6+ messages in thread
From: a-development @ 2025-09-02  7:11 UTC (permalink / raw)
  To: Baochen Qiang; +Cc: ath12k

Hello - the below diff fixes my issue.
I can finally boot/reboot/shutdown AND use my WiFi module - and not only 
Bluetooth.

Thank you so much!

Can you push the fix upstream?
Also maybe have a look at the linked issue which now would be resolved 
if patch is published?
https://bugzilla.kernel.org/show_bug.cgi?id=220518

On 02.09.2025 04:51, Baochen Qiang wrote:
> On 8/31/2025 11:36 PM, a-development@posteo.de wrote:
>> Had the joy to build a new machine.
>> I had to switch to mainline kernel to boot at all.
>> Blacklisting with kernel 6.16 allows me to boot, or using latest 
>> mainline kernel.
>> 
>> Hardware is NEW.
>> 
>> Log: https://0x0.st/KH4D.txt
>> Alternative: 
>> https://paste.gg/p/anonymous/52779beef5144f2fbe74be2673951f50
>> 
>> What should I do?
> 
> Could you try if below diff can fix your issue:
> 
> diff --git a/drivers/net/wireless/ath/ath12k/core.c
> b/drivers/net/wireless/ath/ath12k/core.c
> index 8d2839cf1de3..bc40958e885d 100644
> --- a/drivers/net/wireless/ath/ath12k/core.c
> +++ b/drivers/net/wireless/ath/ath12k/core.c
> @@ -2109,14 +2109,27 @@ static int ath12k_core_hw_group_create(struct
> ath12k_hw_group *ag)
>                 ret = ath12k_core_soc_create(ab);
>                 if (ret) {
>                         mutex_unlock(&ab->core_lock);
> -                       ath12k_err(ab, "failed to create soc core: 
> %d\n", ret);
> -                       return ret;
> +                       ath12k_err(ab, "failed to create soc %d core:
> %d\n", i, ret);
> +                       goto destroy;
>                 }
> 
>                 mutex_unlock(&ab->core_lock);
>         }
> 
>         return 0;
> +
> +destroy:
> +       for (i--; i >= 0; i--) {
> +               ab = ag->ab[i];
> +               if (!ab)
> +                       continue;
> +
> +               mutex_lock(&ab->core_lock);
> +               ath12k_core_soc_destroy(ab);
> +               mutex_unlock(&ab->core_lock);
> +       }
> +
> +       return ret;
>  }
> 
>  void ath12k_core_hw_group_set_mlo_capable(struct ath12k_hw_group *ag)
> @@ -2191,7 +2204,7 @@ int ath12k_core_init(struct ath12k_base *ab)
>                 if (ret) {
>                         mutex_unlock(&ag->mutex);
>                         ath12k_warn(ab, "unable to create hw group\n");
> -                       goto err_destroy_hw_group;
> +                       goto err_unassign_hw_group;
>                 }
>         }
> 
> @@ -2199,8 +2212,7 @@ int ath12k_core_init(struct ath12k_base *ab)
> 
>         return 0;
> 
> -err_destroy_hw_group:
> -       ath12k_core_hw_group_destroy(ab->ag);
> +err_unassign_hw_group:
>         ath12k_core_hw_group_unassign(ab);
>  err_unregister_notifier:
>         ath12k_core_panic_notifier_unregister(ab);
> 
> 
>> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [linux-mainline-6.17rc3-1-x86_64] RIP at qmi_handle_release with ath12k on a MSI x870e Carbon WiFi - mainline kernel.
  2025-09-02  7:11   ` a-development
@ 2025-09-02  7:56     ` Baochen Qiang
  2025-09-02  9:02       ` a-development
  0 siblings, 1 reply; 6+ messages in thread
From: Baochen Qiang @ 2025-09-02  7:56 UTC (permalink / raw)
  To: a-development; +Cc: ath12k



On 9/2/2025 3:11 PM, a-development@posteo.de wrote:
> Hello - the below diff fixes my issue.
> I can finally boot/reboot/shutdown AND use my WiFi module - and not only Bluetooth.
> 
> Thank you so much!

Thank you for quick testing!

Would you mind providing a 'Tested-by:' tag such that I can include it in the patch?

> 
> Can you push the fix upstream?
> Also maybe have a look at the linked issue which now would be resolved if patch is published?
> https://bugzilla.kernel.org/show_bug.cgi?id=220518

This seems the same issue, so yeah I think it should be resolved with the diff here.

> 
> On 02.09.2025 04:51, Baochen Qiang wrote:
>> On 8/31/2025 11:36 PM, a-development@posteo.de wrote:
>>> Had the joy to build a new machine.
>>> I had to switch to mainline kernel to boot at all.
>>> Blacklisting with kernel 6.16 allows me to boot, or using latest mainline kernel.
>>>
>>> Hardware is NEW.
>>>
>>> Log: https://0x0.st/KH4D.txt
>>> Alternative: https://paste.gg/p/anonymous/52779beef5144f2fbe74be2673951f50
>>>
>>> What should I do?
>>
>> Could you try if below diff can fix your issue:
>>
>> diff --git a/drivers/net/wireless/ath/ath12k/core.c
>> b/drivers/net/wireless/ath/ath12k/core.c
>> index 8d2839cf1de3..bc40958e885d 100644
>> --- a/drivers/net/wireless/ath/ath12k/core.c
>> +++ b/drivers/net/wireless/ath/ath12k/core.c
>> @@ -2109,14 +2109,27 @@ static int ath12k_core_hw_group_create(struct
>> ath12k_hw_group *ag)
>>                 ret = ath12k_core_soc_create(ab);
>>                 if (ret) {
>>                         mutex_unlock(&ab->core_lock);
>> -                       ath12k_err(ab, "failed to create soc core: %d\n", ret);
>> -                       return ret;
>> +                       ath12k_err(ab, "failed to create soc %d core:
>> %d\n", i, ret);
>> +                       goto destroy;
>>                 }
>>
>>                 mutex_unlock(&ab->core_lock);
>>         }
>>
>>         return 0;
>> +
>> +destroy:
>> +       for (i--; i >= 0; i--) {
>> +               ab = ag->ab[i];
>> +               if (!ab)
>> +                       continue;
>> +
>> +               mutex_lock(&ab->core_lock);
>> +               ath12k_core_soc_destroy(ab);
>> +               mutex_unlock(&ab->core_lock);
>> +       }
>> +
>> +       return ret;
>>  }
>>
>>  void ath12k_core_hw_group_set_mlo_capable(struct ath12k_hw_group *ag)
>> @@ -2191,7 +2204,7 @@ int ath12k_core_init(struct ath12k_base *ab)
>>                 if (ret) {
>>                         mutex_unlock(&ag->mutex);
>>                         ath12k_warn(ab, "unable to create hw group\n");
>> -                       goto err_destroy_hw_group;
>> +                       goto err_unassign_hw_group;
>>                 }
>>         }
>>
>> @@ -2199,8 +2212,7 @@ int ath12k_core_init(struct ath12k_base *ab)
>>
>>         return 0;
>>
>> -err_destroy_hw_group:
>> -       ath12k_core_hw_group_destroy(ab->ag);
>> +err_unassign_hw_group:
>>         ath12k_core_hw_group_unassign(ab);
>>  err_unregister_notifier:
>>         ath12k_core_panic_notifier_unregister(ab);
>>
>>
>>>



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [linux-mainline-6.17rc3-1-x86_64] RIP at qmi_handle_release with ath12k on a MSI x870e Carbon WiFi - mainline kernel.
  2025-09-02  7:56     ` Baochen Qiang
@ 2025-09-02  9:02       ` a-development
  2025-09-02  9:10         ` Baochen Qiang
  0 siblings, 1 reply; 6+ messages in thread
From: a-development @ 2025-09-02  9:02 UTC (permalink / raw)
  To: Baochen Qiang; +Cc: ath12k

Tested-by: a-development <a-development@posteo.de>

On 02.09.2025 09:56, Baochen Qiang wrote:
> On 9/2/2025 3:11 PM, a-development@posteo.de wrote:
>> Hello - the below diff fixes my issue.
>> I can finally boot/reboot/shutdown AND use my WiFi module - and not 
>> only Bluetooth.
>> 
>> Thank you so much!
> 
> Thank you for quick testing!
> 
> Would you mind providing a 'Tested-by:' tag such that I can include it
> in the patch?
> 
>> 
>> Can you push the fix upstream?
>> Also maybe have a look at the linked issue which now would be resolved 
>> if patch is published?
>> https://bugzilla.kernel.org/show_bug.cgi?id=220518
> 
> This seems the same issue, so yeah I think it should be resolved with
> the diff here.
> 
>> 
>> On 02.09.2025 04:51, Baochen Qiang wrote:
>>> On 8/31/2025 11:36 PM, a-development@posteo.de wrote:
>>>> Had the joy to build a new machine.
>>>> I had to switch to mainline kernel to boot at all.
>>>> Blacklisting with kernel 6.16 allows me to boot, or using latest 
>>>> mainline kernel.
>>>> 
>>>> Hardware is NEW.
>>>> 
>>>> Log: https://0x0.st/KH4D.txt
>>>> Alternative: 
>>>> https://paste.gg/p/anonymous/52779beef5144f2fbe74be2673951f50
>>>> 
>>>> What should I do?
>>> 
>>> Could you try if below diff can fix your issue:
>>> 
>>> diff --git a/drivers/net/wireless/ath/ath12k/core.c
>>> b/drivers/net/wireless/ath/ath12k/core.c
>>> index 8d2839cf1de3..bc40958e885d 100644
>>> --- a/drivers/net/wireless/ath/ath12k/core.c
>>> +++ b/drivers/net/wireless/ath/ath12k/core.c
>>> @@ -2109,14 +2109,27 @@ static int ath12k_core_hw_group_create(struct
>>> ath12k_hw_group *ag)
>>>                 ret = ath12k_core_soc_create(ab);
>>>                 if (ret) {
>>>                         mutex_unlock(&ab->core_lock);
>>> -                       ath12k_err(ab, "failed to create soc core: 
>>> %d\n", ret);
>>> -                       return ret;
>>> +                       ath12k_err(ab, "failed to create soc %d core:
>>> %d\n", i, ret);
>>> +                       goto destroy;
>>>                 }
>>> 
>>>                 mutex_unlock(&ab->core_lock);
>>>         }
>>> 
>>>         return 0;
>>> +
>>> +destroy:
>>> +       for (i--; i >= 0; i--) {
>>> +               ab = ag->ab[i];
>>> +               if (!ab)
>>> +                       continue;
>>> +
>>> +               mutex_lock(&ab->core_lock);
>>> +               ath12k_core_soc_destroy(ab);
>>> +               mutex_unlock(&ab->core_lock);
>>> +       }
>>> +
>>> +       return ret;
>>>  }
>>> 
>>>  void ath12k_core_hw_group_set_mlo_capable(struct ath12k_hw_group 
>>> *ag)
>>> @@ -2191,7 +2204,7 @@ int ath12k_core_init(struct ath12k_base *ab)
>>>                 if (ret) {
>>>                         mutex_unlock(&ag->mutex);
>>>                         ath12k_warn(ab, "unable to create hw 
>>> group\n");
>>> -                       goto err_destroy_hw_group;
>>> +                       goto err_unassign_hw_group;
>>>                 }
>>>         }
>>> 
>>> @@ -2199,8 +2212,7 @@ int ath12k_core_init(struct ath12k_base *ab)
>>> 
>>>         return 0;
>>> 
>>> -err_destroy_hw_group:
>>> -       ath12k_core_hw_group_destroy(ab->ag);
>>> +err_unassign_hw_group:
>>>         ath12k_core_hw_group_unassign(ab);
>>>  err_unregister_notifier:
>>>         ath12k_core_panic_notifier_unregister(ab);
>>> 
>>> 
>>>> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [linux-mainline-6.17rc3-1-x86_64] RIP at qmi_handle_release with ath12k on a MSI x870e Carbon WiFi - mainline kernel.
  2025-09-02  9:02       ` a-development
@ 2025-09-02  9:10         ` Baochen Qiang
  0 siblings, 0 replies; 6+ messages in thread
From: Baochen Qiang @ 2025-09-02  9:10 UTC (permalink / raw)
  To: a-development; +Cc: ath12k



On 9/2/2025 5:02 PM, a-development@posteo.de wrote:
> Tested-by: a-development <a-development@posteo.de>

Thanks~



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-09-02 12:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-31 15:36 [linux-mainline-6.17rc3-1-x86_64] RIP at qmi_handle_release with ath12k on a MSI x870e Carbon WiFi - mainline kernel a-development
2025-09-02  2:51 ` Baochen Qiang
2025-09-02  7:11   ` a-development
2025-09-02  7:56     ` Baochen Qiang
2025-09-02  9:02       ` a-development
2025-09-02  9:10         ` Baochen Qiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox