From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Kalle Valo <kvalo@kernel.org>, Baochen Qiang <quic_bqiang@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath12k: fix kernel crash during resume
Date: Mon, 22 Apr 2024 18:34:16 -0700 [thread overview]
Message-ID: <e409e282-3f6d-42e2-ac6d-7602e3ef1b87@quicinc.com> (raw)
In-Reply-To: <88a1ab50-3dea-406e-adcb-b02786ce7f30@quicinc.com>
On 4/22/2024 11:41 AM, Jeff Johnson wrote:
> On 4/22/2024 8:41 AM, Jeff Johnson wrote:
>> On 4/22/2024 6:12 AM, Kalle Valo wrote:
>>> To avoid breaking git bisect I now reshuffled the pending branch so that
>>> 'wifi: ath12k: fix kernel crash during resume' is before the suspend
>>> patchset and my plan is to commit the patches in same order. Does this
>>> make sense for everyone?
>>>
>>> I had a simple conflict in ath12k_core_reset() in these commits:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=052a6a7c74ae4f20a31a632184f4439edcb0f40c
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=6bc740619993535cb64c4dcebb83c66acd506763
>>>
>>> Please check my changes.
>>>
>> These look OK to me.
>> I'll test the pending branch on my laptop
>
> pending branch crashes on my laptop
> let me bisect
ok, that was user error.
I had updated my workspace on my VM but not on my actual laptop, and the old
pending branch on my laptop contained the follow patch which I've already
flagged as bad (and is not present in the current pending branch):
wifi: ath12k: Fix Tx Completion Ring(WBM2SW) Setup Failure
I updated my laptop to:
5085843538af (origin/pending, pending) wifi: ath12k: report station mode
signal strength
And everything in that pending branch works fine, including hotspot.
/jeff
next prev parent reply other threads:[~2024-04-23 1:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 3:40 [PATCH] wifi: ath12k: fix kernel crash during resume Baochen Qiang
2024-04-19 4:18 ` Kalle Valo
2024-04-19 4:38 ` Kalle Valo
2024-04-22 13:12 ` Kalle Valo
2024-04-22 15:41 ` Jeff Johnson
2024-04-22 18:41 ` Jeff Johnson
2024-04-23 1:34 ` Jeff Johnson [this message]
2024-04-23 4:10 ` Kalle Valo
2024-04-23 5:09 ` Baochen Qiang
2024-04-23 9:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e409e282-3f6d-42e2-ac6d-7602e3ef1b87@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox