[ath9k-devel] [PATCH 3/3] ath10k: enable STA UAPSD support

[Kalle Valo <kvalo@qca.qualcomm.com>]

Michal Kazior <michal.kazior@tieto.com> writes:

>> Not really. This is because we have to set/clean this flags for every ACs.
>> So, this is just to prevent code duplication.
>>
>>          case IEEE80211_AC_VO:
>>                 if (enable)
>>                          ...
>>                 else
>>                        ....
>>                 break;
>>         case IEEE80211_AC_VI:
>>                 if (enable)
>>                        ....
>>                  else
>>                       ....
>>                 break;
>>          .....
>>
>> I can remove this macro and create inline function instead.
>
> Hmm, but since this is per-ac can't we do the following?
>
> switch (ac) {
> case IEEE80211_AC_VO:
> 	val = WMI_STA_PS_UAPSD_AC3_DELIVERY_EN |
>               WMI_STA_PS_UAPSD_AC3_TRIGGER_EN;
> 	break;
> // ..
> }
>
> if (enable)
> 	arvif->u.sta.uapsd |= val;
> else
> 	arvif->u.sta.uapsd &= ~val;
>
>
> No macros and no code duplication.

Yes, much better. I hate macros :)

-- 
Kalle Valo