[ath9k-devel] [PATCH 1/3] ath10k: WMI add AP PS

[Kalle Valo <kvalo@qca.qualcomm.com>]

<Janusz.Dziedzic@tieto.com> writes:

>>-----Original Message-----
>>From: Kalle Valo [mailto:kvalo at qca.qualcomm.com]
>>Sent: 9 maja 2013 09:10
>>To: Dziedzic Janusz
>>Cc: ath9k-devel at lists.ath9k.org
>>Subject: Re: [ath9k-devel] [PATCH 1/3] ath10k: WMI add AP PS
>>
>>Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>>
>>> Add AP power save (UAPSD) structures, enums.
>>>
>>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>>
>>[...]
>>
>>> +	cmd->vdev_id     = __cpu_to_le32(vdev_id);
>>> +	cmd->param_id    = __cpu_to_le32(param_id);
>>> +	cmd->param_value = __cpu_to_le32(value);
>>
>>Remove the extra whitespace before '='.
>>
>
> I did same style we have in wmi.c In other functions,  

Yeah, I know. But I would prefer not to use that style in ath10k. I have
been trying to remove that style from ath10k, but I haven't converted
all cases yet.

> Eg. (ath10k_wmi_set_psmode)
>         cmd->vdev_id     = __cpu_to_le32(vdev_id);
>         cmd->sta_ps_mode = __cpu_to_le32(psmode);
>
> So, should I change this?

I'm happy to take patches :)

-- 
Kalle Valo