public inbox for b43-dev@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] b43-asm: fix compile error: undefined reference to `yydebug'
@ 2013-02-28 10:34 Hauke Mehrtens
  2013-02-28 12:35 ` Michael Büsch
  0 siblings, 1 reply; 2+ messages in thread
From: Hauke Mehrtens @ 2013-02-28 10:34 UTC (permalink / raw)
  To: b43-dev

With bison 2.7 YYDEBUG will be set to 0 if it was not set, then #ifdef
YYDEBUG returns true, but bison 2.7 treets YYDEBUG 0 as not set.

This fixes the following error:
obj/main.o: In function `main':
main.c:(.text.startup+0xaf): undefined reference to `yydebug'
collect2: error: ld returned 1 exit status

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 assembler/Makefile |    2 +-
 assembler/main.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/assembler/Makefile b/assembler/Makefile
index 21c652d..e9ce6f6 100644
--- a/assembler/Makefile
+++ b/assembler/Makefile
@@ -30,7 +30,7 @@ BIN		= b43-asm.bin
 SRCS		= parser.c scanner.c main.c initvals.c util.c args.c
 
 # YACC related CFLAGS
-CFLAGS		+= -DYYSTYPE="void *" -DYYERROR_VERBOSE -DYYDEBUG -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -Wno-unused
+CFLAGS		+= -DYYSTYPE="void *" -DYYERROR_VERBOSE -DYYDEBUG=1 -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -Wno-unused
 
 .SUFFIXES:
 .PHONY: all install clean distclean
diff --git a/assembler/main.c b/assembler/main.c
index afca996..a62a15e 100644
--- a/assembler/main.c
+++ b/assembler/main.c
@@ -1260,7 +1260,7 @@ static void initialize(void)
 {
 	INIT_LIST_HEAD(&infile.sl);
 	INIT_LIST_HEAD(&infile.ivals);
-#ifdef YYDEBUG
+#if YYDEBUG
 	if (IS_INSANE_DEBUG)
 		yydebug = 1;
 	else
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] b43-asm: fix compile error: undefined reference to `yydebug'
  2013-02-28 10:34 [PATCH] b43-asm: fix compile error: undefined reference to `yydebug' Hauke Mehrtens
@ 2013-02-28 12:35 ` Michael Büsch
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Büsch @ 2013-02-28 12:35 UTC (permalink / raw)
  To: b43-dev

On Thu, 28 Feb 2013 11:34:43 +0100
Hauke Mehrtens <hauke@hauke-m.de> wrote:

> With bison 2.7 YYDEBUG will be set to 0 if it was not set, then #ifdef
> YYDEBUG returns true, but bison 2.7 treets YYDEBUG 0 as not set.

Applied.
Thanks for the patch.


Also note that b43-tools.git will be mirrored from now on at github:
https://github.com/mbuesch?tab=repositories
Just in case bues.ch is not reachable for whatever reason. The repositories
on bues.ch are still the main ones, though, and should be used in links, documentation, etc...

-- 
Michael

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-28 12:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-28 10:34 [PATCH] b43-asm: fix compile error: undefined reference to `yydebug' Hauke Mehrtens
2013-02-28 12:35 ` Michael Büsch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox