[PATCH 1/2] ssb: add PCI ID 0x4350

[PATCH 1/2] ssb: add PCI ID 0x4350

[Hauke Mehrtens]

14e4:4350 is found on a Broadcom BCM43222.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 drivers/ssb/b43_pci_bridge.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ssb/b43_pci_bridge.c b/drivers/ssb/b43_pci_bridge.c
index 266aa16..19396dc 100644
--- a/drivers/ssb/b43_pci_bridge.c
+++ b/drivers/ssb/b43_pci_bridge.c
@@ -37,6 +37,7 @@ static const struct pci_device_id b43_pci_bridge_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x4329) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x432b) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x432c) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x4350) },
 	{ 0, },
 };
 MODULE_DEVICE_TABLE(pci, b43_pci_bridge_tbl);
-- 
1.7.9.5

[PATCH 2/2] ssb: handle BCM43222 in pmu code.

[Hauke Mehrtens]

The BCM43222 with the chipid 43222 or 0xa8d6 in hex do not need any
special handling in the pmu code. This prevents some error messages
being shown.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 drivers/ssb/driver_chipcommon_pmu.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ssb/driver_chipcommon_pmu.c b/drivers/ssb/driver_chipcommon_pmu.c
index b58fef7..d7d5804 100644
--- a/drivers/ssb/driver_chipcommon_pmu.c
+++ b/drivers/ssb/driver_chipcommon_pmu.c
@@ -346,6 +346,8 @@ static void ssb_pmu_pll_init(struct ssb_chipcommon *cc)
 			chipco_write32(cc, SSB_CHIPCO_PLLCTL_DATA, 0x380005C0);
 		}
 		break;
+	case 43222:
+		break;
 	default:
 		ssb_printk(KERN_ERR PFX
 			   "ERROR: PLL init unknown for device %04X\n",
@@ -434,6 +436,7 @@ static void ssb_pmu_resources_init(struct ssb_chipcommon *cc)
 		 min_msk = 0xCBB;
 		 break;
 	case 0x4322:
+	case 43222:
 		/* We keep the default settings:
 		 * min_msk = 0xCBB
 		 * max_msk = 0x7FFFF
-- 
1.7.9.5

[PATCH 1/2] ssb: add PCI ID 0x4350

[Rafał Miłecki]

2012/10/25 Hauke Mehrtens <hauke@hauke-m.de>:
> 14e4:4350 is found on a Broadcom BCM43222.

Huh, I expected BCM43222 to be BCMA based, interesting. Could you
provide ssb log for scanning (cores listing) and PHY&RADIO info?

-- 
Rafa?

[PATCH 1/2] ssb: add PCI ID 0x4350

[Hauke Mehrtens]

On 10/25/2012 06:47 PM, Rafa? Mi?ecki wrote:
> 2012/10/25 Hauke Mehrtens <hauke@hauke-m.de>:
>> 14e4:4350 is found on a Broadcom BCM43222.
> 
> Huh, I expected BCM43222 to be BCMA based, interesting. Could you
> provide ssb log for scanning (cores listing) and PHY&RADIO info?
> 

It is not my device, but Aitor found it, here are the details:
http://comments.gmane.org/gmane.comp.embedded.openwrt.user/2031

Here is the log you requested, without the patches:
...
b43-pci-bridge 0000:00:02.0: setting latency timer to 64
ssb: Found chip with id 0xA8D6, rev 0x00 and package 0x08
ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x1E, vendor 0x4243)
ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x10, vendor 0x4243)
ssb: Core 2 found: PCI (cc 0x804, rev 0x0E, vendor 0x4243)
ssb: chipcommon status is 0x40040
ssb: Found rev 2 PMU (capabilities 0x044C3002)
ssb: ERROR: PLL init unknown for device A8D6
ssb: ERROR: PMU resource config unknown for device A8D6
ssb: SPROM offset is 0x1000
ssb: SPROM revision 8 detected.
b43-phy0: Broadcom 43222 WLAN found (core revision 16)
ssb: Sonics Silicon Backplane found on PCI device 0000:00:02.0
ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
...

Hauke

[PATCH 1/2] ssb: add PCI ID 0x4350

[Aitor Cuartango]

If you need more information about the device let me know.

With the last openwrt's trunk i can create a wifi network but only in b/g mode.

I've test editing manually /etc/config/wireless  and change :
        option hwmode '11g'
with
        option hwmode '11ng'

but it does not starts, perhaps i need to do more changes in this file...


Thanks all!
aitor


2012/10/25 Hauke Mehrtens <hauke@hauke-m.de>:
> On 10/25/2012 06:47 PM, Rafa? Mi?ecki wrote:
>> 2012/10/25 Hauke Mehrtens <hauke@hauke-m.de>:
>>> 14e4:4350 is found on a Broadcom BCM43222.
>>
>> Huh, I expected BCM43222 to be BCMA based, interesting. Could you
>> provide ssb log for scanning (cores listing) and PHY&RADIO info?
>>
>
> It is not my device, but Aitor found it, here are the details:
> http://comments.gmane.org/gmane.comp.embedded.openwrt.user/2031
>
> Here is the log you requested, without the patches:
> ...
> b43-pci-bridge 0000:00:02.0: setting latency timer to 64
> ssb: Found chip with id 0xA8D6, rev 0x00 and package 0x08
> ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x1E, vendor 0x4243)
> ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x10, vendor 0x4243)
> ssb: Core 2 found: PCI (cc 0x804, rev 0x0E, vendor 0x4243)
> ssb: chipcommon status is 0x40040
> ssb: Found rev 2 PMU (capabilities 0x044C3002)
> ssb: ERROR: PLL init unknown for device A8D6
> ssb: ERROR: PMU resource config unknown for device A8D6
> ssb: SPROM offset is 0x1000
> ssb: SPROM revision 8 detected.
> b43-phy0: Broadcom 43222 WLAN found (core revision 16)
> ssb: Sonics Silicon Backplane found on PCI device 0000:00:02.0
> ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
> ...
>
> Hauke

[PATCH 1/2] ssb: add PCI ID 0x4350

[Hauke Mehrtens]

Please stop top posting

A: Because we read from top to bottom, left to right.
Q: Why should I start my reply below the quoted text?

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

A: The lost context.
Q: What makes top-posted replies harder to read than bottom-posted?

A: Yes.
Q: Should I trim down the quoted part of an email to which I'm replying?

http://www.idallen.com/topposting.html


On 12/27/2012 07:26 AM, spameden wrote:
> Hi guys I have the same device.
> 
> I'm wondering if it's fully supported or not by b43 driver.
> 
> Here
> http://linuxwireless.org/en/users/Drivers/b43?highlight=%2814e4%29#Supported_devices
> I can see it's listed as supported in N-phy, but as Aitor said on
> OpenWRT only b/g mode supported for some reason..

n-phy is the name of the phy, the hardware supports ieee80211n, but b43
does not support ieee80211n at all.

> I can provide all needed info for this device, I have it in my old ASUS
> WL-500gP v1.
> 
> On the other note there is a leaked broadcom source of wl driver from
> Belkin F7D4401 v1.00.39 (it was posted online), I hope it helps:

We already have a spec for this phy and the n specific stuff should also
be in the phy code b43 uses, someone has just to add support for
ieee80211n to b43 in general.

> http://uploadmirrors.com/download/XLVMMGAJ/Belkin-F7D4401-v1.00.39.tar.7z
> http://www.mirrorcreator.com/files/1DJEOCRJ/Belkin-F7D4401-v1.00.39.tar.7z_links
> http://www.digzip.com/files/1L27MJRC/Belkin-F7D4401-v1.00.39.tar.7z
> http://www.multiupload.nl/P6B0GK9U6R
> 
> hopefully it'd help.
> 
> 2012/10/27 Aitor Cuartango <aitor.cuartango@gmail.com
> <mailto:aitor.cuartango@gmail.com>>
> 
>     If you need more information about the device let me know.
> 
>     With the last openwrt's trunk i can create a wifi network but only
>     in b/g mode.
> 
>     I've test editing manually /etc/config/wireless  and change :
>             option hwmode '11g'
>     with
>             option hwmode '11ng'
> 
>     but it does not starts, perhaps i need to do more changes in this
>     file...
> 
> 
>     Thanks all!
>     aitor
> 
> 
>     2012/10/25 Hauke Mehrtens <hauke at hauke-m.de <mailto:hauke@hauke-m.de>>:
>     > On 10/25/2012 06:47 PM, Rafa? Mi?ecki wrote:
>     >> 2012/10/25 Hauke Mehrtens <hauke@hauke-m.de
>     <mailto:hauke@hauke-m.de>>:
>     >>> 14e4:4350 is found on a Broadcom BCM43222.
>     >>
>     >> Huh, I expected BCM43222 to be BCMA based, interesting. Could you
>     >> provide ssb log for scanning (cores listing) and PHY&RADIO info?
>     >>
>     >
>     > It is not my device, but Aitor found it, here are the details:
>     > http://comments.gmane.org/gmane.comp.embedded.openwrt.user/2031
>     >
>     > Here is the log you requested, without the patches:
>     > ...
>     > b43-pci-bridge 0000:00:02.0: setting latency timer to 64
>     > ssb: Found chip with id 0xA8D6, rev 0x00 and package 0x08
>     > ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x1E, vendor 0x4243)
>     > ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x10, vendor 0x4243)
>     > ssb: Core 2 found: PCI (cc 0x804, rev 0x0E, vendor 0x4243)
>     > ssb: chipcommon status is 0x40040
>     > ssb: Found rev 2 PMU (capabilities 0x044C3002)
>     > ssb: ERROR: PLL init unknown for device A8D6
>     > ssb: ERROR: PMU resource config unknown for device A8D6
>     > ssb: SPROM offset is 0x1000
>     > ssb: SPROM revision 8 detected.
>     > b43-phy0: Broadcom 43222 WLAN found (core revision 16)
>     > ssb: Sonics Silicon Backplane found on PCI device 0000:00:02.0
>     > ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
>     > ...
>     >
>     > Hauke

[PATCH 1/2] ssb: add PCI ID 0x4350

[spameden]

2012/12/29 Hauke Mehrtens <hauke@hauke-m.de>:
> Please stop top posting
>
> A: Because we read from top to bottom, left to right.
> Q: Why should I start my reply below the quoted text?
>
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
>
> A: The lost context.
> Q: What makes top-posted replies harder to read than bottom-posted?
>
> A: Yes.
> Q: Should I trim down the quoted part of an email to which I'm replying?
>
> http://www.idallen.com/topposting.html

I'm sorry If I did it wrong.

>
>
> On 12/27/2012 07:26 AM, spameden wrote:
>> Hi guys I have the same device.
>>
>> I'm wondering if it's fully supported or not by b43 driver.
>>
>> Here
>> http://linuxwireless.org/en/users/Drivers/b43?highlight=%2814e4%29#Supported_devices
>> I can see it's listed as supported in N-phy, but as Aitor said on
>> OpenWRT only b/g mode supported for some reason..
>
> n-phy is the name of the phy, the hardware supports ieee80211n, but b43
> does not support ieee80211n at all.

thanks for clarification!

>
>> I can provide all needed info for this device, I have it in my old ASUS
>> WL-500gP v1.
>>
>> On the other note there is a leaked broadcom source of wl driver from
>> Belkin F7D4401 v1.00.39 (it was posted online), I hope it helps:
>
> We already have a spec for this phy and the n specific stuff should also
> be in the phy code b43 uses, someone has just to add support for
> ieee80211n to b43 in general.

ok I'm gonna wait for the retail support I guess..


>
>> http://uploadmirrors.com/download/XLVMMGAJ/Belkin-F7D4401-v1.00.39.tar.7z
>> http://www.mirrorcreator.com/files/1DJEOCRJ/Belkin-F7D4401-v1.00.39.tar.7z_links
>> http://www.digzip.com/files/1L27MJRC/Belkin-F7D4401-v1.00.39.tar.7z
>> http://www.multiupload.nl/P6B0GK9U6R
>>
>> hopefully it'd help.
>>
>> 2012/10/27 Aitor Cuartango <aitor.cuartango@gmail.com
>> <mailto:aitor.cuartango@gmail.com>>
>>
>>     If you need more information about the device let me know.
>>
>>     With the last openwrt's trunk i can create a wifi network but only
>>     in b/g mode.
>>
>>     I've test editing manually /etc/config/wireless  and change :
>>             option hwmode '11g'
>>     with
>>             option hwmode '11ng'
>>
>>     but it does not starts, perhaps i need to do more changes in this
>>     file...
>>
>>
>>     Thanks all!
>>     aitor
>>
>>
>>     2012/10/25 Hauke Mehrtens <hauke at hauke-m.de <mailto:hauke@hauke-m.de>>:
>>     > On 10/25/2012 06:47 PM, Rafa? Mi?ecki wrote:
>>     >> 2012/10/25 Hauke Mehrtens <hauke@hauke-m.de
>>     <mailto:hauke@hauke-m.de>>:
>>     >>> 14e4:4350 is found on a Broadcom BCM43222.
>>     >>
>>     >> Huh, I expected BCM43222 to be BCMA based, interesting. Could you
>>     >> provide ssb log for scanning (cores listing) and PHY&RADIO info?
>>     >>
>>     >
>>     > It is not my device, but Aitor found it, here are the details:
>>     > http://comments.gmane.org/gmane.comp.embedded.openwrt.user/2031
>>     >
>>     > Here is the log you requested, without the patches:
>>     > ...
>>     > b43-pci-bridge 0000:00:02.0: setting latency timer to 64
>>     > ssb: Found chip with id 0xA8D6, rev 0x00 and package 0x08
>>     > ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x1E, vendor 0x4243)
>>     > ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x10, vendor 0x4243)
>>     > ssb: Core 2 found: PCI (cc 0x804, rev 0x0E, vendor 0x4243)
>>     > ssb: chipcommon status is 0x40040
>>     > ssb: Found rev 2 PMU (capabilities 0x044C3002)
>>     > ssb: ERROR: PLL init unknown for device A8D6
>>     > ssb: ERROR: PMU resource config unknown for device A8D6
>>     > ssb: SPROM offset is 0x1000
>>     > ssb: SPROM revision 8 detected.
>>     > b43-phy0: Broadcom 43222 WLAN found (core revision 16)
>>     > ssb: Sonics Silicon Backplane found on PCI device 0000:00:02.0
>>     > ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
>>     > ...
>>     >
>>     > Hauke
>
>