[PATCH][FIX][RESEND] b43: fix support for 5 GHz only BCM43228 model

[PATCH][FIX][RESEND] b43: fix support for 5 GHz only BCM43228 model

[Kalle Valo]

Rafa? Mi?ecki <zajec5@gmail.com> writes:

> It was incorrectly detected as 2 GHz device.
>
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> Cc: stable at vger.kernel.org # 3.17+
> ---
> Kalle: can you take it for 3.20, please?

Thanks, applied to wireless-drivers.git.

> RESEND: It seems patchwork didn't catch my patch. Trying again.

Odd, I still don't see it in patchwork. I wonder what caused that?

-- 
Kalle Valo

[PATCH][FIX][RESEND] b43: fix support for 5 GHz only BCM43228 model

[Jonas Gorski]

On Tue, Mar 3, 2015 at 4:05 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>> RESEND: It seems patchwork didn't catch my patch. Trying again.
>
> Odd, I still don't see it in patchwork. I wonder what caused that?

I also see it neither in my b43-dev nor linux-wireless archives, nor
does google find it (only your reply).


Jonas

[PATCH][FIX][RESEND] b43: fix support for 5 GHz only BCM43228 model

[Kalle Valo]

Jonas Gorski <jogo@openwrt.org> writes:

> On Tue, Mar 3, 2015 at 4:05 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>>> RESEND: It seems patchwork didn't catch my patch. Trying again.
>>
>> Odd, I still don't see it in patchwork. I wonder what caused that?
>
> I also see it neither in my b43-dev nor linux-wireless archives, nor
> does google find it (only your reply).

Ok, that explains why patchwork didn't catch it (it scans patches from
the linux-wireless mailing list). I already applied the patch to
wireless-drivers.git but I would appreciate if people would still review
it:

commit 0ff66cffde47de51c155ebdd2356403276c04cc4
Author: Rafa? Mi?ecki <zajec5@gmail.com>
Date:   Mon Mar 2 17:18:55 2015 +0100

    b43: fix support for 5 GHz only BCM43228 model
    
    It was incorrectly detected as 2 GHz device.
    
    Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
    Cc: stable at vger.kernel.org # 3.17+
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index ccbdb05b28cd..75345c1e8c34 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -5370,6 +5370,7 @@ static void b43_supported_bands(struct b43_wldev *dev, bool *have_2ghz_phy,
 	case 0x432a: /* BCM4321 */
 	case 0x432d: /* BCM4322 */
 	case 0x4352: /* BCM43222 */
+	case 0x435a: /* BCM43228 */
 	case 0x4333: /* BCM4331 */
 	case 0x43a2: /* BCM4360 */
 	case 0x43b3: /* BCM4352 */


-- 
Kalle Valo

[PATCH][FIX][RESEND] b43: fix support for 5 GHz only BCM43228 model

[Jonas Gorski]

On Tue, Mar 3, 2015 at 4:44 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Jonas Gorski <jogo@openwrt.org> writes:
>
>> On Tue, Mar 3, 2015 at 4:05 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>>>> RESEND: It seems patchwork didn't catch my patch. Trying again.
>>>
>>> Odd, I still don't see it in patchwork. I wonder what caused that?
>>
>> I also see it neither in my b43-dev nor linux-wireless archives, nor
>> does google find it (only your reply).
>
> Ok, that explains why patchwork didn't catch it (it scans patches from
> the linux-wireless mailing list). I already applied the patch to
> wireless-drivers.git but I would appreciate if people would still review
> it:
>
> commit 0ff66cffde47de51c155ebdd2356403276c04cc4
> Author: Rafa? Mi?ecki <zajec5@gmail.com>
> Date:   Mon Mar 2 17:18:55 2015 +0100
>
>     b43: fix support for 5 GHz only BCM43228 model
>
>     It was incorrectly detected as 2 GHz device.
>
>     Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
>     Cc: stable at vger.kernel.org # 3.17+
>     Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index ccbdb05b28cd..75345c1e8c34 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -5370,6 +5370,7 @@ static void b43_supported_bands(struct b43_wldev *dev, bool *have_2ghz_phy,
>         case 0x432a: /* BCM4321 */
>         case 0x432d: /* BCM4322 */
>         case 0x4352: /* BCM43222 */
> +       case 0x435a: /* BCM43228 */

Broadcom agrees with that (taken from a broadcom sdk for bcm47xx):

#define BCM43228_D11N_ID        0x4359          /* 43228 802.11n
DualBand device */
#define BCM43228_D11N5G_ID      0x435a          /* 43228 802.11n 5GHz device */


If that's enough for you, feel free to add a Reviewed-By from me.


Jonas

[PATCH][FIX][RESEND] b43: fix support for 5 GHz only BCM43228 model

[Jonas Gorski]

On Tue, Mar 3, 2015 at 4:49 PM, Jonas Gorski <jogo@openwrt.org> wrote:
> If that's enough for you, feel free to add a Reviewed-By from me.

Obviously you can't since you already applied it, so just add it in
your head ;-)


Jonas

[PATCH][FIX][RESEND] b43: fix support for 5 GHz only BCM43228 model

[Kalle Valo]

Jonas Gorski <jogo@openwrt.org> writes:

> On Tue, Mar 3, 2015 at 4:49 PM, Jonas Gorski <jogo@openwrt.org> wrote:
>> If that's enough for you, feel free to add a Reviewed-By from me.
>
> Obviously you can't since you already applied it, so just add it in
> your head ;-)

Yeah, the train has left the station. But thanks for double checking, I
can sleep safer now :)

-- 
Kalle Valo