* leftover b43-related cruft in drivers/net/wireless?
@ 2014-09-18 9:02 Robert P. J. Day
2014-09-18 9:17 ` Rafał Miłecki
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2014-09-18 9:02 UTC (permalink / raw)
To: b43-dev
i have a shell script that scans selected parts of the kernel source
tree to locate, among other things, unused config variables in
Kconfig files, and it identified the following under
drivers/net/wireless:
$ find_unused_configs.sh drivers/net/wireless
>>>>> B43_BCMA_PIO
drivers/net/wireless/b43/Kconfig:113:config B43_BCMA_PIO
>>>>> B43_BUSES_SSB
drivers/net/wireless/b43/Kconfig:52:config B43_BUSES_SSB
>>>>> B43LEGACY_DMA_MODE
drivers/net/wireless/b43legacy/Kconfig:85:config B43LEGACY_DMA_MODE
>>>>> B43LEGACY_PCICORE_AUTOSELECT
drivers/net/wireless/b43legacy/Kconfig:31:config B43LEGACY_PCICORE_AUTOSELECT
>>>>> B43LEGACY_PIO_MODE
drivers/net/wireless/b43legacy/Kconfig:92:config B43LEGACY_PIO_MODE
>>>>> B43_PCICORE_AUTOSELECT
drivers/net/wireless/b43/Kconfig:68:config B43_PCICORE_AUTOSELECT
>>>>> B43_PIO
drivers/net/wireless/b43/Kconfig:119:config B43_PIO
$
no real harm, just means that there are Kconfig definitions of the
above variables that no one appears to be testing for in the entire
kernel source tree, so they're potentially safe to be removed.
feel free to do with that what you will.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread
* leftover b43-related cruft in drivers/net/wireless?
2014-09-18 9:02 leftover b43-related cruft in drivers/net/wireless? Robert P. J. Day
@ 2014-09-18 9:17 ` Rafał Miłecki
0 siblings, 0 replies; 2+ messages in thread
From: Rafał Miłecki @ 2014-09-18 9:17 UTC (permalink / raw)
To: b43-dev
On 18 September 2014 11:02, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> i have a shell script that scans selected parts of the kernel source
> tree to locate, among other things, unused config variables in
> Kconfig files, and it identified the following under
> drivers/net/wireless:
>
> $ find_unused_configs.sh drivers/net/wireless
>>>>>> B43_BCMA_PIO
> drivers/net/wireless/b43/Kconfig:113:config B43_BCMA_PIO
>>>>>> B43_BUSES_SSB
> drivers/net/wireless/b43/Kconfig:52:config B43_BUSES_SSB
>>>>>> B43LEGACY_DMA_MODE
> drivers/net/wireless/b43legacy/Kconfig:85:config B43LEGACY_DMA_MODE
>>>>>> B43LEGACY_PCICORE_AUTOSELECT
> drivers/net/wireless/b43legacy/Kconfig:31:config B43LEGACY_PCICORE_AUTOSELECT
>>>>>> B43LEGACY_PIO_MODE
> drivers/net/wireless/b43legacy/Kconfig:92:config B43LEGACY_PIO_MODE
>>>>>> B43_PCICORE_AUTOSELECT
> drivers/net/wireless/b43/Kconfig:68:config B43_PCICORE_AUTOSELECT
>>>>>> B43_PIO
> drivers/net/wireless/b43/Kconfig:119:config B43_PIO
> $
>
> no real harm, just means that there are Kconfig definitions of the
> above variables that no one appears to be testing for in the entire
> kernel source tree, so they're potentially safe to be removed.
I didn't check all the symbols, but some of them are kind of helpers
for configuring the driver.
For example B43_BUSES_SSB while looks unused, it is here for
select-ing B43_SSB. I wanted to use "choice" to prevent users from
compiling b43 without any bus support which doesn't make much sense.
The same applies to the B43_BCMA_PIO and B43_PIO (this one should be
B43_SSB_PIO actually), they are helpers for selecting PIO support at
bus driver level.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-18 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-18 9:02 leftover b43-related cruft in drivers/net/wireless? Robert P. J. Day
2014-09-18 9:17 ` Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox