From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
backports@vger.kernel.org
Subject: Re: [PATCH 3/3] backports: support class_groups
Date: Tue, 07 Feb 2017 07:29:09 +0100 [thread overview]
Message-ID: <1486448949.5430.10.camel@sipsolutions.net> (raw)
In-Reply-To: <445404f1-7231-fb2f-0faf-5093b69926ae@broadcom.com> (sfid-20170206_233705_198112_9B6CF8A7)
> > Change-Id: I114e1a6ed8db901b3aa738a5052721d1da45cae4
>
> Does it make sense to keep the Change-Id: things here?
Not really. But eventually I got lazy. I've now removed the auto-
generation for my tree, which means I'll have to add it manually
internally, but whatever :)
> > +@ class_group @
> > +identifier group_class;
> > +identifier attribute_groups_name.groups;
> > +fresh identifier group_dev_attr = attribute_group.group ##
> > "_dev_attrs";
>
> So how will this work wrt naming scheme. Can we be sure all
> class_attrs occurrences in the files we copy are named as such, ie.
> with _dev_attrs post-fix?
No no, that's not what happens here. The _dev_attrs postfix is
generated by the ATTRIBUTE_GROUPS_BACKPORT() macro.
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
prev parent reply other threads:[~2017-02-07 6:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 12:39 [PATCH 1/3] backports: devcoredump: make patch apply Johannes Berg
2017-02-06 12:39 ` [PATCH 2/3] backports: restrict group_attr spatch properly Johannes Berg
2017-02-06 22:22 ` Arend Van Spriel
2017-02-06 12:39 ` [PATCH 3/3] backports: support class_groups Johannes Berg
2017-02-06 22:36 ` Arend Van Spriel
2017-02-07 6:29 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486448949.5430.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=backports@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox