From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: backports@vger.kernel.org
Subject: Re: [PATCH 3/4] backports: introduce new definition for DECLARE_EWMA macro
Date: Fri, 10 Mar 2017 07:36:14 +0100 [thread overview]
Message-ID: <1489127774.3038.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1489064253-3652-4-git-send-email-arend.vanspriel@broadcom.com> (sfid-20170309_140611_189597_39E350D6)
On Thu, 2017-03-09 at 12:57 +0000, Arend van Spriel wrote:
> Since commit eb1e011a1474 ("average: change to declare precision,
> not factor") the definition of DECLARE_EWMA has changed so we
> need a backport for the new macro as it differs. Changing the
> strategy by checking the kernel version and #undef the macro to
> be sure we do not run into macro redefinition issue.
Good one. However, why not just add this file to copy-list and be done
with it? That way, the original one from the kernel will never be
included at all and we'll always have the right version. Not that I
think we'll change it much, but why not make it easier?
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2017-03-10 6:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 12:57 [PATCH 0/4] backports: fixes for wireless-testing Arend van Spriel
2017-03-09 12:57 ` [PATCH 1/4] patches: update crypto-ccm.patch for v4.11-rc1 Arend van Spriel
2017-03-10 6:34 ` Johannes Berg
2017-03-10 9:49 ` Arend Van Spriel
2017-03-10 9:52 ` Johannes Berg
2017-03-10 10:08 ` Arend Van Spriel
2017-03-10 10:09 ` Johannes Berg
2017-03-09 12:57 ` [PATCH 2/4] backports: add backport for idr_remove Arend van Spriel
2017-03-09 12:57 ` [PATCH 3/4] backports: introduce new definition for DECLARE_EWMA macro Arend van Spriel
2017-03-10 6:36 ` Johannes Berg [this message]
2017-03-10 9:53 ` Arend Van Spriel
2017-03-14 13:49 ` Johannes Berg
2017-03-09 12:57 ` [PATCH 4/4] backports: add dummy include/linux/sched/signal.h Arend van Spriel
2017-03-31 7:29 ` [PATCH 0/4] backports: fixes for wireless-testing Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489127774.3038.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=backports@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox