* Re: [PATCH] compat: drop const to fix compiler warnings
[not found] <1347004574-80506-1-git-send-email-nbd@openwrt.org>
@ 2012-09-07 9:04 ` Luis R. Rodriguez
2012-09-07 9:12 ` Felix Fietkau
2012-09-07 12:59 ` Andy Gospodarek
0 siblings, 2 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2012-09-07 9:04 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, backports
On Fri, Sep 7, 2012 at 12:56 AM, Felix Fietkau <nbd@openwrt.org> wrote:
> When calling pci_find_capability and pci_read_config_word, struct pci_dev
> needs to be passed without const.
Thanks! I guess because at certain kernel version pci_dev was const ?
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] compat: drop const to fix compiler warnings
2012-09-07 9:04 ` [PATCH] compat: drop const to fix compiler warnings Luis R. Rodriguez
@ 2012-09-07 9:12 ` Felix Fietkau
2012-09-07 12:59 ` Andy Gospodarek
1 sibling, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2012-09-07 9:12 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linux-wireless, backports
On 2012-09-07 11:04 AM, Luis R. Rodriguez wrote:
> On Fri, Sep 7, 2012 at 12:56 AM, Felix Fietkau <nbd@openwrt.org> wrote:
>> When calling pci_find_capability and pci_read_config_word, struct pci_dev
>> needs to be passed without const.
>
> Thanks! I guess because at certain kernel version pci_dev was const ?
Probably, I didn't really check. Either way, this patch should be safe
for all kernel versions.
- Felix
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] compat: drop const to fix compiler warnings
2012-09-07 9:04 ` [PATCH] compat: drop const to fix compiler warnings Luis R. Rodriguez
2012-09-07 9:12 ` Felix Fietkau
@ 2012-09-07 12:59 ` Andy Gospodarek
1 sibling, 0 replies; 3+ messages in thread
From: Andy Gospodarek @ 2012-09-07 12:59 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: Felix Fietkau, linux-wireless, backports
On Fri, Sep 07, 2012 at 02:04:37AM -0700, Luis R. Rodriguez wrote:
> On Fri, Sep 7, 2012 at 12:56 AM, Felix Fietkau <nbd@openwrt.org> wrote:
> > When calling pci_find_capability and pci_read_config_word, struct pci_dev
> > needs to be passed without const.
>
> Thanks! I guess because at certain kernel version pci_dev was const ?
>
Similar issues exist with ethtool_ops, but it's not a huge deal, imo.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-07 13:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1347004574-80506-1-git-send-email-nbd@openwrt.org>
2012-09-07 9:04 ` [PATCH] compat: drop const to fix compiler warnings Luis R. Rodriguez
2012-09-07 9:12 ` Felix Fietkau
2012-09-07 12:59 ` Andy Gospodarek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox