Re: [PATCH batadv 2/5] batman-adv: only create hardif while a netdev is part of a mesh

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]

On Saturday, 31 May 2025 11:52:12 CEST Sven Eckelmann wrote:
> On Monday, 19 May 2025 22:46:29 CEST Matthias Schiffer wrote:
> > -int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,
> > +int batadv_hardif_enable_interface(struct net_device *net_dev,
> >                                    struct net_device *mesh_iface)
> >  {
> [....]
> > +       hard_iface->wifi_flags = batadv_wifi_flags_evaluate(net_dev);
> 
> Moving this here should break the WIFI TT flag in scenarios like this:
> 
>                    ┌──────┐             
>        ┌───────────┼br-lan├──────┐      
>        │           └──────┘      │      
>        │                         │      
>        │                         │      
>      ┌─▼─┐                    ┌──▼─┐    
>      │ap0│                    │bat0│    
>      └───┘                    └──┬─┘    
>                                  │      
>                                  │      
>                               ┌──▼──┐   
>                               │mesh0│   
>                               └─────┘   
> 
> 
> ap0 is not the lower interface of any batadv mesh interface but TT ap 
> isolation is depending on the information stored for this hardif. See:

I have now posted 
https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/20260510-hardif-wifi-cache-v1-1-6dce5ee6b0f9@narfation.org/
to separate the wifi flags from the code (around batadv_hardif) which you 
try to modify.

Regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]